Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve comments for os patching #24872

Merged
merged 6 commits into from
Jul 18, 2023

rename property

0e5ee89
Select commit
Loading
Failed to load commit list.
Merged

Resolve comments for os patching #24872

rename property
0e5ee89
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[Staging] Swagger LintDiff succeeded Jul 18, 2023 in 4m 40s

~[Staging] Swagger LintDiff succeeded

ppe/LintDiff
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-08 package-preview-2023-08(0e5ee89) package-preview-2023-08(teom-hobovm08-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2912


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3883
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3875
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3871
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3858
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3671
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L3017
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2994
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2970
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2941
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2937
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2934
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2930
❌ AvoidAdditionalProperties The use of additionalProperties is not allowed except for user defined tags on tracked resources.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2922
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2426
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L2351
View more details on openapi-pipeline-app