Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename enum for patchStatus #25257

Merged
merged 15 commits into from
Aug 10, 2023

Merge branch 'teom-hobovm08-01-preview' of https://github.com/chrjia/…

1925d7f
Select commit
Loading
Failed to load commit list.
Merged

Rename enum for patchStatus #25257

Merge branch 'teom-hobovm08-01-preview' of https://github.com/chrjia/…
1925d7f
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Aug 10, 2023 in 4m 31s

Swagger LintDiff succeeded

LintDiff
View more details.

Details

compared tags (via openapi-validator v2.1.4) new version base version
package-preview-2023-08 package-preview-2023-08(1925d7f) package-preview-2023-08(teom-hobovm08-01-preview)

The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L110
❌ PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L388
❌ PatchResponseCode LRO PATCH must have 200 and 202 return codes.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L415
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L444
❌ PatchSkuProperty The patch operation body parameter schema should contain property 'sku'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L444
❌ ConsistentPatchProperties The property 'properties.properties' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L448
❌ LroPatch202 The async patch operation should return 202.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L454
❌ SyncPostReturn 200 response for a synchronous POST operation must have a response schema specified.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L532
❌ CollectionObjectPropertiesNaming Collection object returned by list operation 'Compute_ListNodes' with 'x-ms-pageable' extension, has no property named 'value'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L613
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L713
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L757
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L801
❌ SyncPostReturn 200 response for a synchronous POST operation must have a response schema specified.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L814
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L44
⚠️ PageableOperation Based on the response model schema, operation 'VirtualMachineSizes_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L85
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L91
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L129
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L135
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L188
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L237
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L244
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L283
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L299
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L336
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L368
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L420
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L428
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L474
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L482
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L537
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L544
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L591
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L593
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L641
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L648
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L687
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L695
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L731
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L739
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L775
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L783
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L818
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L825
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L865
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L870
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L872
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ComputeModel'. Consider using the plural form of 'Compute' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L916
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L919
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L1183
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json#L1189
View more details on openapi-pipeline-app