Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AzureStackHCI to add version preview/2021-07-01-preview #25288

Conversation

pathuang-sia
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 11, 2023

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
virtualMachines.json 2021-07-01-preview(fa4d958) 2021-07-01-preview(main)
Rule Message
1027 - DefaultValueChanged The new version has a different default value than the previous one.
New: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L417:13
Old: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L417:13
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) new version base version
package-preview-2021-07 package-preview-2021-07(fa4d958) package-preview-2021-07(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L37
ResourceNameRestriction The resource name parameter 'virtualmachinesName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L37
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/start'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L209
ResourceNameRestriction The resource name parameter 'virtualmachinesName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L209
LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L210
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L245
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/stop'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L251
ResourceNameRestriction The resource name parameter 'virtualmachinesName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L251
LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L252
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L287
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines/{virtualmachinesName}/restart'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L293
ResourceNameRestriction The resource name parameter 'virtualmachinesName' should be defined with a 'pattern' restriction.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L293
LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L294
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L329
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureStackHCI/virtualmachines'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L335
PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.AzureStackHCI/virtualmachines'
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L373
ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L626
⚠️ PreviewVersionOverOneYear The API version:2021-07-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L6
⚠️ OperationSummaryOrDescription Operation should have a summary or description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L38
⚠️ GetInOperationName 'GET' operation 'virtualmachines_Retrieve' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L39
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'virtualmachinesModel'. Consider using the plural form of 'virtualmachines' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L39
⚠️ ParameterDescription Parameter should have a description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L52
⚠️ OperationSummaryOrDescription Operation should have a summary or description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L74
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'virtualmachinesModel'. Consider using the plural form of 'virtualmachines' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L75
⚠️ ParameterDescription Parameter should have a description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L92
⚠️ ParameterDescription Parameter should have a description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L98
⚠️ OperationSummaryOrDescription Operation should have a summary or description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L128
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'virtualmachinesModel'. Consider using the plural form of 'virtualmachines' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L129
⚠️ ParameterDescription Parameter should have a description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L142
⚠️ OperationSummaryOrDescription Operation should have a summary or description.
Location: Microsoft.AzureStackHCI/preview/2021-07-01-preview/virtualMachines.json#L164
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @pathuang-sia! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 11, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-azurestackhci - Approved - 7.0.0
    +	Model ArcSetting no longer has parameter created_at
    +	Model ArcSetting no longer has parameter created_by
    +	Model ArcSetting no longer has parameter created_by_type
    +	Model ArcSetting no longer has parameter last_modified_at
    +	Model ArcSetting no longer has parameter last_modified_by
    +	Model ArcSetting no longer has parameter last_modified_by_type
    +	Model Cluster no longer has parameter created_at
    +	Model Cluster no longer has parameter created_by
    +	Model Cluster no longer has parameter created_by_type
    +	Model Cluster no longer has parameter last_modified_at
    +	Model Cluster no longer has parameter last_modified_by
    +	Model Cluster no longer has parameter last_modified_by_type
    +	Model Extension no longer has parameter created_at
    +	Model Extension no longer has parameter created_by
    +	Model Extension no longer has parameter created_by_type
    +	Model Extension no longer has parameter last_modified_at
    +	Model Extension no longer has parameter last_modified_by
    +	Model Extension no longer has parameter last_modified_by_type
    azure-sdk-for-js - @azure/arm-azurestackhci - Approved - 4.0.0
    +	Interface ArcSetting no longer has parameter createdAt
    +	Interface ArcSetting no longer has parameter createdBy
    +	Interface ArcSetting no longer has parameter createdByType
    +	Interface ArcSetting no longer has parameter lastModifiedAt
    +	Interface ArcSetting no longer has parameter lastModifiedBy
    +	Interface ArcSetting no longer has parameter lastModifiedByType
    +	Interface Cluster no longer has parameter createdAt
    +	Interface Cluster no longer has parameter createdBy
    +	Interface Cluster no longer has parameter createdByType
    +	Interface Cluster no longer has parameter lastModifiedAt
    +	Interface Cluster no longer has parameter lastModifiedBy
    +	Interface Cluster no longer has parameter lastModifiedByType
    +	Interface Extension no longer has parameter createdAt
    +	Interface Extension no longer has parameter createdBy
    +	Interface Extension no longer has parameter createdByType
    +	Interface Extension no longer has parameter lastModifiedAt
    +	Interface Extension no longer has parameter lastModifiedBy
    +	Interface Extension no longer has parameter lastModifiedByType
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 742718d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-azurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation GuestAgentsOperations.list
      info	[Changelog]   - Added operation HybridIdentityMetadataOperations.list
      info	[Changelog]   - Added operation group GalleryImagesOperations
      info	[Changelog]   - Added operation group MarketplaceGalleryImagesOperations
      info	[Changelog]   - Added operation group NetworkInterfacesOperations
      info	[Changelog]   - Added operation group StorageContainersOperations
      info	[Changelog]   - Added operation group VirtualHardDisksOperations
      info	[Changelog]   - Added operation group VirtualMachineInstancesOperations
      info	[Changelog]   - Added operation group VirtualNetworksOperations
      info	[Changelog]   - Model HardwareProfileUpdate has a new parameter memory_mb
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model StorageProfileUpdateDataDisksItem has a new parameter id
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model HardwareProfileUpdate no longer has parameter memory_gb
      info	[Changelog]   - Model StorageProfileUpdateDataDisksItem no longer has parameter name
      info	[Changelog]   - Operation GuestAgentOperations.begin_create has a new required parameter resource_uri
      info	[Changelog]   - Operation GuestAgentOperations.begin_create no longer has parameter name
      info	[Changelog]   - Operation GuestAgentOperations.begin_create no longer has parameter resource_group_name
      info	[Changelog]   - Operation GuestAgentOperations.begin_create no longer has parameter virtual_machine_name
      info	[Changelog]   - Operation GuestAgentOperations.begin_delete has a new required parameter resource_uri
      info	[Changelog]   - Operation GuestAgentOperations.begin_delete no longer has parameter name
      info	[Changelog]   - Operation GuestAgentOperations.begin_delete no longer has parameter resource_group_name
      info	[Changelog]   - Operation GuestAgentOperations.begin_delete no longer has parameter virtual_machine_name
      info	[Changelog]   - Operation GuestAgentOperations.get has a new required parameter resource_uri
      info	[Changelog]   - Operation GuestAgentOperations.get no longer has parameter name
      info	[Changelog]   - Operation GuestAgentOperations.get no longer has parameter resource_group_name
      info	[Changelog]   - Operation GuestAgentOperations.get no longer has parameter virtual_machine_name
      info	[Changelog]   - Operation HybridIdentityMetadataOperations.get has a new required parameter resource_uri
      info	[Changelog]   - Operation HybridIdentityMetadataOperations.get no longer has parameter metadata_name
      info	[Changelog]   - Operation HybridIdentityMetadataOperations.get no longer has parameter resource_group_name
      info	[Changelog]   - Operation HybridIdentityMetadataOperations.get no longer has parameter virtual_machine_name
      info	[Changelog]   - Removed operation GuestAgentsOperations.list_by_virtual_machines
      info	[Changelog]   - Removed operation HybridIdentityMetadataOperations.create
      info	[Changelog]   - Removed operation HybridIdentityMetadataOperations.delete
      info	[Changelog]   - Removed operation HybridIdentityMetadataOperations.list_by_virtual_machines
      info	[Changelog]   - Removed operation group ArcSettingsOperations
      info	[Changelog]   - Removed operation group ClustersOperations
      info	[Changelog]   - Removed operation group ExtensionsOperations
      info	[Changelog]   - Removed operation group GalleryimagesOperations
      info	[Changelog]   - Removed operation group MachineExtensionsOperations
      info	[Changelog]   - Removed operation group MarketplacegalleryimagesOperations
      info	[Changelog]   - Removed operation group NetworkinterfacesOperations
      info	[Changelog]   - Removed operation group StoragecontainersOperations
      info	[Changelog]   - Removed operation group VirtualharddisksOperations
      info	[Changelog]   - Removed operation group VirtualmachinesOperations
      info	[Changelog]   - Removed operation group VirtualnetworksOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 742718d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-azurestackhci [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 742718d. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/azurestackhci/armazurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New function `*VirtualMachineInstancesClient.BeginUpdate(context.Context, string, VirtualMachineInstanceUpdateRequest, *VirtualMachineInstancesClientBeginUpdateOptions) (*runtime.Poller[VirtualMachineInstancesClientUpdateResponse], error)`
      info	[Changelog] - New function `NewVirtualNetworksClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualNetworksClient, error)`
      info	[Changelog] - New function `*VirtualNetworksClient.BeginCreateOrUpdate(context.Context, string, string, VirtualNetworks, *VirtualNetworksClientBeginCreateOrUpdateOptions) (*runtime.Poller[VirtualNetworksClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*VirtualNetworksClient.BeginDelete(context.Context, string, string, *VirtualNetworksClientBeginDeleteOptions) (*runtime.Poller[VirtualNetworksClientDeleteResponse], error)`
      info	[Changelog] - New function `*VirtualNetworksClient.Get(context.Context, string, string, *VirtualNetworksClientGetOptions) (VirtualNetworksClientGetResponse, error)`
      info	[Changelog] - New function `*VirtualNetworksClient.NewListAllPager(*VirtualNetworksClientListAllOptions) *runtime.Pager[VirtualNetworksClientListAllResponse]`
      info	[Changelog] - New function `*VirtualNetworksClient.NewListPager(string, *VirtualNetworksClientListOptions) *runtime.Pager[VirtualNetworksClientListResponse]`
      info	[Changelog] - New function `*VirtualNetworksClient.BeginUpdate(context.Context, string, string, VirtualNetworksUpdateRequest, *VirtualNetworksClientBeginUpdateOptions) (*runtime.Poller[VirtualNetworksClientUpdateResponse], error)`
      info	[Changelog] - New function `NewNetworkInterfacesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkInterfacesClient, error)`
      info	[Changelog] - New function `*NetworkInterfacesClient.BeginCreateOrUpdate(context.Context, string, string, NetworkInterfaces, *NetworkInterfacesClientBeginCreateOrUpdateOptions) (*runtime.Poller[NetworkInterfacesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*NetworkInterfacesClient.BeginDelete(context.Context, string, string, *NetworkInterfacesClientBeginDeleteOptions) (*runtime.Poller[NetworkInterfacesClientDeleteResponse], error)`
      info	[Changelog] - New function `*NetworkInterfacesClient.Get(context.Context, string, string, *NetworkInterfacesClientGetOptions) (NetworkInterfacesClientGetResponse, error)`
      info	[Changelog] - New function `*NetworkInterfacesClient.NewListAllPager(*NetworkInterfacesClientListAllOptions) *runtime.Pager[NetworkInterfacesClientListAllResponse]`
      info	[Changelog] - New function `*NetworkInterfacesClient.NewListPager(string, *NetworkInterfacesClientListOptions) *runtime.Pager[NetworkInterfacesClientListResponse]`
      info	[Changelog] - New function `*NetworkInterfacesClient.BeginUpdate(context.Context, string, string, NetworkInterfacesUpdateRequest, *NetworkInterfacesClientBeginUpdateOptions) (*runtime.Poller[NetworkInterfacesClientUpdateResponse], error)`
      info	[Changelog] - New struct `Components3Iu67JSchemasVirtualnetworkpropertiesPropertiesSubnetsItemsPropertiesRoutetableProperties`
      info	[Changelog] - New struct `ComponentsCr63WSchemasVirtualnetworkpropertiesPropertiesSubnetsItemsPropertiesIPConfigurationreferencesItems`
      info	[Changelog] - New struct `ComponentsI4F0MhSchemasVirtualnetworkpropertiesPropertiesSubnetsItemsPropertiesRoutetable`
      info	[Changelog] - New struct `ExtendedLocation`
      info	[Changelog] - New struct `GalleryDiskImage`
      info	[Changelog] - New struct `GalleryImageIdentifier`
      info	[Changelog] - New struct `GalleryImageProperties`
      info	[Changelog] - New struct `GalleryImageStatus`
      info	[Changelog] - New struct `GalleryImageStatusDownloadStatus`
      info	[Changelog] - New struct `GalleryImageStatusProvisioningStatus`
      info	[Changelog] - New struct `GalleryImageVersion`
      info	[Changelog] - New struct `GalleryImageVersionProperties`
      info	[Changelog] - New struct `GalleryImageVersionStorageProfile`
      info	[Changelog] - New struct `GalleryImages`
      info	[Changelog] - New struct `GalleryImagesListResult`
      info	[Changelog] - New struct `GalleryImagesUpdateRequest`
      info	[Changelog] - New struct `GalleryOSDiskImage`
      info	[Changelog] - New struct `GuestAgent`
      info	[Changelog] - New struct `GuestAgentInstallStatus`
      info	[Changelog] - New struct `GuestAgentList`
      info	[Changelog] - New struct `GuestAgentProperties`
      info	[Changelog] - New struct `GuestCredential`
      info	[Changelog] - New struct `HTTPProxyConfiguration`
      info	[Changelog] - New struct `HardwareProfileUpdate`
      info	[Changelog] - New struct `HybridIdentityMetadata`
      info	[Changelog] - New struct `HybridIdentityMetadataList`
      info	[Changelog] - New struct `HybridIdentityMetadataProperties`
      info	[Changelog] - New struct `IPConfiguration`
      info	[Changelog] - New struct `IPConfigurationProperties`
      info	[Changelog] - New struct `IPConfigurationPropertiesSubnet`
      info	[Changelog] - New struct `Identity`
      info	[Changelog] - New struct `InstanceViewStatus`
      info	[Changelog] - New struct `InterfaceDNSSettings`
      info	[Changelog] - New struct `MarketplaceGalleryImageProperties`
      info	[Changelog] - New struct `MarketplaceGalleryImageStatus`
      info	[Changelog] - New struct `MarketplaceGalleryImageStatusDownloadStatus`
      info	[Changelog] - New struct `MarketplaceGalleryImageStatusProvisioningStatus`
      info	[Changelog] - New struct `MarketplaceGalleryImages`
      info	[Changelog] - New struct `MarketplaceGalleryImagesListResult`
      info	[Changelog] - New struct `MarketplaceGalleryImagesUpdateRequest`
      info	[Changelog] - New struct `NetworkInterfaceProperties`
      info	[Changelog] - New struct `NetworkInterfaceStatus`
      info	[Changelog] - New struct `NetworkInterfaceStatusProvisioningStatus`
      info	[Changelog] - New struct `NetworkInterfaces`
      info	[Changelog] - New struct `NetworkInterfacesListResult`
      info	[Changelog] - New struct `NetworkInterfacesUpdateRequest`
      info	[Changelog] - New struct `NetworkProfileUpdate`
      info	[Changelog] - New struct `NetworkProfileUpdateNetworkInterfacesItem`
      info	[Changelog] - New struct `OsProfileUpdate`
      info	[Changelog] - New struct `OsProfileUpdateLinuxConfiguration`
      info	[Changelog] - New struct `OsProfileUpdateWindowsConfiguration`
      info	[Changelog] - New struct `SSHConfiguration`
      info	[Changelog] - New struct `SSHPublicKey`
      info	[Changelog] - New struct `StorageContainerProperties`
      info	[Changelog] - New struct `StorageContainerStatus`
      info	[Changelog] - New struct `StorageContainerStatusProvisioningStatus`
      info	[Changelog] - New struct `StorageContainers`
      info	[Changelog] - New struct `StorageContainersListResult`
      info	[Changelog] - New struct `StorageContainersUpdateRequest`
      info	[Changelog] - New struct `StorageProfileUpdate`
      info	[Changelog] - New struct `StorageProfileUpdateDataDisksItem`
      info	[Changelog] - New struct `VirtualHardDiskProperties`
      info	[Changelog] - New struct `VirtualHardDiskStatus`
      info	[Changelog] - New struct `VirtualHardDiskStatusProvisioningStatus`
      info	[Changelog] - New struct `VirtualHardDisks`
      info	[Changelog] - New struct `VirtualHardDisksListResult`
      info	[Changelog] - New struct `VirtualHardDisksUpdateRequest`
      info	[Changelog] - New struct `VirtualMachineInstance`
      info	[Changelog] - New struct `VirtualMachineInstanceListResult`
      info	[Changelog] - New struct `VirtualMachineInstanceProperties`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesHardwareProfile`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesHardwareProfileDynamicMemoryConfig`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesNetworkProfile`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesNetworkProfileNetworkInterfacesItem`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesOsProfile`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesOsProfileLinuxConfiguration`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesOsProfileWindowsConfiguration`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesSecurityProfile`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesSecurityProfileUefiSettings`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfile`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileDataDisksItem`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileImageReference`
      info	[Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileOsDisk`
      info	[Changelog] - New struct `VirtualMachineInstanceStatus`
      info	[Changelog] - New struct `VirtualMachineInstanceStatusProvisioningStatus`
      info	[Changelog] - New struct `VirtualMachineInstanceUpdateProperties`
      info	[Changelog] - New struct `VirtualMachineInstanceUpdateRequest`
      info	[Changelog] - New struct `VirtualMachineInstanceView`
      info	[Changelog] - New struct `VirtualMachineVMConfigAgentInstanceView`
      info	[Changelog] - New struct `VirtualNetworkProperties`
      info	[Changelog] - New struct `VirtualNetworkPropertiesDhcpOptions`
      info	[Changelog] - New struct `VirtualNetworkPropertiesSubnetsItem`
      info	[Changelog] - New struct `VirtualNetworkPropertiesSubnetsItemAutoGenerated`
      info	[Changelog] - New struct `VirtualNetworkPropertiesSubnetsItemRouteTableRoutesItem`
      info	[Changelog] - New struct `VirtualNetworkPropertiesSubnetsPropertiesItemsItem`
      info	[Changelog] - New struct `VirtualNetworkStatus`
      info	[Changelog] - New struct `VirtualNetworkStatusProvisioningStatus`
      info	[Changelog] - New struct `VirtualNetworks`
      info	[Changelog] - New struct `VirtualNetworksListResult`
      info	[Changelog] - New struct `VirtualNetworksUpdateRequest`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 94 breaking change(s), 357 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 742718d. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-azurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface VirtualNetworksListResult
      info	[Changelog]   - Added Interface VirtualNetworkStatus
      info	[Changelog]   - Added Interface VirtualNetworkStatusProvisioningStatus
      info	[Changelog]   - Added Interface VirtualNetworksUpdateHeaders
      info	[Changelog]   - Added Interface VirtualNetworksUpdateOptionalParams
      info	[Changelog]   - Added Interface VirtualNetworksUpdateRequest
      info	[Changelog]   - Added Type Alias CloudInitDataSource
      info	[Changelog]   - Added Type Alias DiskFileFormat
      info	[Changelog]   - Added Type Alias ExtendedLocationTypes
      info	[Changelog]   - Added Type Alias GalleryImagesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GalleryImagesGetResponse
      info	[Changelog]   - Added Type Alias GalleryImagesListAllNextResponse
      info	[Changelog]   - Added Type Alias GalleryImagesListAllResponse
      info	[Changelog]   - Added Type Alias GalleryImagesListNextResponse
      info	[Changelog]   - Added Type Alias GalleryImagesListResponse
      info	[Changelog]   - Added Type Alias GalleryImagesUpdateResponse
      info	[Changelog]   - Added Type Alias GuestAgentCreateResponse
      info	[Changelog]   - Added Type Alias GuestAgentDeleteResponse
      info	[Changelog]   - Added Type Alias GuestAgentGetResponse
      info	[Changelog]   - Added Type Alias GuestAgentsListNextResponse
      info	[Changelog]   - Added Type Alias GuestAgentsListResponse
      info	[Changelog]   - Added Type Alias HybridIdentityMetadataGetResponse
      info	[Changelog]   - Added Type Alias HybridIdentityMetadataListNextResponse
      info	[Changelog]   - Added Type Alias HybridIdentityMetadataListResponse
      info	[Changelog]   - Added Type Alias HyperVGeneration
      info	[Changelog]   - Added Type Alias IpAllocationMethodEnum
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesGetResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesListAllNextResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesListAllResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesListNextResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesListResponse
      info	[Changelog]   - Added Type Alias MarketplaceGalleryImagesUpdateResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesGetResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesListAllNextResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesListAllResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesListNextResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesListResponse
      info	[Changelog]   - Added Type Alias NetworkInterfacesUpdateResponse
      info	[Changelog]   - Added Type Alias NetworkTypeEnum
      info	[Changelog]   - Added Type Alias OperatingSystemTypes
      info	[Changelog]   - Added Type Alias OperationsListNextResponse
      info	[Changelog]   - Added Type Alias PowerStateEnum
      info	[Changelog]   - Added Type Alias ProvisioningAction
      info	[Changelog]   - Added Type Alias ProvisioningStateEnum
      info	[Changelog]   - Added Type Alias SecurityTypes
      info	[Changelog]   - Added Type Alias StatusLevelTypes
      info	[Changelog]   - Added Type Alias StatusTypes
      info	[Changelog]   - Added Type Alias StorageContainersCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias StorageContainersGetResponse
      info	[Changelog]   - Added Type Alias StorageContainersListAllNextResponse
      info	[Changelog]   - Added Type Alias StorageContainersListAllResponse
      info	[Changelog]   - Added Type Alias StorageContainersListNextResponse
      info	[Changelog]   - Added Type Alias StorageContainersListResponse
      info	[Changelog]   - Added Type Alias StorageContainersUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksGetResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksListAllNextResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksListAllResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksListNextResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksListResponse
      info	[Changelog]   - Added Type Alias VirtualHardDisksUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesDeleteResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesGetResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesListNextResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesListResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesRestartResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesStartResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesStopResponse
      info	[Changelog]   - Added Type Alias VirtualMachineInstancesUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksGetResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListAllNextResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListAllResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListNextResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksUpdateResponse
      info	[Changelog]   - Added Type Alias VmSizeEnum
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownCloudInitDataSource
      info	[Changelog]   - Added Enum KnownDiskFileFormat
      info	[Changelog]   - Added Enum KnownExtendedLocationTypes
      info	[Changelog]   - Added Enum KnownHyperVGeneration
      info	[Changelog]   - Added Enum KnownIpAllocationMethodEnum
      info	[Changelog]   - Added Enum KnownNetworkTypeEnum
      info	[Changelog]   - Added Enum KnownPowerStateEnum
      info	[Changelog]   - Added Enum KnownProvisioningAction
      info	[Changelog]   - Added Enum KnownProvisioningStateEnum
      info	[Changelog]   - Added Enum KnownSecurityTypes
      info	[Changelog]   - Added Enum KnownStatusLevelTypes
      info	[Changelog]   - Added Enum KnownStatusTypes
      info	[Changelog]   - Added Enum KnownVmSizeEnum
      info	[Changelog]   - Enum KnownStatus has a new value Failed
      info	[Changelog]   - Enum KnownStatus has a new value InProgress
      info	[Changelog]   - Enum KnownStatus has a new value Succeeded
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group ArcSettings
      info	[Changelog]   - Removed operation group Clusters
      info	[Changelog]   - Removed operation group Extensions
      info	[Changelog]   - Class AzureStackHCIClient has a new signature
      info	[Changelog]   - Class AzureStackHCIClient no longer has parameter arcSettings
      info	[Changelog]   - Class AzureStackHCIClient no longer has parameter clusters
      info	[Changelog]   - Class AzureStackHCIClient no longer has parameter extensions
      info	[Changelog]   - Removed Enum KnownArcSettingAggregateState
      info	[Changelog]   - Removed Enum KnownDiagnosticLevel
      info	[Changelog]   - Removed Enum KnownExtensionAggregateState
      info	[Changelog]   - Removed Enum KnownImdsAttestation
      info	[Changelog]   - Removed Enum KnownNodeArcState
      info	[Changelog]   - Removed Enum KnownNodeExtensionState
      info	[Changelog]   - Removed Enum KnownProvisioningState
      info	[Changelog]   - Removed Enum KnownWindowsServerSubscription
      info	[Changelog]   - Enum KnownStatus no longer has value ConnectedRecently
      info	[Changelog]   - Enum KnownStatus no longer has value Disconnected
      info	[Changelog]   - Enum KnownStatus no longer has value Error
      info	[Changelog]   - Enum KnownStatus no longer has value NotConnectedRecently
      info	[Changelog]   - Enum KnownStatus no longer has value NotYetRegistered
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 742718d. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 742718d. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.azurestackhci.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.azurestackhci.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 11, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/azurestackhci/armazurestackhci https://apiview.dev/Assemblies/Review/ffd1b5c2444043bfb1cc97a3216f1f6c
    Java azure-resourcemanager-azurestackhci https://apiview.dev/Assemblies/Review/4fb463eec50449e5a1251a47029e28ef
    JavaScript @azure/arm-azurestackhci https://apiview.dev/Assemblies/Review/81bc5f54486a45c8a68e6aab63c919fb

    @pathuang-sia
    Copy link
    Contributor Author

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS labels Aug 11, 2023
    @openapi-workflow-bot
    Copy link

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @openapi-workflow-bot
    Copy link

    Hi @pathuang-sia! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 14, 2023
    @pathuang-sia pathuang-sia removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 14, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 14, 2023
    @ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 21, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 21, 2023

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @kazrael2119
    Copy link
    Contributor

    this js breaking is not caused by this pr

    @pathuang-sia
    Copy link
    Contributor Author

    /pr RequestMerge

    @ms-henglu ms-henglu merged commit 742718d into main Aug 22, 2023
    29 of 30 checks passed
    @ms-henglu ms-henglu deleted the pathuang-sia-azurestackhci-Microsoft.AzureStackHCI-2021-07-01-preview branch August 22, 2023 03:10
    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants