egress gateway is part of IstioComponents definition #25494

deveshdama · 2023-08-24T05:26:52Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- Fixing a bug with the 2023-06-02-preview and 2023-07-02-preview versions of ServiceMeshProfile object within ManagedCluster object for the Microsoft.ContainerService.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-24T05:26:55Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-workflow-bot · 2023-08-24T05:26:56Z

Hi @deveshdama, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

You can refer to Service API Toolset Introduction for details.

Please contact service focal contacts or Service API Toolset Support Channel if need further help.

openapi-pipeline-app · 2023-08-24T05:26:56Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedClusters.json	2023-06-02-preview(8d3b399)	2023-06-02-preview(main)
managedClusters.json	2023-07-02-preview(8d3b399)	2023-07-02-preview(main)

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'egressGateways' in response that was not found in the old version. New: aks/preview/2023-06-02-preview/managedClusters.json#L7975:7 Old: aks/preview/2023-06-02-preview/managedClusters.json#L7975:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'egressGateways' in response that was not found in the old version. New: aks/preview/2023-07-02-preview/managedClusters.json#L8241:7 Old: aks/preview/2023-07-02-preview/managedClusters.json#L8241:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'egressGateways' that was not found in the old version. New: aks/preview/2023-06-02-preview/managedClusters.json#L7975:7 Old: aks/preview/2023-06-02-preview/managedClusters.json#L7975:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'egressGateways' that was not found in the old version. New: aks/preview/2023-07-02-preview/managedClusters.json#L8241:7 Old: aks/preview/2023-07-02-preview/managedClusters.json#L8241:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-preview-2023-07	package-preview-2023-07(8d3b399)	package-preview-2023-07(main)
package-preview-2023-06	package-preview-2023-06(8d3b399)	package-preview-2023-06(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PrivateEndpointResourceSchemaValidation	The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: aks/preview/2023-06-02-preview/managedClusters.json#L2093
`❌` PrivateEndpointResourceSchemaValidation	The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: aks/preview/2023-07-02-preview/managedClusters.json#L2153
⚠️ PageableOperation	Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-06-02-preview/managedClusters.json#L116
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: aks/preview/2023-06-02-preview/managedClusters.json#L284
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-06-02-preview/managedClusters.json#L367
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-06-02-preview/managedClusters.json#L415
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-06-02-preview/managedClusters.json#L460
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-06-02-preview/managedClusters.json#L502
⚠️ RequiredReadOnlySystemData	The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-06-02-preview/managedClusters.json#L1079
⚠️ RequiredReadOnlySystemData	The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-06-02-preview/managedClusters.json#L1129
⚠️ PageableOperation	Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-06-02-preview/managedClusters.json#L1802
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-06-02-preview/managedClusters.json#L1845
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-06-02-preview/managedClusters.json#L1893
⚠️ PageableOperation	Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-06-02-preview/managedClusters.json#L2071
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: aks/preview/2023-06-02-preview/managedClusters.json#L2118
⚠️ PageableOperation	Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L116
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: aks/preview/2023-07-02-preview/managedClusters.json#L284
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L367
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L415
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L460
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L502
⚠️ RequiredReadOnlySystemData	The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1072
⚠️ RequiredReadOnlySystemData	The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1115
⚠️ RequiredReadOnlySystemData	The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1385
⚠️ PageableOperation	Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1869
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1912
⚠️ RequiredReadOnlySystemData	The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1960
⚠️ PageableOperation	Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L2131
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: aks/preview/2023-07-02-preview/managedClusters.json#L2178

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T05:26:57Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerservice [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ManagedClustersOperations.get_guardrails_versions
info	[Changelog]   - Added operation ManagedClustersOperations.get_mesh_revision_profile
info	[Changelog]   - Added operation ManagedClustersOperations.get_mesh_upgrade_profile
info	[Changelog]   - Added operation ManagedClustersOperations.list_guardrails_versions
info	[Changelog]   - Added operation ManagedClustersOperations.list_mesh_revision_profiles
info	[Changelog]   - Added operation ManagedClustersOperations.list_mesh_upgrade_profiles
info	[Changelog]   - Added operation group MachinesOperations
info	[Changelog]   - Model AgentPool has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model AgentPool has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model AgentPool has a new parameter message_of_the_day
info	[Changelog]   - Model AgentPool has a new parameter network_profile
info	[Changelog]   - Model AgentPool has a new parameter security_profile
info	[Changelog]   - Model AgentPool has a new parameter windows_profile
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter kube_proxy_config
info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter monitoring
info	[Changelog]   - Model IstioComponents has a new parameter egress_gateways
info	[Changelog]   - Model ManagedCluster has a new parameter creation_data
info	[Changelog]   - Model ManagedCluster has a new parameter enable_namespace_resources
info	[Changelog]   - Model ManagedCluster has a new parameter guardrails_profile
info	[Changelog]   - Model ManagedCluster has a new parameter ingress_profile
info	[Changelog]   - Model ManagedCluster has a new parameter metrics_profile
info	[Changelog]   - Model ManagedCluster has a new parameter node_resource_group_profile
info	[Changelog]   - Model ManagedCluster has a new parameter resource_uid
info	[Changelog]   - Model ManagedCluster has a new parameter service_mesh_profile
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter enable_vnet_integration
info	[Changelog]   - Model ManagedClusterAPIServerAccessProfile has a new parameter subnet_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfile has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter capacity_reservation_group_id
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter enable_custom_ca_trust
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter message_of_the_day
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter network_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter security_profile
info	[Changelog]   - Model ManagedClusterAgentPoolProfileProperties has a new parameter windows_profile
info	[Changelog]   - Model ManagedClusterAzureMonitorProfile has a new parameter logs
info	[Changelog]   - Model ManagedClusterAzureMonitorProfileMetrics has a new parameter app_monitoring_open_telemetry_metrics
info	[Changelog]   - Model ManagedClusterHTTPProxyConfig has a new parameter effective_no_proxy
info	[Changelog]   - Model ManagedClusterIngressProfileWebAppRouting has a new parameter dns_zone_resource_ids
info	[Changelog]   - Model ManagedClusterLoadBalancerProfile has a new parameter backend_pool_type
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter image_integrity
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter node_restriction
info	[Changelog]   - Model ManagedClusterStorageProfileDiskCSIDriver has a new parameter version
info	[Changelog]   - Operation AgentPoolsOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]   - Operation ManagedClustersOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ManagedClusterIngressProfileWebAppRouting no longer has parameter dns_zone_resource_id

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-containerservice [View full logs] [Release SDK Changes]
- azure-arm-containerservice-19.3.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.ContainerService [View full logs] [Release SDK Changes]
- Azure.ResourceManager.ContainerService.1.2.0-alpha.20230912.1.nupkg
```
info	[Changelog]
```

️❌ azure-resource-manager-schemas failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 250a8bb. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.1.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.

️✔️containerservice [View full logs]

️✔️containerservice [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		containerservice
error		containerservice

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 250a8bb. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerservice.DefaultTag [View full logs]

Az.ContainerService.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T05:26:58Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerservice/armcontainerservice	https://apiview.dev/Assemblies/Review/abcd4d42f913412dbacc288fe12140be
.Net	Azure.ResourceManager.ContainerService	There is no API change compared with the previous version
JavaScript	@azure/arm-containerservice	There is no API change compared with the previous version
Java	azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated	https://apiview.dev/Assemblies/Review/914197266a1947238b68e62f9faa9b60

openapi-workflow-bot · 2023-08-24T05:33:04Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

deveshdama · 2023-09-11T16:02:01Z

/pr RequestMerge

openapi-pipeline-app · 2023-09-12T19:00:48Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

egress gateway is part of IstioComponents definition

8d3b399

deveshdama requested review from palma21, weinong, alvinli222, matthchr and circy9 as code owners August 24, 2023 05:26

openapi-assignment-bot bot assigned rkmanda Aug 24, 2023

openapi-workflow-bot bot added ShiftLeftViolation DoNotMerge <valid label in PR review process> use to hold merge after approval labels Aug 24, 2023

azure-sdk mentioned this pull request Aug 24, 2023

[AutoPR sdk/resourcemanager/containerservice/armcontainerservice] egress gateway is part of IstioComponents definition azure-sdk/azure-sdk-for-go#7062

Closed

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 28, 2023

FumingZhang removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 29, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 29, 2023

github-actions bot added the MergeRequested label Aug 29, 2023

sjanamma removed the MergeRequested label Aug 30, 2023

mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 7, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 7, 2023

github-actions bot added the MergeRequested label Sep 11, 2023

rkmanda removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 12, 2023

rkmanda approved these changes Sep 12, 2023

View reviewed changes

rkmanda merged commit 250a8bb into main Sep 12, 2023
28 of 30 checks passed

rkmanda deleted the ddama/asm-egressgateways-fix branch September 12, 2023 19:00

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Sep 12, 2023

FumingZhang mentioned this pull request Sep 15, 2023

{AKS} Refresh vendored SDK Azure/azure-cli-extensions#6767

Merged

3 tasks

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

egress gateway is part of IstioComponents definition (#25494)

b8fcae5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

egress gateway is part of IstioComponents definition #25494

egress gateway is part of IstioComponents definition #25494

deveshdama commented Aug 24, 2023

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2023

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2023

deveshdama commented Sep 11, 2023

openapi-pipeline-app bot commented Sep 12, 2023

egress gateway is part of IstioComponents definition #25494

egress gateway is part of IstioComponents definition #25494

Conversation

deveshdama commented Aug 24, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Next Steps to Merge

openapi-workflow-bot bot commented Aug 24, 2023

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Aug 24, 2023

deveshdama commented Sep 11, 2023

openapi-pipeline-app bot commented Sep 12, 2023

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading