Update trusted access put and delete to async operation #25537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norshtein
requested review from
palma21,
weinong,
alvinli222,
matthchr and
circy9
as code owners
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| managedClusters.json | 2023-08-02-preview(1b3c9bb) | 2023-07-01(main) |
| managedClusters.json | 2023-08-02-preview(1b3c9bb) | 2023-07-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-08 | package-preview-2023-08(1b3c9bb) | package-preview-2023-08(FumingZhang-containerservice-Microsoft.ContainerService-2023-08-02-preview) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: aks/preview/2023-08-02-preview/managedClusters.json#L2153 |
| Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-08-02-preview/managedClusters.json#L116 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: aks/preview/2023-08-02-preview/managedClusters.json#L284 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-08-02-preview/managedClusters.json#L367 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-08-02-preview/managedClusters.json#L415 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-08-02-preview/managedClusters.json#L460 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-08-02-preview/managedClusters.json#L502 |
|
| The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1072 |
|
| The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1115 |
|
| The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1385 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1869 |
|
| The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1912 |
|
| The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-08-02-preview/managedClusters.json#L1960 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-08-02-preview/managedClusters.json#L2131 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: aks/preview/2023-08-02-preview/managedClusters.json#L2178 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
This was referenced Aug 25, 2023
FumingZhang
merged commit 7cdd607
into
Azure:FumingZhang-containerservice-Microsoft.ContainerService-2023-08-02-preview
22 of 27 checks passed
FumingZhang
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Update trusted access put and delete to async operation * Update example * Update header
6 tasks
raosuhas
pushed a commit
that referenced
this pull request
Sep 28, 2023
…add version preview/2023-08-02-preview (#25891) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview * Updates readme * Updates API version in new specs and examples * update (#25469) * Fix the IstioComponents structure (#25492) * add netorkPolicy "none" (#25511) * add netorkPolicy "none" value and description * add "none" enum value to networkPolicy * add addon autoscaling api (#25479) * Update trusted access put and delete to async operation (#25537) * Update trusted access put and delete to async operation * Update example * Update header * Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (#25487) * Adding json changes * adding "daemonsets" to the custom-words * Editing "Expander" to "expander" * Removing daemonset custom word from this pr. look at: #25533 * Add AzureServiceMesh example (#25560) * Add AzureServiceMesh example * Fix AKV resource id format * enrich ASM examples (#25598) --------- Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com> Co-authored-by: robogatikov <132703210+robogatikov@users.noreply.github.com> Co-authored-by: Chih-Sheng Huang <pedoe1989@gmail.com> Co-authored-by: Tongyao Si <tosi@microsoft.com> Co-authored-by: Youn Jae Kim <younjaekim@microsoft.com>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…add version preview/2023-08-02-preview (#25891) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview * Updates readme * Updates API version in new specs and examples * update (#25469) * Fix the IstioComponents structure (#25492) * add netorkPolicy "none" (#25511) * add netorkPolicy "none" value and description * add "none" enum value to networkPolicy * add addon autoscaling api (#25479) * Update trusted access put and delete to async operation (#25537) * Update trusted access put and delete to async operation * Update example * Update header * Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (#25487) * Adding json changes * adding "daemonsets" to the custom-words * Editing "Expander" to "expander" * Removing daemonset custom word from this pr. look at: #25533 * Add AzureServiceMesh example (#25560) * Add AzureServiceMesh example * Fix AKV resource id format * enrich ASM examples (#25598) --------- Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com> Co-authored-by: robogatikov <132703210+robogatikov@users.noreply.github.com> Co-authored-by: Chih-Sheng Huang <pedoe1989@gmail.com> Co-authored-by: Tongyao Si <tosi@microsoft.com> Co-authored-by: Youn Jae Kim <younjaekim@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.