[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25751

sumitparwal · 2023-09-11T21:39:28Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- This is the api version which is not public to customer yet and we are updating it simultaneously with code/testing changes.
- We had to add additional properties to one of our api and hence the change required, we got the breaking changes approval already

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-11T21:39:31Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-11T21:39:32Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
consumption.json	2023-11-01(a2a20cf)	2023-11-01(main)

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'orgType' renamed or removed? New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5310:7 Old: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5294:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'billingAccountId' in response that was not found in the old version. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5127:7 Old: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5121:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'billingAccountDisplayName' in response that was not found in the old version. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5127:7 Old: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5121:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'OrganizationType' in response that was not found in the old version. New: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5310:7 Old: Microsoft.Consumption/stable/2023-11-01/consumption.json#L5294:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-11	package-2023-11(a2a20cf)	package-2023-11(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L155
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L252
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.Consumption/budgets/{budgetName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Consumption/budgets' that has the scope parameter.'. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L267
`❌` ResourceNameRestriction	The resource name parameter 'budgetName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L309
`❌` DeleteResponseCodes	Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L405
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L430
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L469
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L473
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L577
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L616
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L629
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L658
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1109
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1113
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1181
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1185
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` ParametersInPointGet	Query parameter $skiptoken should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` ParametersInPointGet	Query parameter $top should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1319
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1367
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` ParametersInPointGet	Query parameter $skiptoken should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` ParametersInPointGet	Query parameter $top should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1385
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1456
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1457
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1508
`❌` ResourceNameRestriction	The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1521
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1550
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1875
`❌` MissingTypeObject	The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Consumption/stable/2023-11-01/consumption.json#L1889

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-11T21:39:32Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Consumption [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/consumption/armconsumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
info	[Changelog] - Field `Etag`, `Tags` of struct `CreditSummary` has been removed
info	[Changelog] - Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EventTypeCreditExpired` added to enum type `EventType`
info	[Changelog] - New enum type `OperationStatusType` with values `OperationStatusTypeCompleted`, `OperationStatusTypeFailed`, `OperationStatusTypeRunning`
info	[Changelog] - New enum type `OrganizationType` with values `OrganizationTypeContributorOrganizationType`, `OrganizationTypePrimaryOrganizationType`
info	[Changelog] - New function `*ModernReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSharedScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*ModernSingleScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingAccountPeriod(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingAccountPeriodOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingAccountPeriodResponse], error)`
info	[Changelog] - New struct `ModernSharedScopeReservationRecommendationProperties`
info	[Changelog] - New struct `ModernSingleScopeReservationRecommendationProperties`
info	[Changelog] - New struct `OperationStatus`
info	[Changelog] - New struct `PricesheetDownloadProperties`
info	[Changelog] - New struct `SavingsPlan`
info	[Changelog] - New field `OverageRefund` in struct `BalanceProperties`
info	[Changelog] - New field `ETag` in struct `CreditSummary`
info	[Changelog] - New field `IsEstimatedBalance` in struct `CreditSummaryProperties`
info	[Changelog] - New field `BillingAccountDisplayName`, `BillingAccountID`, `IsEstimatedBalance` in struct `EventProperties`
info	[Changelog] - New field `AzureMarketplaceCharges` in struct `LegacyChargeSummaryProperties`
info	[Changelog] - New field `IsEstimatedBalance`, `OrganizationType`, `UsedAmount` in struct `LotProperties`
info	[Changelog] - New field `SubscriptionID` in struct `ModernChargeSummaryProperties`
info	[Changelog] - New field `SavingsPlan` in struct `PriceSheetProperties`
info	[Changelog] - New field `Filter` in struct `ReservationRecommendationDetailsClientGetOptions`
info	[Changelog] - New field `PreviewMarkupPercentage`, `UseMarkupIfPartner` in struct `ReservationTransactionsClientListOptions`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 33 additive change(s).

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Code Generator Failed [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]   - properties.error.$ref: "#/components/schemas/schemas:468" => "#/components/schemas/schemas:679"
cmdout	[automation_generate.sh] [Autorest]   - title: <none> => "Error response"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]   - properties.error.$ref: "#/components/schemas/schemas:468" => "#/components/schemas/schemas:679"
cmdout	[automation_generate.sh] [Autorest]   - title: <none> => "Error response"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/PropertyRedeclarationWarning | Schema 'LegacyReservationTransaction' has a property 'properties' that is already declared the parent schema 'ReservationTransaction' but isn't significantly different. The property has been removed from LegacyReservationTransaction
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-consumption-10.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation LotsOperations.listByCustomer
info	[Changelog]   - Added operation PriceSheet.beginDownloadByBillingAccountPeriod
info	[Changelog]   - Added operation PriceSheet.beginDownloadByBillingAccountPeriodAndWait
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
info	[Changelog]   - Added Interface LotsListByCustomerNextOptionalParams
info	[Changelog]   - Added Interface LotsListByCustomerOptionalParams
info	[Changelog]   - Added Interface ModernReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSharedScopeReservationRecommendationProperties
info	[Changelog]   - Added Interface ModernSingleScopeReservationRecommendationProperties
info	[Changelog]   - Added Interface OperationStatus
info	[Changelog]   - Added Interface PriceSheetDownloadByBillingAccountPeriodHeaders
info	[Changelog]   - Added Interface PriceSheetDownloadByBillingAccountPeriodOptionalParams
info	[Changelog]   - Added Interface SavingsPlan
info	[Changelog]   - Added Type Alias LotsListByCustomerNextResponse
info	[Changelog]   - Added Type Alias LotsListByCustomerResponse
info	[Changelog]   - Added Type Alias ModernReservationRecommendationPropertiesUnion
info	[Changelog]   - Added Type Alias OperationStatusType
info	[Changelog]   - Added Type Alias OrganizationType
info	[Changelog]   - Added Type Alias PriceSheetDownloadByBillingAccountPeriodResponse
info	[Changelog]   - Interface Balance has a new optional parameter overageRefund
info	[Changelog]   - Interface CreditSummary has a new optional parameter eTagPropertiesETag
info	[Changelog]   - Interface CreditSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface EventSummary has a new optional parameter billingAccountDisplayName
info	[Changelog]   - Interface EventSummary has a new optional parameter billingAccountId
info	[Changelog]   - Interface EventSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface LegacyChargeSummary has a new optional parameter azureMarketplaceCharges
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitId
info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitName
info	[Changelog]   - Interface LotSummary has a new optional parameter isEstimatedBalance
info	[Changelog]   - Interface LotSummary has a new optional parameter organizationType
info	[Changelog]   - Interface LotSummary has a new optional parameter usedAmount
info	[Changelog]   - Interface ModernChargeSummary has a new optional parameter subscriptionId
info	[Changelog]   - Interface ModernReservationRecommendation has a new optional parameter resourceType
info	[Changelog]   - Interface PriceSheetProperties has a new optional parameter savingsPlan
info	[Changelog]   - Interface ReservationRecommendationDetailsGetOptionalParams has a new optional parameter filter
info	[Changelog]   - Interface ReservationTransactionsListOptionalParams has a new optional parameter previewMarkupPercentage
info	[Changelog]   - Interface ReservationTransactionsListOptionalParams has a new optional parameter useMarkupIfPartner
info	[Changelog]   - Added Enum KnownOperationStatusType
info	[Changelog]   - Added Enum KnownOrganizationType
info	[Changelog]   - Enum KnownEventType has a new value CreditExpired
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation ReservationRecommendationDetails.get has a new signature
info	[Changelog]   - Class ConsumptionManagementClient has a new signature
info	[Changelog]   - Interface BudgetFilter no longer has parameter not
info	[Changelog]   - Interface LegacyChargeSummary no longer has parameter marketplaceCharges
info	[Changelog]   - Parameter scope of interface ModernReservationRecommendation is now required

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 64337ca. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.0` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️consumption [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 64337ca. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.consumption.DefaultTag [View full logs]

Az.Consumption.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.consumption.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-11T21:39:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/consumption/armconsumption	https://apiview.dev/Assemblies/Review/80e88bf45ded49039d35a1a6fbe7ac24
Java	azure-resourcemanager-consumption	https://apiview.dev/Assemblies/Review/ab29a8af64d84123992b8e939f7ed345
JavaScript	@azure/arm-consumption	https://apiview.dev/Assemblies/Review/48c07f1dadf54c31aa2821fdf6c79341

openapi-workflow-bot · 2023-09-11T21:45:15Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

thramu · 2023-10-05T18:03:10Z

/pr RequestMerge

ms-zhenhua · 2023-10-09T00:59:31Z

please fix Automated merging requirements met, then run /pr RequestMerge to request merge.

raych1 · 2023-10-09T08:00:05Z

/azp run

azure-pipelines · 2023-10-09T08:00:47Z

Azure Pipelines successfully started running 3 pipeline(s).

sumitparwal · 2023-10-09T16:43:28Z

/pr RequestMerge

ms-zhenhua · 2023-10-10T00:03:07Z

/azp run

azure-pipelines · 2023-10-10T00:03:31Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-pipeline-app · 2023-10-10T00:15:03Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…on stable/2023-11-01 (#25751) * updated documents to update api contract * updated billingaccountname * updated billingAccountName to billingAccountDisplayName based on code pr * Update EventsGetByBillingAccount.json * Update EventsGetByBillingAccountWithFilters.json * updated based on request from PM Team

updated documents to update api contract

2111646

sumitparwal requested a review from kjeur as a code owner September 11, 2023 21:39

openapi-assignment-bot bot assigned rkmanda Sep 11, 2023

sumitparwal added 2 commits September 12, 2023 10:50

updated billingaccountname

80e3bea

updated billingAccountName to billingAccountDisplayName based on code pr

f2941e2

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 18, 2023

sumitparwal and others added 3 commits September 25, 2023 16:01

Update EventsGetByBillingAccount.json

8ce6325

Update EventsGetByBillingAccountWithFilters.json

034151a

updated based on request from PM Team

a2a20cf

sumitparwal requested a review from thramu September 27, 2023 21:04

thramu approved these changes Sep 27, 2023

View reviewed changes

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed NewApiVersionRequired labels Sep 27, 2023

thramu removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 4, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 4, 2023

sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 5, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 5, 2023

github-actions bot added the MergeRequested label Oct 5, 2023

sumitparwal removed the request for review from kjeur October 6, 2023 19:22

ms-zhenhua removed the MergeRequested label Oct 9, 2023

github-actions bot added the MergeRequested label Oct 9, 2023

ms-zhenhua merged commit 64337ca into main Oct 10, 2023
27 of 31 checks passed

ms-zhenhua deleted the sumitparwal-consumption-Microsoft.Consumption-2023-11-01-update-new branch October 10, 2023 00:15

azure-sdk mentioned this pull request Oct 10, 2023

[ReleasePR sdk/resourcemanager/consumption/armconsumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 Azure/azure-sdk-for-go#19340

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 10, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Oct 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25751

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25751

sumitparwal commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 11, 2023

thramu commented Oct 5, 2023

ms-zhenhua commented Oct 9, 2023

raych1 commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

sumitparwal commented Oct 9, 2023

ms-zhenhua commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

openapi-pipeline-app bot commented Oct 10, 2023

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25751

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-11-01 #25751

Conversation

sumitparwal commented Sep 11, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 11, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 11, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 11, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 11, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 11, 2023

thramu commented Oct 5, 2023

ms-zhenhua commented Oct 9, 2023

raych1 commented Oct 9, 2023

azure-pipelines bot commented Oct 9, 2023

sumitparwal commented Oct 9, 2023

ms-zhenhua commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

openapi-pipeline-app bot commented Oct 10, 2023

sumitparwal commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2023 •

edited

Loading