Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] 2024-02-02-preview resolve conflicts #27767

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
161 commits
Select commit Hold shift + click to select a range
ebce1c6
Adding New GA Version (#26953)
allegradomel Jan 10, 2024
f6dba71
[TypeSpec Requirement] Handle specs with variable path depths (#27324)
mikeharder Jan 10, 2024
2f74f79
[TypeSpec-Requirement] Fix typo in github URL to check
mikeharder Jan 10, 2024
ee05b00
Update readme.python.md (#27330)
ChenxiJiang333 Jan 10, 2024
f2d0e78
Use property name `list` instead of `values` in some models for Pytho…
dargilco Jan 10, 2024
afd7752
Johnkoh msft azuredatatransfer microsoft.azure data transfer 2023 10 …
johnkoh-msft Jan 10, 2024
ca6cb35
Minor Fixes of TypeSpec for AOAI On Your Data 2023-12-01-preview /ext…
wangyuantao Jan 10, 2024
957fd51
Update SparkFrontend_SparkBatch_Create.json (#27077)
kevinjaku Jan 10, 2024
7510297
[TypeSpec Validation] add support for node 21 and drop 16 (#27247)
ckairen Jan 11, 2024
685aad3
tsv path error message (#27248)
ckairen Jan 11, 2024
739c3a5
Correct the version # in the primary tag in the readme (Azure Maps) (…
stevemunk Jan 11, 2024
eb06c34
[TypeSpec Validation] remove job name for pipelines (#27338)
ckairen Jan 11, 2024
ea28180
Update readme.python.md (#27344)
ChenxiJiang333 Jan 11, 2024
07fd0ee
Updated examples for public documentation (#27273)
sushil490023 Jan 11, 2024
e8fe420
Azure Language add scriptCode, and enums for script Language Detectio…
quentinRobinson Jan 11, 2024
bcc8715
Fix broken links in Creator (#27343)
stevemunk Jan 11, 2024
84e597d
[ImageAnalysis] Fix auth implementation (#27361)
catalinaperalta Jan 12, 2024
0988452
Update readme.python.md (#27365)
msyyc Jan 12, 2024
1285ef6
Update readme.python.md (#27366)
msyyc Jan 12, 2024
35801d7
References to the data service are changed to reference the data regi…
stevemunk Jan 12, 2024
e79c2de
Abaranwal ms edgeorder microsoft.edge order 2024 02 01 (#27145)
abaranwal-ms Jan 12, 2024
eddb30e
remove the save-inputs in jobrouters (#27371)
ArcturusZhang Jan 15, 2024
571a9b7
Update readme.python.md (#27374)
ChenxiJiang333 Jan 16, 2024
05c4049
Add snowflake v2 linkedService (#26336)
ruowan Jan 16, 2024
cbc53d2
Minor fix the missing parameters for ingestion API (#27364)
wangyuantao Jan 16, 2024
e3b6f57
Azure Maps - Data service documentation updates to improve the overvi…
stevemunk Jan 16, 2024
22abc86
Fix broken links in user docs (description fields) (#27149)
stevemunk Jan 16, 2024
8b5aae7
[TypeSpec Requirement] Improve check if OpenAPI cannot be parsed as J…
mikeharder Jan 17, 2024
fa40a42
Update readme.python.md (#27411)
msyyc Jan 17, 2024
97cefc8
Fix headers and schema definition (#27180)
wangbwn Jan 17, 2024
ebf29a8
[Hub Generated] Review request for Microsoft.ContainerService/aks to …
FumingZhang Jan 17, 2024
2ce7ebe
update duration properties with "x-ms-format" : "duration-constant" (…
mwesigwaguma Jan 17, 2024
12d43d5
Documentation fixes for a preview API (#27350)
mahakjain314 Jan 17, 2024
5ce4234
[Hub Generated] Publish private branch 'feature/DP-workspace-key' (#2…
04diiguyi Jan 17, 2024
e69839a
[DocumentIntelligence] Update tsp config for Python (#27423)
YalinLi0312 Jan 17, 2024
baebc8d
[ChangedFiles-Functions.ps1] Remove unnecessary parenthesis in functi…
mikeharder Jan 18, 2024
8b5618d
[Hub Generated] Publish private branch 'feature/RP-workspace-key' (#2…
xinyi-joffre Jan 18, 2024
922913c
Fixed link text for 'pricing tiers' in Azure Maps swagger files. (#27…
stevemunk Jan 18, 2024
c3a9177
Update ARM review guidance in control_plane_template.md (#27406)
Jan 18, 2024
27bae6b
Update pull_request_assignment.yml: remove rkmanda from assignees (#2…
Jan 18, 2024
e280525
Remove spatial (#27209)
stevemunk Jan 19, 2024
0e456cb
Update readme.python.md (#27454)
msyyc Jan 19, 2024
3c237ab
Update description of Custom Voice API swagger. (#27438)
ForrestGumb Jan 19, 2024
8df53db
Added optional deliveryReportTimeoutInSeconds to smsSendOptions. (#27…
besh2014 Jan 19, 2024
e8c4e08
Fix broken links for Azure Maps API resulting from TOC changes. (#27443)
stevemunk Jan 19, 2024
0a29f97
[Hub Generated] Publish private branch 'gachauhan-iprangenew' (#27329)
gachauhan Jan 19, 2024
5386fbb
Remove "Swagger" from the PR template (#27466)
Jan 20, 2024
09e36d3
disable model flatten for new service (#27380)
msyyc Jan 22, 2024
ce47f9b
[Hub Generated] Review request for Microsoft.HealthcareApis to add ve…
namalu Jan 22, 2024
a0151af
Search preview version 2024-03-01-preview (#27235)
sazeesha098 Jan 22, 2024
aac5483
Various improvements to `ci-fix.md` (#27484)
Jan 22, 2024
51a6e41
to support SDK auto generation (#27464)
04diiguyi Jan 23, 2024
f9f1a6a
Improve Salesforce V2 properties (#27412)
wenqibu Jan 23, 2024
47fa9d7
Route v2 toc (#27500)
stevemunk Jan 23, 2024
2b305df
Creator api summary (#27357)
stevemunk Jan 23, 2024
ade1f3c
Add simple script to create new API versions (#27266)
heaths Jan 23, 2024
cf49581
[tsconfig.json] Revert accidental changes (#27489)
mikeharder Jan 24, 2024
21a8d55
java, offazurespringboot, update title use singlar App (#27494)
weidongxu-microsoft Jan 24, 2024
41dff4b
Rheajain paloaltonetworks palo alto networks.cloudngfw 2024 01 19 pre…
rheajain Jan 24, 2024
ac56165
Update Custom Voice API swagger. (#27512)
ForrestGumb Jan 24, 2024
7452e1c
Release keyvault microsoft.key vault 7.5 (#27422)
jlichwa Jan 24, 2024
c75671a
Adding 2023 09 01 for nginx (#27231)
zaowang-ms Jan 24, 2024
23f6597
Update readme.python.md (#27520)
ChenxiJiang333 Jan 25, 2024
08d85e4
disable model flatten (#27511)
ChenxiJiang333 Jan 25, 2024
4307895
Adding new preview api version for new field (#27382)
GovardhanaDK Jan 25, 2024
18b5c82
hardwaresecuritymodules readme.go.md add directive (#27525)
Alancere Jan 25, 2024
3cf7400
Naming tweaks for ImageAnalysis (#27296)
rhurey Jan 25, 2024
e84621b
Update Route Directions API (#27492)
koyasu221b Jan 25, 2024
65e9fe8
Added comment 'Maximum number of categorySet values supported per req…
stevemunk Jan 25, 2024
8fc3dd4
Alec baird desktopvirtualization microsoft.desktop virtualization 202…
alec-baird Jan 25, 2024
99e8394
Remove issue and pull request assignment files (#27481)
Jan 26, 2024
6f8faf5
turn the MRW feature off explicitly for communication jobrouter (#27539)
ArcturusZhang Jan 26, 2024
581bcb0
[TypeSpec] Upgrade to 0.52.0 (#27541)
mikeharder Jan 26, 2024
8829910
[docs] Add to "Swagger LintDiff for TypeSpec" (#27451)
mikeharder Jan 26, 2024
5edeefc
Cognitive Services 2023-10-01-preview update (#26892)
tianxin-ms Jan 26, 2024
b09da5a
[TypeSpec] Upgrade http to 0.52.1 (#27548)
mikeharder Jan 27, 2024
f5cd5df
System component added as azure arc profile. (#27519)
kulalking Jan 27, 2024
014f813
Fixed invalid type errors in bbox examples (#27516)
stevemunk Jan 28, 2024
86a89f2
enable mrw for jobrouter again (#27543)
ArcturusZhang Jan 29, 2024
f145d51
making product description optional in new API version (#27534)
allegradomel Jan 29, 2024
0fb6b39
[OpenAI] Fix ChatCompletionsNamedFunctionToolSelection (#27487)
deyaaeldeen Jan 29, 2024
2232e42
[TypeSpec] Upgrade typespec-apiview to 0.4.5 (#27562)
mikeharder Jan 29, 2024
c26e839
Add Token authentication for Single document translator API (#27546)
vikaspalaskar Jan 29, 2024
f9bf9d4
add stable API 2024-02-01 for GA (#27360)
jylama-99 Jan 29, 2024
3337c7c
remove placeholder file (#27569)
catalinaperalta Jan 30, 2024
10af943
[TypeSpec] Upgrade autorest to 0.38.1 (#27568)
timotheeguerin Jan 30, 2024
0c2e0ff
update readme to adapt new autorest (#27571)
04diiguyi Jan 30, 2024
58dfeeb
OpenAI: TypeSpec project for Assistants (#27076)
trrwilson Jan 30, 2024
4e8f3ed
Add new events for Storage - StorageTasks (#26887)
shulinwang33 Jan 30, 2024
84d63ea
Update ci-fix.md: mention Teams channel for help with TypeSpec (#27588)
Jan 31, 2024
17c165f
Add API version 2023-10-01-preview [Import] (#27385)
pracagrawal Jan 31, 2024
1fc2f86
Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 …
mjmadhu Jan 31, 2024
f3cd692
HDInsight: onboard new apiversion 2023-11-01-preview (#27306)
dw511214992 Jan 31, 2024
3efb341
[Azure AI - Health Insights] - Typespec revision for Health Insights …
asaflevi-ms Jan 31, 2024
68030f1
[ci-fix.md] Add known issues to "Swagger LintDiff for TypeSpec" (#27573)
mikeharder Jan 31, 2024
dfd7afd
Adding new version 2024-01-01-preview for updating monitor Properties…
apoorvasingh130 Feb 1, 2024
eca452e
[Hub Generated] Review request for Microsoft.ContainerService/aks to …
FumingZhang Feb 1, 2024
6a5d5f0
Add AppPlatform 2024-01-01-preview (#27113)
saragluna Feb 1, 2024
b422f17
Azure Deployment Manager is being decommissioned. Deleting the Rest A…
rohantagaru Feb 1, 2024
784dcbc
updating preview tag (#27555)
mwesigwaguma Feb 1, 2024
73d1e65
Patch Common-Types/Private Links V6 with Pageable Options (#27620)
tshaiman Feb 2, 2024
559f989
Adding new stable version "2024-01-01" (#27627)
vipray-ms Feb 2, 2024
18493ce
first commit (#27598)
koyasu221b Feb 2, 2024
c307cc0
Update comment.yml: get rid of CI-MissingBaseCommit (#27622)
Feb 2, 2024
4be63be
OpenAI Assistants: fix required_action function representation (#27638)
trrwilson Feb 3, 2024
0d93026
add round trip rules (#27623)
ms-zhenhua Feb 3, 2024
86bf8dd
Mobile packet core service (#27517)
mgl1969 Feb 3, 2024
45f5b5a
Xuhumsft securityinsights microsoft.security insights 2023 12 01 prev…
xuhumsft Feb 3, 2024
79e4e0c
healthinsights, fix tspconfig on java emitter options (#27646)
weidongxu-microsoft Feb 4, 2024
a1d3891
[astro] disable flatten (#27649)
msyyc Feb 5, 2024
a9b45c2
[Hub Generated] Review request for Microsoft.Migrate/AssessmentProjec…
kushalmehrotra713 Feb 5, 2024
abb30bf
Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 …
mjmadhu Feb 5, 2024
4948660
Update python readme (#27504)
04diiguyi Feb 5, 2024
b72d96e
fix Nsp link properties description (#27601)
vineetmimrot Feb 5, 2024
f984ae5
Introducing service group for orbital (aogs and aodg) (#27582)
kkashojjula-msft Feb 6, 2024
1884557
TypeSpec conversion for Purview Policy (#26460)
allenjzhang Feb 6, 2024
8bf9ff0
Update readme.md for SDK generation (#27664)
msyyc Feb 6, 2024
7e9e559
disable model flatten for service Azure Large Instance&HDInsight Cont…
ChenxiJiang333 Feb 6, 2024
fe09fb3
[Hub Generated] Review request for Microsoft.RecoveryServices to add …
rthapliyal-msft Feb 6, 2024
9f44876
TSP Conversion for Microsoft.ApiCenter (#27618)
markcowl Feb 6, 2024
5e060c7
[EventGrid] Microsoft.AVS/privateClouds events (#24015)
et1975 Feb 6, 2024
ceb1849
update typescript.md (#27679)
kazrael2119 Feb 7, 2024
ddbc747
Adding E5 SKU to stable branch for GA release (#27656)
revanthballa1188 Feb 7, 2024
46e9f31
update events with metadata (#27137)
osaghaso Feb 7, 2024
9381354
Feature/datamap tsp (#26702)
yifan-zhou922 Feb 7, 2024
9097c69
Resolving 2023-05-01 swagger validation errors for Azure Firewall exa…
ajtms Feb 7, 2024
ef87932
Bug fix: Remove maxLeng on ScopeParameter (#27616)
allenjzhang Feb 7, 2024
bd36f7f
Add issue templates for question, bug, and feature request (#27610)
ronniegeraghty Feb 7, 2024
459ae6c
Update clusterservice.tsp (#27684)
mgl1969 Feb 7, 2024
5464501
[TypeSpec] Upgrade to 0.53.0 (#27677)
mikeharder Feb 7, 2024
d25b0ec
Add clarity to Search v1 API regarding `municipality` vs. `localName`…
stevemunk Feb 7, 2024
c7b50ca
[TypeSpec Validation] Fail fast if "npm install" fails (#27678)
mikeharder Feb 7, 2024
39608b2
Mvvsubbu databricks microsoft.databricks 2024 02 01 preview (#27607)
mvvsubbu Feb 8, 2024
a4d405d
paloaltonetworks - Add Strata Cloud Manager APIs (#27681)
rheajain Feb 8, 2024
3c53209
add directive to match parameter name (#27693)
kazrael2119 Feb 8, 2024
4baf37a
Add api version 2024-02-15-preview of Azure OpenAI (#27669)
bexxx Feb 8, 2024
f715b7f
Compute GalleryRP release 2023-07-03 (#27518)
Sandido Feb 8, 2024
3a5d590
[TypeSpec] Bump compiler, openapi3 and autorest version with union ho…
timotheeguerin Feb 8, 2024
a342331
Adding new api version 2024-01-01-preview (#27419)
utkarshjain1508 Feb 9, 2024
ecc0170
Added customizations for pagination models (#27683)
jpalvarezl Feb 9, 2024
6ce71c0
Fix incorrect tag name in comment. (#27741)
weshaggard Feb 12, 2024
6e12137
Update package.json (#27747)
timotheeguerin Feb 12, 2024
851d073
Replace `@projectedName("json"` -> `@encodedName("application/json"` …
timotheeguerin Feb 12, 2024
82417c7
Release machinelearningservices microsoft.machine learning services 2…
kseager Feb 12, 2024
0c885c1
added fttraidlevel in avssummary (#27686)
abhi580 Feb 12, 2024
7488ab7
Add Azure Programmable Connectivity dataplane APIs (#26922)
AndrewNivenMSFT Feb 13, 2024
455319f
Corrected the "Pricing Tiers" link text (#27752)
stevemunk Feb 13, 2024
1bf6c86
Convert ARM TSP from enum to union (#27749)
lmazuel Feb 13, 2024
fff4b6f
Mark MOE API Contract MaxQueueWait as deprecated (#27688)
Mutilar Feb 13, 2024
79832b6
Adds base for updating Microsoft.ContainerService/fleet from version …
zman-ms Jan 10, 2024
361ce1f
Updates readme
zman-ms Jan 10, 2024
450fe13
Updates API version in new specs and examples
zman-ms Jan 10, 2024
bc29a43
[Fleet] UpdateRun manual skip (#27323)
zman-ms Jan 18, 2024
092c945
[Fleet][UpdateRun] Rename skip target (#27449)
zman-ms Jan 19, 2024
c30fba6
[Fleet] 2024-02-02-preview Readme files (#27499)
zman-ms Jan 30, 2024
409827a
fix the final-state-via options for LRO (#27574)
serbrech Jan 30, 2024
409c7ee
Add ControlPlaneOnly enum to ManagedClusterUpgradeSpec (#27491)
frantran Feb 5, 2024
eb6738e
sync to async (#27745)
zman-ms Feb 12, 2024
4d6cc75
[Fleet] 2024-02-02-preview compile with latest compiler (#27750)
zman-ms Feb 12, 2024
d9f3465
Merge branch 'dev-aks-fleet-2024-02-02-preview' into zman/2024-02-02-…
zman-ms Feb 13, 2024
52aa4b1
resolve conflicts
zman-ms Feb 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
46 changes: 46 additions & 0 deletions .github/ISSUE_TEMPLATE/01_question.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Question/Query
description: Use this template to file a question/query for the API Spec team that are not bugs or feature requests.
title: "[Question]"

labels:
- question

body:
- type: input
id: api_spec
attributes:
label: API Spec link
description: "Link to the OpenAPI or TypeSpec spec"
placeholder: "e.g. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerservice/Fleet.Management/main.tsp"
validations:
required: true

- type: input
id: version
attributes:
label: API Spec version
description: "Version of the API Spec"
placeholder: "e.g. 2023-10-15"
validations:
required: true

- type: textarea
id: background
attributes:
label: Question/Query
description: How can we help?
placeholder: Description
validations:
required: true

- type: textarea
id: environment
attributes:
label: Environment
description: |
Please provide more information on your environment:
* Hosting platform or OS and .NET runtime version (`dotnet --info` output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
* IDE and version: [e.g. Visual Studio 16.3]
placeholder: Environment
validations:
required: false
76 changes: 76 additions & 0 deletions .github/ISSUE_TEMPLATE/02_bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
name: Bug report
description: Use this template to file a bug on an API Spec.
title: "[BUG]"

labels:
- bug

body:
- type: input
id: api_spec
attributes:
label: API Spec link
description: "Link to the OpenAPI or TypeSpec spec"
placeholder: "e.g. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerservice/Fleet.Management/main.tsp"
validations:
required: true

- type: input
id: version
attributes:
label: API Spec version
description: "Version of the API Spec"
placeholder: "e.g. 2023-10-15"
validations:
required: true

- type: textarea
id: background
attributes:
label: Describe the bug
description: Please provide the description of issue you're seeing.
placeholder: Description
validations:
required: true

- type: textarea
id: expected-behavior
attributes:
label: Expected behavior
description: |
Provide a description of the expected behavior.
placeholder: Expected behavior
validations:
required: true

- type: textarea
id: actual-behavior
attributes:
label: Actual behavior
description: |
Provide a description of the actual behavior observed. If applicable please include any error messages, exception stacktraces or memory dumps.
placeholder: Actual behavior
validations:
required: true

- type: textarea
id: repro-steps
attributes:
label: Reproduction Steps
description: |
Please include minimal steps to reproduce the problem if possible. E.g.: the smallest possible code snippet; or a small project, with steps to run it. If possible include text as text rather than screenshots (so it shows up in searches).
placeholder: Minimal Reproduction
validations:
required: true

- type: textarea
id: environment
attributes:
label: Environment
description: |
Please provide more information on your environment:
* Hosting platform or OS and .NET runtime version (`dotnet --info` output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
* IDE and version : [e.g. Visual Studio 16.3]
placeholder: Environment
validations:
required: false
34 changes: 34 additions & 0 deletions .github/ISSUE_TEMPLATE/03_feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Feature request
description: Use this template to file a feature request on an API Spec.
title: "[FEATURE REQ]"

labels:
- feature-request

body:
- type: input
id: api_spec
attributes:
label: API Spec link
description: "Link to the OpenAPI or TypeSpec spec"
placeholder: "e.g. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerservice/Fleet.Management/main.tsp"
validations:
required: true

- type: input
id: version
attributes:
label: API Spec version
description: "Version of the API Spec"
placeholder: "e.g. 2023-10-15"
validations:
required: true

- type: textarea
id: background
attributes:
label: Please describe the feature.
description: What feature would you like to get added? What problem is it solving?
placeholder: Feature description
validations:
required: true
35 changes: 17 additions & 18 deletions .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# ARM (Control Plane) API Specification Update Pull Request

> Tip: overwhelmed by all this guidance? See the `Getting help` section at the bottom of this PR description.
> [!TIP]
> Overwhelmed by all this guidance? See the `Getting help` section at the bottom of this PR description.

> [!NOTE]
> As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

## PR review workflow diagram

Expand All @@ -27,9 +31,7 @@ If the automation determines you have breaking changes, i.e. Step 1 from the dia

### ARM API changes review (Diagram Step 2)

- If this PR is in purview of ARM review then automation will add the `ARMReview` label.
- If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

</details>

Expand All @@ -38,23 +40,20 @@ If the automation determines you have breaking changes, i.e. Step 1 from the dia

### Diagram footnotes

[1] [ARM review queue] (for **merge** queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label `ARMChangesRequested`
is removed from your PR. This should cause the label `WaitForARMFeedback` to be added.
[2] [public repo merge queue], [private repo merge queue] (for **ARM review** queue, [1])

If you need further help with anything, see `Getting help` section below.
[1] See [ARM review queue] (for **PR merge** queues, see [2]).
[2] [public repo merge queue], [private repo merge queue] (for **ARM review** queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

</details>

## Purpose of this PR

What's the purpose of this PR? Check all that apply. This is **mandatory**!
What's the purpose of this PR? Check the specific option that applies. This is **mandatory**!

- [ ] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using [OpenAPI Hub](https://aka.ms/openapihub)).
- [ ] New resource provider.
- [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using [OpenAPI Hub](https://aka.ms/openapihub)).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- _edit this with your clarification_

Expand All @@ -67,7 +66,7 @@ and followed the instructions by checking all the boxes:
- [ ] I have reviewed following [Resource Provider guidelines](https://aka.ms/rpguidelines), including
[ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and
[REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md) (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

## Additional information

Expand All @@ -82,8 +81,7 @@ in the `Generated ApiView` comment added to this PR. You can use ApiView to show
<summary>Suppressing failures</summary>

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
[Swagger-Suppression-Process](https://aka.ms/azsdk/pr-suppressions)
to get approval.
[suppressions guide](https://aka.ms/azsdk/pr-suppressions) to get approval.

</details>

Expand All @@ -93,11 +91,12 @@ to get approval.
- To understand what you must do next to merge this PR, see the `Next Steps to Merge` comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`.
This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.
- If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[ARM review queue]: https://github.com/search?q=org%3AAzure+is%3Apr+is%3Aopen+label%3AWaitForARMFeedback+-label%3AIDCDevDiv++draft%3Afalse+sort%3Acreated-asc+&type=pullrequests
[ARM review queue]: https://aka.ms/azsdk/pr-arm-review#about-the-arm-review-queue
[public repo merge queue]: https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+draft%3Afalse+sort%3Acreated-asc
[private repo merge queue]: https://github.com/Azure/azure-rest-api-specs-pr/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+-label%3AApproved-OkToMerge+draft%3Afalse+sort%3Acreated-asc
[breaking changes process]: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/launchingproductbreakingchanges#breaking-change-process-1
10 changes: 0 additions & 10 deletions .github/comment.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
---
- rule:
type: label
label: "CI-MissingBaseCommit"
onLabeledComments: >-
Hi @${PRAuthor}! For review efficiency consideration,
when creating a new API version, it is required to place API specs of the
base version in the first commit, and push new version updates into successive commits.
You can use OpenAPIHub to initialize the PR for adding a new version. <br/>
For more details refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version).

- rule:
type: label
repoAllowList:
Expand Down
6 changes: 0 additions & 6 deletions .github/issue_assignment.yml

This file was deleted.

Loading
Loading