Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsp, avs, rename List API response schema back to ##List #29408

Merged
merged 5 commits into from
Jun 14, 2024
Merged

tsp, avs, rename List API response schema back to ##List #29408

merged 5 commits into from
Jun 14, 2024

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jun 12, 2024 •
edited
Loading

No REST API change.

This would only affect SDK (maybe REST API doc).
Rename these model back to what's in prior stable api-versions, e.g.

azure-rest-api-specs/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-03-01/vmware.json

Line 425 in c1416ca

"$ref": "#/definitions/PrivateCloudList"

I did not modify OperationListResult, as it is via interface template. Seems better to keep it.

azure-rest-api-specs/specification/vmware/Microsoft.AVS/routes.tsp

Line 15 in c1416ca

interface Operations extends Azure.ResourceManager.Operations {}

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • Compatibility fix for SDK (fix issue introduced when service migrated to TypeSpec), no REST API change

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
Compared specs (v0.10.9) new version base version
vmware.json 2023-09-01(eb8c29a) 2023-09-01(main)
Rule Message
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L248:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L248:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L293:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L293:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L612:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L612:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L886:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L886:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L1142:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L1142:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L1398:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L1398:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L1745:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L1745:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L2091:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L2091:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L2470:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L2470:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L2664:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L2664:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L2920:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L2920:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L3549:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L3549:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L3872:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L3872:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L3985:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L3985:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L4098:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L4098:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L4192:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L4192:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L4504:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L4504:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L4816:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L4816:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L5131:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L5131:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L5233:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L5233:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L5545:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L5545:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L5782:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L5782:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L6119:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L6119:13
❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AVS/stable/2023-09-01/vmware.json#L6221:13
Old: Microsoft.AVS/stable/2023-09-01/vmware.json#L6221:13
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail]
Compared specs (v2.2.2) new version base version
package-2023-09-01 package-2023-09-01(eb8c29a) package-2023-09-01(main)

The following errors/warnings exist before current PR submission:

Rule Message
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L519
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L785
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1041
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1297
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1636
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1916
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2353
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2819
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3285
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3704
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4409
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4731
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5043
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5460
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5694
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6018
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6448
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9034
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9337
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-avs [Preview SDK Changes] Breaking Change Detected
    • azure-arm-avs-5.0.0.tgz
    Only showing 120 items here. Refer to log for details.
    info	[Changelog]   - Added Interface WorkloadNetworksUpdateDnsZoneHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdatePortMirroringHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateSegmentsHeaders
info	[Changelog]   - Added Interface WorkloadNetworksUpdateVMGroupHeaders
info	[Changelog]   - Added Interface WorkloadNetworkVMGroupUpdate
info	[Changelog]   - Added Type Alias ActionType
info	[Changelog]   - Added Type Alias CloudLinkProvisioningState
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias DnsZoneType
info	[Changelog]   - Added Type Alias HcxEnterpriseSiteProvisioningState
info	[Changelog]   - Added Type Alias IscsiPathProvisioningState
info	[Changelog]   - Added Type Alias IscsiPathsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias IscsiPathsGetResponse
info	[Changelog]   - Added Type Alias IscsiPathsListByPrivateCloudNextResponse
info	[Changelog]   - Added Type Alias IscsiPathsListByPrivateCloudResponse
info	[Changelog]   - Added Type Alias Origin
info	[Changelog]   - Added Type Alias PrivateCloudsRotateNsxtPasswordResponse
info	[Changelog]   - Added Type Alias PrivateCloudsRotateVcenterPasswordResponse
info	[Changelog]   - Added Type Alias ScriptCmdletAudience
info	[Changelog]   - Added Type Alias ScriptCmdletProvisioningState
info	[Changelog]   - Added Type Alias ScriptPackageProvisioningState
info	[Changelog]   - Added Type Alias SkuTier
info	[Changelog]   - Added Type Alias SystemAssignedServiceIdentityType
info	[Changelog]   - Added Type Alias VirtualMachineProvisioningState
info	[Changelog]   - Added Type Alias VirtualMachinesRestrictMovementResponse
info	[Changelog]   - Added Type Alias WorkloadNetworkDhcpEntityUpdateUnion
info	[Changelog]   - Added Type Alias WorkloadNetworkProvisioningState
info	[Changelog]   - Interface CloudLink has a new optional parameter provisioningState
info	[Changelog]   - Interface Cluster has a new optional parameter vsanDatastoreName
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter sku
info	[Changelog]   - Interface Datastore has a new optional parameter elasticSanVolume
info	[Changelog]   - Interface Endpoints has a new optional parameter hcxCloudManagerIp
info	[Changelog]   - Interface Endpoints has a new optional parameter nsxtManagerIp
info	[Changelog]   - Interface Endpoints has a new optional parameter vcenterIp
info	[Changelog]   - Interface HcxEnterpriseSite has a new optional parameter provisioningState
info	[Changelog]   - Interface ManagementCluster has a new optional parameter clusterId
info	[Changelog]   - Interface ManagementCluster has a new optional parameter clusterSize
info	[Changelog]   - Interface ManagementCluster has a new optional parameter hosts
info	[Changelog]   - Interface ManagementCluster has a new optional parameter provisioningState
info	[Changelog]   - Interface ManagementCluster has a new optional parameter vsanDatastoreName
info	[Changelog]   - Interface Operation has a new optional parameter actionType
info	[Changelog]   - Interface PrivateCloud has a new optional parameter dnsZoneType
info	[Changelog]   - Interface PrivateCloud has a new optional parameter virtualNetworkId
info	[Changelog]   - Interface PrivateCloudUpdate has a new optional parameter dnsZoneType
info	[Changelog]   - Interface PrivateCloudUpdate has a new optional parameter sku
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Interface ScriptCmdlet has a new optional parameter audience
info	[Changelog]   - Interface ScriptCmdlet has a new optional parameter provisioningState
info	[Changelog]   - Interface ScriptPackage has a new optional parameter provisioningState
info	[Changelog]   - Interface Sku has a new optional parameter capacity
info	[Changelog]   - Interface Sku has a new optional parameter family
info	[Changelog]   - Interface Sku has a new optional parameter size
info	[Changelog]   - Interface Sku has a new optional parameter tier
info	[Changelog]   - Interface VirtualMachine has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetwork has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetworkGateway has a new optional parameter provisioningState
info	[Changelog]   - Interface WorkloadNetworkVirtualMachine has a new optional parameter provisioningState
info	[Changelog]   - Type of parameter addonType of interface AddonProperties is changed from "SRM" | "VR" | "HCX" | "Arc" to "Arc" | "HCX" | "SRM" | "VR"
info	[Changelog]   - Type of parameter type of interface PlacementPolicyProperties is changed from "VmVm" | "VmHost" to "VmHost" | "VmVm"
info	[Changelog]   - Type of parameter type of interface ScriptExecutionParameter is changed from "SecureValue" | "Value" | "Credential" to "Credential" | "SecureValue" | "Value"
info	[Changelog]   - Type of parameter dhcpType of interface WorkloadNetworkDhcpEntity is changed from "SERVER" | "RELAY" to "RELAY" | "SERVER"
info	[Changelog]   - Added Enum KnownActionType
info	[Changelog]   - Added Enum KnownCloudLinkProvisioningState
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownDnsZoneType
info	[Changelog]   - Added Enum KnownHcxEnterpriseSiteProvisioningState
info	[Changelog]   - Added Enum KnownIscsiPathProvisioningState
info	[Changelog]   - Added Enum KnownOrigin
info	[Changelog]   - Added Enum KnownScriptCmdletAudience
info	[Changelog]   - Added Enum KnownScriptCmdletProvisioningState
info	[Changelog]   - Added Enum KnownScriptPackageProvisioningState
info	[Changelog]   - Added Enum KnownSystemAssignedServiceIdentityType
info	[Changelog]   - Added Enum KnownVirtualMachineProvisioningState
info	[Changelog]   - Added Enum KnownWorkloadNetworkProvisioningState
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDhcp has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDhcpAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsService has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsServiceAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsZone has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateDnsZoneAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdatePortMirroring has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdatePortMirroringAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateSegments has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateSegmentsAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateVMGroup has a new signature
info	[Changelog]   - Operation WorkloadNetworks.beginUpdateVMGroupAndWait has a new signature
info	[Changelog]   - Operation WorkloadNetworks.get has a new signature
info	[Changelog]   - Interface Operation no longer has parameter properties
info	[Changelog]   - Parameter value of interface AddonList is now required
info	[Changelog]   - Parameter value of interface CloudLinkList is now required
info	[Changelog]   - Parameter value of interface ClusterList is now required
info	[Changelog]   - Parameter value of interface DatastoreList is now required
info	[Changelog]   - Parameter value of interface ExpressRouteAuthorizationList is now required
info	[Changelog]   - Parameter value of interface GlobalReachConnectionList is now required
info	[Changelog]   - Parameter value of interface HcxEnterpriseSiteList is now required
info	[Changelog]   - Parameter value of interface PlacementPoliciesList is now required
info	[Changelog]   - Parameter value of interface PrivateCloudList is now required
info	[Changelog]   - Parameter value of interface ScriptCmdletsList is now required
info	[Changelog]   - Parameter value of interface ScriptExecutionsList is now required
info	[Changelog]   - Parameter value of interface ScriptPackagesList is now required
info	[Changelog]   - Parameter location of interface TrackedResource is now required
info	[Changelog]   - Parameter value of interface VirtualMachinesList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkDhcpList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkDnsServicesList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkDnsZonesList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkGatewayList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkPortMirroringList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkPublicIPsList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkSegmentsList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkVirtualMachinesList is now required
info	[Changelog]   - Parameter value of interface WorkloadNetworkVMGroupsList is now required
info	[Changelog]   - Type of parameter origin of interface Operation is changed from string to Origin
info	[Changelog]   - Type of parameter identity of interface PrivateCloud is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
info	[Changelog]   - Type of parameter identity of interface PrivateCloudUpdate is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
info	[Changelog]   - Removed Enum KnownResourceIdentityType
info	[Changelog]   - Removed Enum KnownWorkloadNetworkName
    Present SDK breaking changes suppressions
Interface Operation no longer has parameter properties
Operation WorkloadNetworks.beginUpdateDhcp has a new signature
Operation WorkloadNetworks.beginUpdateDhcpAndWait has a new signature
Operation WorkloadNetworks.beginUpdateDnsService has a new signature
Operation WorkloadNetworks.beginUpdateDnsServiceAndWait has a new signature
Operation WorkloadNetworks.beginUpdateDnsZone has a new signature
Operation WorkloadNetworks.beginUpdateDnsZoneAndWait has a new signature
Operation WorkloadNetworks.beginUpdatePortMirroring has a new signature
Operation WorkloadNetworks.beginUpdatePortMirroringAndWait has a new signature
Operation WorkloadNetworks.beginUpdateSegments has a new signature
Operation WorkloadNetworks.beginUpdateSegmentsAndWait has a new signature
Operation WorkloadNetworks.beginUpdateVMGroup has a new signature
Operation WorkloadNetworks.beginUpdateVMGroupAndWait has a new signature
Operation WorkloadNetworks.get has a new signature
Parameter location of interface TrackedResource is now required
Removed Enum KnownResourceIdentityType
Removed Enum KnownWorkloadNetworkName
Type of parameter identity of interface PrivateCloud is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
Type of parameter identity of interface PrivateCloudUpdate is changed from PrivateCloudIdentity to SystemAssignedServiceIdentity
Type of parameter origin of interface Operation is changed from string to Origin
    Absent SDK breaking changes suppressions
- Parameter value of interface AddonList is now required
- Parameter value of interface CloudLinkList is now required
- Parameter value of interface ClusterList is now required
- Parameter value of interface DatastoreList is now required
- Parameter value of interface ExpressRouteAuthorizationList is now required
- Parameter value of interface GlobalReachConnectionList is now required
- Parameter value of interface HcxEnterpriseSiteList is now required
- Parameter value of interface PlacementPoliciesList is now required
- Parameter value of interface PrivateCloudList is now required
- Parameter value of interface ScriptCmdletsList is now required
- Parameter value of interface ScriptExecutionsList is now required
- Parameter value of interface ScriptPackagesList is now required
- Parameter value of interface VirtualMachinesList is now required
- Parameter value of interface WorkloadNetworkDhcpList is now required
- Parameter value of interface WorkloadNetworkDnsServicesList is now required
- Parameter value of interface WorkloadNetworkDnsZonesList is now required
- Parameter value of interface WorkloadNetworkGatewayList is now required
- Parameter value of interface WorkloadNetworkList is now required
- Parameter value of interface WorkloadNetworkPortMirroringList is now required
- Parameter value of interface WorkloadNetworkPublicIPsList is now required
- Parameter value of interface WorkloadNetworkSegmentsList is now required
- Parameter value of interface WorkloadNetworkVMGroupsList is now required
- Parameter value of interface WorkloadNetworkVirtualMachinesList is now required
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[automation_init.sh] npm notice
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-avs [Preview SDK Changes] Breaking Change Detected
    • azure-mgmt-avs-1.0.0b1.zip
    • azure_mgmt_avs-1.0.0b1-py3-none-any.whl
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group IscsiPathsOperations
info	[Changelog]   - Model Addon has a new parameter system_data
info	[Changelog]   - Model CloudLink has a new parameter provisioning_state
info	[Changelog]   - Model CloudLink has a new parameter system_data
info	[Changelog]   - Model Cluster has a new parameter system_data
info	[Changelog]   - Model Cluster has a new parameter vsan_datastore_name
info	[Changelog]   - Model ClusterUpdate has a new parameter sku
info	[Changelog]   - Model Datastore has a new parameter elastic_san_volume
info	[Changelog]   - Model Datastore has a new parameter system_data
info	[Changelog]   - Model Endpoints has a new parameter hcx_cloud_manager_ip
info	[Changelog]   - Model Endpoints has a new parameter nsxt_manager_ip
info	[Changelog]   - Model Endpoints has a new parameter vcenter_ip
info	[Changelog]   - Model ExpressRouteAuthorization has a new parameter system_data
info	[Changelog]   - Model GlobalReachConnection has a new parameter system_data
info	[Changelog]   - Model HcxEnterpriseSite has a new parameter provisioning_state
info	[Changelog]   - Model HcxEnterpriseSite has a new parameter system_data
info	[Changelog]   - Model ManagementCluster has a new parameter vsan_datastore_name
info	[Changelog]   - Model Operation has a new parameter action_type
info	[Changelog]   - Model PlacementPolicy has a new parameter system_data
info	[Changelog]   - Model PrivateCloud has a new parameter dns_zone_type
info	[Changelog]   - Model PrivateCloud has a new parameter system_data
info	[Changelog]   - Model PrivateCloud has a new parameter virtual_network_id
info	[Changelog]   - Model PrivateCloudUpdate has a new parameter dns_zone_type
info	[Changelog]   - Model PrivateCloudUpdate has a new parameter sku
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model ScriptCmdlet has a new parameter audience
info	[Changelog]   - Model ScriptCmdlet has a new parameter provisioning_state
info	[Changelog]   - Model ScriptCmdlet has a new parameter system_data
info	[Changelog]   - Model ScriptExecution has a new parameter system_data
info	[Changelog]   - Model ScriptPackage has a new parameter provisioning_state
info	[Changelog]   - Model ScriptPackage has a new parameter system_data
info	[Changelog]   - Model Sku has a new parameter capacity
info	[Changelog]   - Model Sku has a new parameter family
info	[Changelog]   - Model Sku has a new parameter size
info	[Changelog]   - Model Sku has a new parameter tier
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]   - Model VirtualMachine has a new parameter provisioning_state
info	[Changelog]   - Model VirtualMachine has a new parameter system_data
info	[Changelog]   - Model WorkloadNetwork has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetwork has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDhcp has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDnsService has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkDnsZone has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkGateway has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetworkGateway has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkPortMirroring has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkPublicIP has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkSegment has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkVMGroup has a new parameter system_data
info	[Changelog]   - Model WorkloadNetworkVirtualMachine has a new parameter provisioning_state
info	[Changelog]   - Model WorkloadNetworkVirtualMachine has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Operation no longer has parameter properties
info	[Changelog]   - Operation WorkloadNetworksOperations.get no longer has parameter workload_network_name
info	[Changelog]   - Parameter location of model PrivateCloud is now required
info	[Changelog]   - Parameter location of model TrackedResource is now required
info	[Changelog]   - Parameter value of model AddonList is now required
info	[Changelog]   - Parameter value of model CloudLinkList is now required
info	[Changelog]   - Parameter value of model ClusterList is now required
info	[Changelog]   - Parameter value of model DatastoreList is now required
info	[Changelog]   - Parameter value of model ExpressRouteAuthorizationList is now required
info	[Changelog]   - Parameter value of model GlobalReachConnectionList is now required
info	[Changelog]   - Parameter value of model HcxEnterpriseSiteList is now required
info	[Changelog]   - Parameter value of model PlacementPoliciesList is now required
info	[Changelog]   - Parameter value of model PrivateCloudList is now required
info	[Changelog]   - Parameter value of model ScriptCmdletsList is now required
info	[Changelog]   - Parameter value of model ScriptExecutionsList is now required
info	[Changelog]   - Parameter value of model ScriptPackagesList is now required
info	[Changelog]   - Parameter value of model VirtualMachinesList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkDhcpList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkDnsServicesList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkDnsZonesList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkGatewayList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkPortMirroringList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkPublicIPsList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkSegmentsList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkVMGroupsList is now required
info	[Changelog]   - Parameter value of model WorkloadNetworkVirtualMachinesList is now required
    Present SDK breaking changes suppressions
Model Operation no longer has parameter properties
Operation WorkloadNetworksOperations.get no longer has parameter workload_network_name
Parameter location of model PrivateCloud is now required
Parameter location of model TrackedResource is now required
    Absent SDK breaking changes suppressions
- Parameter value of model AddonList is now required
- Parameter value of model CloudLinkList is now required
- Parameter value of model ClusterList is now required
- Parameter value of model DatastoreList is now required
- Parameter value of model ExpressRouteAuthorizationList is now required
- Parameter value of model GlobalReachConnectionList is now required
- Parameter value of model HcxEnterpriseSiteList is now required
- Parameter value of model PlacementPoliciesList is now required
- Parameter value of model PrivateCloudList is now required
- Parameter value of model ScriptCmdletsList is now required
- Parameter value of model ScriptExecutionsList is now required
- Parameter value of model ScriptPackagesList is now required
- Parameter value of model VirtualMachinesList is now required
- Parameter value of model WorkloadNetworkDhcpList is now required
- Parameter value of model WorkloadNetworkDnsServicesList is now required
- Parameter value of model WorkloadNetworkDnsZonesList is now required
- Parameter value of model WorkloadNetworkGatewayList is now required
- Parameter value of model WorkloadNetworkList is now required
- Parameter value of model WorkloadNetworkPortMirroringList is now required
- Parameter value of model WorkloadNetworkPublicIPsList is now required
- Parameter value of model WorkloadNetworkSegmentsList is now required
- Parameter value of model WorkloadNetworkVMGroupsList is now required
- Parameter value of model WorkloadNetworkVirtualMachinesList is now required
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-net not found in tspconfig.yaml
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Avs [Preview SDK Changes]
    • Microsoft.Azure.Management.Avs.3.0.0.nupkg
    • Microsoft.Azure.Management.Avs.3.0.0.symbols.nupkg
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/avs/armavs [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdateDNSService` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSService, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSServiceUpdate, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdateDNSZone` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSZone, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSZoneUpdate, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdateDhcp` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDhcp, *WorkloadNetworksClientBeginUpdateDhcpOptions)` to `(context.Context, string, string, string, WorkloadNetworkDhcpUpdate, *WorkloadNetworksClientBeginUpdateDhcpOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdatePortMirroring` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkPortMirroring, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)` to `(context.Context, string, string, string, WorkloadNetworkPortMirroringUpdate, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdateSegments` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkSegment, *WorkloadNetworksClientBeginUpdateSegmentsOptions)` to `(context.Context, string, string, string, WorkloadNetworkSegmentUpdate, *WorkloadNetworksClientBeginUpdateSegmentsOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.BeginUpdateVMGroup` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkVMGroup, *WorkloadNetworksClientBeginUpdateVMGroupOptions)` to `(context.Context, string, string, string, WorkloadNetworkVMGroupUpdate, *WorkloadNetworksClientBeginUpdateVMGroupOptions)`
info	[Changelog] - Function `*WorkloadNetworksClient.Get` parameter(s) have been changed from `(context.Context, string, string, WorkloadNetworkName, *WorkloadNetworksClientGetOptions)` to `(context.Context, string, string, *WorkloadNetworksClientGetOptions)`
info	[Changelog] - Type of `Operation.Origin` has been changed from `*string` to `*Origin`
info	[Changelog] - Type of `PrivateCloud.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
info	[Changelog] - Type of `PrivateCloudUpdate.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
info	[Changelog] - Type of `WorkloadNetworkDNSZoneProperties.DNSServices` has been changed from `*int64` to `*int32`
info	[Changelog] - Enum `ResourceIdentityType` has been removed
info	[Changelog] - Enum `WorkloadNetworkName` has been removed
info	[Changelog] - Struct `LogSpecification` has been removed
info	[Changelog] - Struct `MetricDimension` has been removed
info	[Changelog] - Struct `MetricSpecification` has been removed
info	[Changelog] - Struct `OperationList` has been removed
info	[Changelog] - Struct `OperationProperties` has been removed
info	[Changelog] - Struct `PrivateCloudIdentity` has been removed
info	[Changelog] - Struct `ServiceSpecification` has been removed
info	[Changelog] - Field `Properties` of struct `Operation` has been removed
info	[Changelog] - Field `OperationList` of struct `OperationsClientListResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `ActionType` with values `ActionTypeInternal`
info	[Changelog] - New enum type `CloudLinkProvisioningState` with values `CloudLinkProvisioningStateCanceled`, `CloudLinkProvisioningStateFailed`, `CloudLinkProvisioningStateSucceeded`
info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New enum type `DNSZoneType` with values `DNSZoneTypePrivate`, `DNSZoneTypePublic`
info	[Changelog] - New enum type `HcxEnterpriseSiteProvisioningState` with values `HcxEnterpriseSiteProvisioningStateCanceled`, `HcxEnterpriseSiteProvisioningStateFailed`, `HcxEnterpriseSiteProvisioningStateSucceeded`
info	[Changelog] - New enum type `IscsiPathProvisioningState` with values `IscsiPathProvisioningStateBuilding`, `IscsiPathProvisioningStateCanceled`, `IscsiPathProvisioningStateDeleting`, `IscsiPathProvisioningStateFailed`, `IscsiPathProvisioningStatePending`, `IscsiPathProvisioningStateSucceeded`, `IscsiPathProvisioningStateUpdating`
info	[Changelog] - New enum type `Origin` with values `OriginSystem`, `OriginUser`, `OriginUserSystem`
info	[Changelog] - New enum type `SKUTier` with values `SKUTierBasic`, `SKUTierFree`, `SKUTierPremium`, `SKUTierStandard`
info	[Changelog] - New enum type `ScriptCmdletAudience` with values `ScriptCmdletAudienceAny`, `ScriptCmdletAudienceAutomation`
info	[Changelog] - New enum type `ScriptCmdletProvisioningState` with values `ScriptCmdletProvisioningStateCanceled`, `ScriptCmdletProvisioningStateFailed`, `ScriptCmdletProvisioningStateSucceeded`
info	[Changelog] - New enum type `ScriptPackageProvisioningState` with values `ScriptPackageProvisioningStateCanceled`, `ScriptPackageProvisioningStateFailed`, `ScriptPackageProvisioningStateSucceeded`
info	[Changelog] - New enum type `SystemAssignedServiceIdentityType` with values `SystemAssignedServiceIdentityTypeNone`, `SystemAssignedServiceIdentityTypeSystemAssigned`
info	[Changelog] - New enum type `VirtualMachineProvisioningState` with values `VirtualMachineProvisioningStateCanceled`, `VirtualMachineProvisioningStateFailed`, `VirtualMachineProvisioningStateSucceeded`
info	[Changelog] - New enum type `WorkloadNetworkProvisioningState` with values `WorkloadNetworkProvisioningStateBuilding`, `WorkloadNetworkProvisioningStateCanceled`, `WorkloadNetworkProvisioningStateDeleting`, `WorkloadNetworkProvisioningStateFailed`, `WorkloadNetworkProvisioningStateSucceeded`, `WorkloadNetworkProvisioningStateUpdating`
info	[Changelog] - New function `*ClientFactory.NewIscsiPathsClient() *IscsiPathsClient`
info	[Changelog] - New function `NewIscsiPathsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*IscsiPathsClient, error)`
info	[Changelog] - New function `*IscsiPathsClient.BeginCreateOrUpdate(context.Context, string, string, IscsiPath, *IscsiPathsClientBeginCreateOrUpdateOptions) (*runtime.Poller[IscsiPathsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*IscsiPathsClient.BeginDelete(context.Context, string, string, *IscsiPathsClientBeginDeleteOptions) (*runtime.Poller[IscsiPathsClientDeleteResponse], error)`
info	[Changelog] - New function `*IscsiPathsClient.Get(context.Context, string, string, *IscsiPathsClientGetOptions) (IscsiPathsClientGetResponse, error)`
info	[Changelog] - New function `*IscsiPathsClient.NewListByPrivateCloudPager(string, string, *IscsiPathsClientListByPrivateCloudOptions) *runtime.Pager[IscsiPathsClientListByPrivateCloudResponse]`
info	[Changelog] - New function `*WorkloadNetworkDhcpEntityUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New function `*WorkloadNetworkDhcpRelayUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New function `*WorkloadNetworkDhcpServerUpdate.GetWorkloadNetworkDhcpEntityUpdate() *WorkloadNetworkDhcpEntityUpdate`
info	[Changelog] - New struct `ElasticSanVolume`
info	[Changelog] - New struct `IscsiPath`
info	[Changelog] - New struct `IscsiPathListResult`
info	[Changelog] - New struct `IscsiPathProperties`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `SystemAssignedServiceIdentity`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `WorkloadNetworkDNSServiceUpdate`
info	[Changelog] - New struct `WorkloadNetworkDNSZoneUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpRelayUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpServerUpdate`
info	[Changelog] - New struct `WorkloadNetworkDhcpUpdate`
info	[Changelog] - New struct `WorkloadNetworkPortMirroringUpdate`
info	[Changelog] - New struct `WorkloadNetworkProperties`
info	[Changelog] - New struct `WorkloadNetworkSegmentUpdate`
info	[Changelog] - New struct `WorkloadNetworkVMGroupUpdate`
info	[Changelog] - New field `SystemData` in struct `Addon`
info	[Changelog] - New field `SystemData` in struct `CloudLink`
info	[Changelog] - New field `ProvisioningState` in struct `CloudLinkProperties`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `VsanDatastoreName` in struct `ClusterProperties`
info	[Changelog] - New field `SKU` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Datastore`
info	[Changelog] - New field `ElasticSanVolume` in struct `DatastoreProperties`
info	[Changelog] - New field `HcxCloudManagerIP`, `NsxtManagerIP`, `VcenterIP` in struct `Endpoints`
info	[Changelog] - New field `SystemData` in struct `ExpressRouteAuthorization`
info	[Changelog] - New field `SystemData` in struct `GlobalReachConnection`
info	[Changelog] - New field `SystemData` in struct `HcxEnterpriseSite`
info	[Changelog] - New field `ProvisioningState` in struct `HcxEnterpriseSiteProperties`
info	[Changelog] - New field `VsanDatastoreName` in struct `ManagementCluster`
info	[Changelog] - New field `ActionType` in struct `Operation`
info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsClientListResponse`
info	[Changelog] - New field `SystemData` in struct `PlacementPolicy`
info	[Changelog] - New field `SystemData` in struct `PrivateCloud`
info	[Changelog] - New field `DNSZoneType`, `VirtualNetworkID` in struct `PrivateCloudProperties`
info	[Changelog] - New field `SKU` in struct `PrivateCloudUpdate`
info	[Changelog] - New field `DNSZoneType` in struct `PrivateCloudUpdateProperties`
info	[Changelog] - New field `Capacity`, `Family`, `Size`, `Tier` in struct `SKU`
info	[Changelog] - New field `SystemData` in struct `ScriptCmdlet`
info	[Changelog] - New field `Audience`, `ProvisioningState` in struct `ScriptCmdletProperties`
info	[Changelog] - New field `SystemData` in struct `ScriptExecution`
info	[Changelog] - New field `SystemData` in struct `ScriptPackage`
info	[Changelog] - New field `ProvisioningState` in struct `ScriptPackageProperties`
info	[Changelog] - New field `SystemData` in struct `VirtualMachine`
info	[Changelog] - New field `ProvisioningState` in struct `VirtualMachineProperties`
info	[Changelog] - New field `Properties`, `SystemData` in struct `WorkloadNetwork`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDNSService`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDNSZone`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkDhcp`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkGateway`
info	[Changelog] - New field `ProvisioningState` in struct `WorkloadNetworkGatewayProperties`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkPortMirroring`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkPublicIP`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkSegment`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkVMGroup`
info	[Changelog] - New field `SystemData` in struct `WorkloadNetworkVirtualMachine`
info	[Changelog] - New field `ProvisioningState` in struct `WorkloadNetworkVirtualMachineProperties`
info	[Changelog]
info	[Changelog] Total 29 breaking change(s), 143 additive change(s).
    Present SDK breaking changes suppressions
Enum `ResourceIdentityType` has been removed
Enum `WorkloadNetworkName` has been removed
Field `AddonList` of struct `AddonsClientListResponse` has been removed
Field `CloudLinkList` of struct `CloudLinksClientListResponse` has been removed
Field `ClusterList` of struct `ClustersClientListResponse` has been removed
Field `DatastoreList` of struct `DatastoresClientListResponse` has been removed
Field `ExpressRouteAuthorizationList` of struct `AuthorizationsClientListResponse` has been removed
Field `GlobalReachConnectionList` of struct `GlobalReachConnectionsClientListResponse` has been removed
Field `HcxEnterpriseSiteList` of struct `HcxEnterpriseSitesClientListResponse` has been removed
Field `OperationList` of struct `OperationsClientListResponse` has been removed
Field `PlacementPoliciesList` of struct `PlacementPoliciesClientListResponse` has been removed
Field `PrivateCloudList` of struct `PrivateCloudsClientListInSubscriptionResponse` has been removed
Field `PrivateCloudList` of struct `PrivateCloudsClientListResponse` has been removed
Field `Properties` of struct `Operation` has been removed
Field `ScriptCmdletsList` of struct `ScriptCmdletsClientListResponse` has been removed
Field `ScriptExecutionsList` of struct `ScriptExecutionsClientListResponse` has been removed
Field `ScriptPackagesList` of struct `ScriptPackagesClientListResponse` has been removed
Field `VirtualMachinesList` of struct `VirtualMachinesClientListResponse` has been removed
Field `WorkloadNetworkDNSServicesList` of struct `WorkloadNetworksClientListDNSServicesResponse` has been removed
Field `WorkloadNetworkDNSZonesList` of struct `WorkloadNetworksClientListDNSZonesResponse` has been removed
Field `WorkloadNetworkDhcpList` of struct `WorkloadNetworksClientListDhcpResponse` has been removed
Field `WorkloadNetworkGatewayList` of struct `WorkloadNetworksClientListGatewaysResponse` has been removed
Field `WorkloadNetworkList` of struct `WorkloadNetworksClientListResponse` has been removed
Field `WorkloadNetworkPortMirroringList` of struct `WorkloadNetworksClientListPortMirroringResponse` has been removed
Field `WorkloadNetworkPublicIPsList` of struct `WorkloadNetworksClientListPublicIPsResponse` has been removed
Field `WorkloadNetworkSegmentsList` of struct `WorkloadNetworksClientListSegmentsResponse` has been removed
Field `WorkloadNetworkVMGroupsList` of struct `WorkloadNetworksClientListVMGroupsResponse` has been removed
Field `WorkloadNetworkVirtualMachinesList` of struct `WorkloadNetworksClientListVirtualMachinesResponse` has been removed
Function `*WorkloadNetworksClient.BeginUpdateDNSService` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSService, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSServiceUpdate, *WorkloadNetworksClientBeginUpdateDNSServiceOptions)`
Function `*WorkloadNetworksClient.BeginUpdateDNSZone` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDNSZone, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)` to `(context.Context, string, string, string, WorkloadNetworkDNSZoneUpdate, *WorkloadNetworksClientBeginUpdateDNSZoneOptions)`
Function `*WorkloadNetworksClient.BeginUpdateDhcp` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkDhcp, *WorkloadNetworksClientBeginUpdateDhcpOptions)` to `(context.Context, string, string, string, WorkloadNetworkDhcpUpdate, *WorkloadNetworksClientBeginUpdateDhcpOptions)`
Function `*WorkloadNetworksClient.BeginUpdatePortMirroring` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkPortMirroring, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)` to `(context.Context, string, string, string, WorkloadNetworkPortMirroringUpdate, *WorkloadNetworksClientBeginUpdatePortMirroringOptions)`
Function `*WorkloadNetworksClient.BeginUpdateSegments` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkSegment, *WorkloadNetworksClientBeginUpdateSegmentsOptions)` to `(context.Context, string, string, string, WorkloadNetworkSegmentUpdate, *WorkloadNetworksClientBeginUpdateSegmentsOptions)`
Function `*WorkloadNetworksClient.BeginUpdateVMGroup` parameter(s) have been changed from `(context.Context, string, string, string, WorkloadNetworkVMGroup, *WorkloadNetworksClientBeginUpdateVMGroupOptions)` to `(context.Context, string, string, string, WorkloadNetworkVMGroupUpdate, *WorkloadNetworksClientBeginUpdateVMGroupOptions)`
Function `*WorkloadNetworksClient.Get` parameter(s) have been changed from `(context.Context, string, string, WorkloadNetworkName, *WorkloadNetworksClientGetOptions)` to `(context.Context, string, string, *WorkloadNetworksClientGetOptions)`
Struct `AddonList` has been removed
Struct `CloudLinkList` has been removed
Struct `ClusterList` has been removed
Struct `DatastoreList` has been removed
Struct `ExpressRouteAuthorizationList` has been removed
Struct `GlobalReachConnectionList` has been removed
Struct `HcxEnterpriseSiteList` has been removed
Struct `LogSpecification` has been removed
Struct `MetricDimension` has been removed
Struct `MetricSpecification` has been removed
Struct `OperationList` has been removed
Struct `OperationProperties` has been removed
Struct `PlacementPoliciesList` has been removed
Struct `PrivateCloudIdentity` has been removed
Struct `PrivateCloudList` has been removed
Struct `ScriptCmdletsList` has been removed
Struct `ScriptExecutionsList` has been removed
Struct `ScriptPackagesList` has been removed
Struct `ServiceSpecification` has been removed
Struct `VirtualMachinesList` has been removed
Struct `WorkloadNetworkDNSServicesList` has been removed
Struct `WorkloadNetworkDNSZonesList` has been removed
Struct `WorkloadNetworkDhcpList` has been removed
Struct `WorkloadNetworkGatewayList` has been removed
Struct `WorkloadNetworkList` has been removed
Struct `WorkloadNetworkPortMirroringList` has been removed
Struct `WorkloadNetworkPublicIPsList` has been removed
Struct `WorkloadNetworkSegmentsList` has been removed
Struct `WorkloadNetworkVMGroupsList` has been removed
Struct `WorkloadNetworkVirtualMachinesList` has been removed
Type of `Operation.Origin` has been changed from `*string` to `*Origin`
Type of `PrivateCloud.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
Type of `PrivateCloudUpdate.Identity` has been changed from `*PrivateCloudIdentity` to `*SystemAssignedServiceIdentity`
Type of `WorkloadNetworkDNSZoneProperties.DNSServices` has been changed from `*int64` to `*int32`
Type of `WorkloadNetworkDhcpServer.LeaseTime` has been changed from `*int64` to `*int32`
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-avs [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-avs-1.2.0-beta.1-sources.jar
    • azure-resourcemanager-avs-1.2.0-beta.1.jar
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Code Generator Failed in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-resource-manager-schemas not found in tspconfig.yaml
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 32fe98abb34cc7810d5c1323beb037d27ff10e11. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/vmware/Microsoft.AVS/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.vmware.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/avs/armavs https://apiview.dev/Assemblies/Review/5135f0843f0641959b423a9012516d60?revisionId=7b78f0dc053141dfb9bae0332db893e1
Java azure-resourcemanager-avs https://apiview.dev/Assemblies/Review/ab655a3669ab4e108f3d5b0376655237?revisionId=2fbf51f197ca496fbdca38c738b5e621
JavaScript @azure/arm-avs https://apiview.dev/Assemblies/Review/993c23ef90ad48f1a7e3dba3509092d5?revisionId=2b5ff443cc4748989b41ef3b002c5a27
TypeSpec Microsoft.AVS https://apiview.dev/Assemblies/Review/b636962f14194499812c6df83e4356be?revisionId=61e1372ac10a4da3b71d12ee67325167

@azure-sdk azure-sdk mentioned this pull request Jun 12, 2024
Closed
This was referenced Jun 12, 2024
Closed
Closed
This was referenced Jun 12, 2024
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Jun 12, 2024
Closed
@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Jun 12, 2024
Open
@weidongxu-microsoft weidongxu-microsoft changed the title test - tsp, avs, rename list response to ##List test - tsp, avs, rename list response back to ##List Jun 13, 2024
@weidongxu-microsoft weidongxu-microsoft changed the title test - tsp, avs, rename list response back to ##List tsp, avs, rename list response back to ##List Jun 13, 2024
@weidongxu-microsoft weidongxu-microsoft changed the title tsp, avs, rename list response back to ##List tsp, avs, rename List API response schema back to ##List Jun 13, 2024
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 13, 2024 04:14
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 13, 2024
qiaozha
qiaozha approved these changes Jun 13, 2024
View reviewed changes
specification/vmware/Microsoft.AVS/routes.tsp
list is ArmResourceListByParent<WorkloadNetworkDnsZone>;
list is ArmResourceListByParent<
WorkloadNetworkDnsZone,
Response = ArmResponse<ResourceList<WorkloadNetworkDnsZone, "{name}sList">>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a minor concern, is this the right way to get plural if the name is policy?

specification/vmware/Microsoft.AVS/routes.tsp
@@ -38,9 +38,15 @@ interface Locations {
interface PrivateClouds {
#suppress "@azure-tools/typespec-azure-core/no-operation-id" "Can not change existing operationId."
@operationId("PrivateClouds_List")
list is ArmResourceListByParent<PrivateCloud>;
list is ArmResourceListByParent<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the naming fix be covered in 0.57.0? if yes, we will need to regen after typespec is released for this right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this release, we likely would generate from Swagger. And operationId in Swagger is specified on above @operationId("PrivateClouds_List") line.

We are renaming these List in another PR (in client.tsp) #29308
But as we know, the problem is how to rename resource group...

specification/vmware/Microsoft.AVS/routes.tsp
PlacementPolicy,
Response = ArmResponse<ResourceList<
PlacementPolicy,
"PlacementPoliciesList"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see we can specify the full name here.

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 13, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 13, 2024
cataggar
cataggar approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weidongxu-microsoft.

@weidongxu-microsoft weidongxu-microsoft merged commit 2209f9b into Azure:main Jun 14, 2024
30 of 32 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the tsp_avs_rename-list-response branch June 14, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raych1 raych1 raych1 approved these changes

@qiaozha qiaozha qiaozha approved these changes

@cataggar cataggar cataggar approved these changes

@msyyc msyyc Awaiting requested review from msyyc

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@weidongxu-microsoft @raych1 @qiaozha @cataggar @azure-sdk @AzureRestAPISpecReview @ms-bogdan-rotaru