-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview #29919
Open
koyasu221b
wants to merge
20
commits into
main
Choose a base branch
from
users/huangwill/koyasu221b-maps-Route-2024-07-01-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview #29919
koyasu221b
wants to merge
20
commits into
main
from
users/huangwill/koyasu221b-maps-Route-2024-07-01-preview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
koyasu221b
requested review from
JeffreyRichter,
marclerwick,
FarazGIS and
mikekistler
and removed request for
a team
July 19, 2024 05:34
mikekistler
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple small problems. Pls fix and then tag me to re-review.
specification/maps/data-plane/Route/preview/2024-07-01-preview/route.json
Show resolved
Hide resolved
specification/maps/data-plane/Route/preview/2024-07-01-preview/route.json
Show resolved
Hide resolved
specification/maps/data-plane/Route/preview/2024-07-01-preview/route.json
Show resolved
Hide resolved
specification/maps/data-plane/Route/preview/2024-07-01-preview/route.json
Show resolved
Hide resolved
mikekistler
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
FarazGIS
approved these changes
Jul 22, 2024
koyasu221b
added
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Jul 23, 2024
koyasu221b
changed the title
SnapToRoads and RouteRange 2024-07-01-preview
SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview
Aug 2, 2024
FarazGIS
reviewed
Aug 10, 2024
specification/maps/data-plane/Route/preview/2024-07-01-preview/route.json
Outdated
Show resolved
Hide resolved
AzureRestAPISpecReview
added
TypeSpec
Authored with TypeSpec
and removed
TypeSpec
Authored with TypeSpec
labels
Aug 12, 2024
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-2024-07-01-preview
branch
from
September 3, 2024 02:48
07c7a5a
to
cbe9a94
Compare
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-2024-07-01-preview
branch
from
September 6, 2024 06:03
cbe9a94
to
1660766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data-plane
DoNotMerge
<valid label in PR review process> use to hold merge after approval
Maps
new-api-version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.