Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview #29919

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

koyasu221b
Copy link
Member

@koyasu221b koyasu221b commented Jul 19, 2024

Data Plane API - Pull Request

  • Fix RouteRange and RouteMatrix Bug bash related issues and update descriptions.
  • Add RouteMatrix from 2024-06-01-preview to 2024-07-01-preview and remove coordinate from response
  • Remove asyncBatch APIs

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Checks stuck in `queued` state? If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ The required check named TypeSpec Requirement (data-plane) has failed. TypeSpec usage is required for all new (aka "greenfield") services. The automation detected this pull request adds at least one new service that is violating this requirement. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger Route https://apiview.dev/Assemblies/Review/46fc96bf83a8468da2623389b47566b4?revisionId=378f3ff301c443f294d032250075932d

@koyasu221b koyasu221b marked this pull request as ready for review July 19, 2024 05:34
@koyasu221b koyasu221b requested a review from a team as a code owner July 19, 2024 05:34
@koyasu221b koyasu221b requested review from JeffreyRichter, marclerwick, FarazGIS and mikekistler and removed request for a team July 19, 2024 05:34
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple small problems. Pls fix and then tag me to re-review.

Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@koyasu221b koyasu221b added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 23, 2024
@koyasu221b koyasu221b changed the title SnapToRoads and RouteRange 2024-07-01-preview SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview Aug 2, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added TypeSpec Authored with TypeSpec and removed TypeSpec Authored with TypeSpec labels Aug 12, 2024
@koyasu221b koyasu221b force-pushed the users/huangwill/koyasu221b-maps-Route-2024-07-01-preview branch from 07c7a5a to cbe9a94 Compare September 3, 2024 02:48
@koyasu221b koyasu221b force-pushed the users/huangwill/koyasu221b-maps-Route-2024-07-01-preview branch from cbe9a94 to 1660766 Compare September 6, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-plane DoNotMerge <valid label in PR review process> use to hold merge after approval Maps new-api-version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants