Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Test #7588

Closed
wants to merge 1 commit into from
Closed

For Test #7588

wants to merge 1 commit into from

Conversation

PhoenixHe-NV
Copy link
Contributor

Do not merge

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Do not merge
@AutorestCI
Copy link

AutorestCI commented Oct 23, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2019

In Testing, Please Ignore

[Logs] (Generated from 005d53a, Iteration 1)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@PhoenixHe-NV PhoenixHe-NV deleted the NullMDR-patch-1 branch December 5, 2019 05:25
yurych added a commit to yurych/azure-rest-api-specs that referenced this pull request Sep 30, 2022
…ty (Azure#7579)

* copied 2021-10-20 to 2022-06-15

* - Added spoTenantAdminUrl property
- Updated examples and the spec to make sure spoAdminTenantUrl is patchable.
- Fixed prettier errors
- copied 2021-10-20 to 2022-06-15
- corrected API version in 2022-06-15 folder
- Restored 2021-10-20 version to its original state
- made the latest API version a default tag in readme.md
- made spoTenantAdminUrl required in the new API (Azure#7586)
- Fixed required property for spoTenantAdminUrl (Azure#7588)

* Corrected PATCH schema and example (Azure#7601)
ruowan pushed a commit that referenced this pull request Oct 7, 2022
…r/RPSaaSMaster to azure-rest-api-specs/main (#20959)

* Initial commit of microsoft.syntex to RPSaaSMaster branch (#6063)

* Initial commit of microsoft.syntex to RPSaaSMaster branch
- Dev syntex microsoft.syntex 2021 10 20 preview (#5281)
- Aligned resource type names with the guidelines (plural, camelCase)
- Updated provider name in URIs to lower case and provider type to plural camelCase
- Updated examples to match specification
- Updated DocumentProperties with new required fields, added processDocuments request (#5971)
- Changed suffix from -preview to -privatepreview (#6047)
- Corrected description field (#6059)
- Reverted back to -preview from -privatepreview (#6061)

* Added Syntex to custom-words.txt

* Fixed 'Missing required property: meterId'

* Fixed "the 'openapi-subtype' is unset" error

* Fixing Lint(RPaaS) errors:
- x-ms-long-running-operation
- provisioningState

* More Lint(RPaaS) errors:
- x-ms-long-running-operation-options
- provisioningState directly in the properties bag

* ModelValidation: fixed position of provisioningState

* Fixed OneUnderscoreInOperationId LintDiff errors

* Fixing "Resource provider naming must follow the pascal case" errors.

* Fixing systemData error

* Fixed location of the types.json, which is in common-types

* Fixed location of systemData in the DocumentProcessorResource

* Another re-positioning of systemData

* Started referencing the Resource from common-types

* Changed base resource of DocumentProcessorResource from Resource to TrackedResource

* Corrected update example by adding location property

* correctly placed location property in the update request

* Fixed update LintDiff error

* Fixed Delete 204 LintDiff error

* Fixed XmsIdentifierValidation errors

* Fixed operation response

* Fixed errors related to x-ms-pageable

* Fixed duplicate example Operation IDs

* Fixed x-ms-long-running-operation - related error

* Added description field to ResponseStatus

* Fixed a spelling error

* Fixed azure-asyncoperation - related error

* fixed prettier errors

* Addressed feedback from ARM review board meeting (#6107)

* Removed processDocument operation

* Removed DocumentProcessorProperties and ProvisioningState

* Fixed examples after removing DocumentProperties and ProvisioningState

* Removed x-ms-long-running-operation and 201/202 return codes

* Revert "Removed DocumentProcessorProperties and ProvisioningState"

This reverts commit 2e621471a91c6453a2e9a154604a608dbe059ee4.

* Removed processorName property after reverting DocumentProperties back

* Simplified ProvisioningState to have only 2 states to reflect non-async resource creation status

* Removed depricated status codes from the examples

* Made sure that only tags property of the DocumentProcessorResource can be patched.

* Added "Canceled" terminal state per Sanjai's feedback.

* Added a new API version to accommodate a new spoTenantAdminUrl property (#7579)

* copied 2021-10-20 to 2022-06-15

* - Added spoTenantAdminUrl property
- Updated examples and the spec to make sure spoAdminTenantUrl is patchable.
- Fixed prettier errors
- copied 2021-10-20 to 2022-06-15
- corrected API version in 2022-06-15 folder
- Restored 2021-10-20 version to its original state
- made the latest API version a default tag in readme.md
- made spoTenantAdminUrl required in the new API (#7586)
- Fixed required property for spoTenantAdminUrl (#7588)

* Corrected PATCH schema and example (#7601)

* New API version: 2022-09-15-preview (#8815)

* initial copy of 2022-06-15-preview API

* changed API version

* Updated readme.md to incorporate a new version

* Updated resource schema

* removed processDocuments operation, associated types and examples

* Updated examples to match new schema

* Fixed prettier errors

* Removed API versions that we don't want to move from azure-rest-api-specs-pr/RPSaaSMaster to azure-rest-api-specs/main:
- 2021-10-20-preview
- 2022-06-15-preview
Left only 2022-09-15-preview version.

* Added  "x-ms-parameter-location": "method" to fix XmsParameterLocation LintDiff error.

* Tim's feedback:
- Expanded SPO achronym in comments
- Started referencing common-types v3 instead of v2
- Started referencing OperationListResult from common-types v3, removed local OperationsListResult
- Removed systemData from DocumentProcessorResource
- Added provisioningState to Create, Get, and List responses
- Changed capitalization: microsoft.syntex -> Microsoft.Syntex
- Added operation list to the Operations_list.json example

* Fixed prettier errors

* Tim's feedback:
- Added 201 response code for PUT request
- Added an example for 201 PUT response

* Tim's feedback:
- Changed Id -> ID

* Tim's feedback:
- Started using SubscriptionId, ResourceGroupName and ApiVersion parameters from common-types v3

* Tim's feedback
- Fixed casing in resource IDs

* Tim's feedback:
- correciton: patched -> updated

* Tim's feedback:
- Started referencing ErrorResponse from common-types v3

* Tim's feedback:
- Removed namd from x-ms-identifiers
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
…r/RPSaaSMaster to azure-rest-api-specs/main (Azure#20959)

* Initial commit of microsoft.syntex to RPSaaSMaster branch (Azure#6063)

* Initial commit of microsoft.syntex to RPSaaSMaster branch
- Dev syntex microsoft.syntex 2021 10 20 preview (Azure#5281)
- Aligned resource type names with the guidelines (plural, camelCase)
- Updated provider name in URIs to lower case and provider type to plural camelCase
- Updated examples to match specification
- Updated DocumentProperties with new required fields, added processDocuments request (Azure#5971)
- Changed suffix from -preview to -privatepreview (Azure#6047)
- Corrected description field (Azure#6059)
- Reverted back to -preview from -privatepreview (Azure#6061)

* Added Syntex to custom-words.txt

* Fixed 'Missing required property: meterId'

* Fixed "the 'openapi-subtype' is unset" error

* Fixing Lint(RPaaS) errors:
- x-ms-long-running-operation
- provisioningState

* More Lint(RPaaS) errors:
- x-ms-long-running-operation-options
- provisioningState directly in the properties bag

* ModelValidation: fixed position of provisioningState

* Fixed OneUnderscoreInOperationId LintDiff errors

* Fixing "Resource provider naming must follow the pascal case" errors.

* Fixing systemData error

* Fixed location of the types.json, which is in common-types

* Fixed location of systemData in the DocumentProcessorResource

* Another re-positioning of systemData

* Started referencing the Resource from common-types

* Changed base resource of DocumentProcessorResource from Resource to TrackedResource

* Corrected update example by adding location property

* correctly placed location property in the update request

* Fixed update LintDiff error

* Fixed Delete 204 LintDiff error

* Fixed XmsIdentifierValidation errors

* Fixed operation response

* Fixed errors related to x-ms-pageable

* Fixed duplicate example Operation IDs

* Fixed x-ms-long-running-operation - related error

* Added description field to ResponseStatus

* Fixed a spelling error

* Fixed azure-asyncoperation - related error

* fixed prettier errors

* Addressed feedback from ARM review board meeting (Azure#6107)

* Removed processDocument operation

* Removed DocumentProcessorProperties and ProvisioningState

* Fixed examples after removing DocumentProperties and ProvisioningState

* Removed x-ms-long-running-operation and 201/202 return codes

* Revert "Removed DocumentProcessorProperties and ProvisioningState"

This reverts commit 2e621471a91c6453a2e9a154604a608dbe059ee4.

* Removed processorName property after reverting DocumentProperties back

* Simplified ProvisioningState to have only 2 states to reflect non-async resource creation status

* Removed depricated status codes from the examples

* Made sure that only tags property of the DocumentProcessorResource can be patched.

* Added "Canceled" terminal state per Sanjai's feedback.

* Added a new API version to accommodate a new spoTenantAdminUrl property (Azure#7579)

* copied 2021-10-20 to 2022-06-15

* - Added spoTenantAdminUrl property
- Updated examples and the spec to make sure spoAdminTenantUrl is patchable.
- Fixed prettier errors
- copied 2021-10-20 to 2022-06-15
- corrected API version in 2022-06-15 folder
- Restored 2021-10-20 version to its original state
- made the latest API version a default tag in readme.md
- made spoTenantAdminUrl required in the new API (Azure#7586)
- Fixed required property for spoTenantAdminUrl (Azure#7588)

* Corrected PATCH schema and example (Azure#7601)

* New API version: 2022-09-15-preview (Azure#8815)

* initial copy of 2022-06-15-preview API

* changed API version

* Updated readme.md to incorporate a new version

* Updated resource schema

* removed processDocuments operation, associated types and examples

* Updated examples to match new schema

* Fixed prettier errors

* Removed API versions that we don't want to move from azure-rest-api-specs-pr/RPSaaSMaster to azure-rest-api-specs/main:
- 2021-10-20-preview
- 2022-06-15-preview
Left only 2022-09-15-preview version.

* Added  "x-ms-parameter-location": "method" to fix XmsParameterLocation LintDiff error.

* Tim's feedback:
- Expanded SPO achronym in comments
- Started referencing common-types v3 instead of v2
- Started referencing OperationListResult from common-types v3, removed local OperationsListResult
- Removed systemData from DocumentProcessorResource
- Added provisioningState to Create, Get, and List responses
- Changed capitalization: microsoft.syntex -> Microsoft.Syntex
- Added operation list to the Operations_list.json example

* Fixed prettier errors

* Tim's feedback:
- Added 201 response code for PUT request
- Added an example for 201 PUT response

* Tim's feedback:
- Changed Id -> ID

* Tim's feedback:
- Started using SubscriptionId, ResourceGroupName and ApiVersion parameters from common-types v3

* Tim's feedback
- Fixed casing in resource IDs

* Tim's feedback:
- correciton: patched -> updated

* Tim's feedback:
- Started referencing ErrorResponse from common-types v3

* Tim's feedback:
- Removed namd from x-ms-identifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants