Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Stack] Updates to Azs.Compute.Admin spec for autorest config #9032

Merged
merged 3 commits into from
Jun 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@
"description": "Target virtual machine operating system type necessary for deploying the extension handler.",
"$ref": "PlatformImages.json#/definitions/OsType"
},
"publisher": {
"description": "The publisher of the VM Extension",
"type": "string"
},
"computeRole": {
"description": "Compute role",
"type": "string"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@
{
"$ref": "DiskMigrationJobs.json#/parameters/TargetShareParameter"
},
{
"$ref": "DiskMigrationJobs.json#/parameters/TargetScaleUnitParameter"
},
{
"$ref": "DiskMigrationJobs.json#/parameters/TargetVolumeLabelParameter"
},
{
"$ref": "DiskMigrationJobs.json#/parameters/DiskListParameter"
},
Expand Down Expand Up @@ -378,7 +384,23 @@
"description": "The target share name.",
"name": "targetShare",
"in": "query",
"required": true,
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
"TargetScaleUnitParameter": {
"description": "The target scale unit name.",
"name": "targetScaleUnit",
"in": "query",
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
"TargetVolumeLabelParameter": {
"description": "The target volume label.",
"name": "targetVolumeLabel",
"in": "query",
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
{
"$ref": "Disks.json#/parameters/SourceSharePathParameter"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxyoshine Havent you made this change already to master? you made this only in stackadmin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bganapa I believe they are in master. PR #8747 has been merged.

"$ref": "Disks.json#/parameters/SourceScaleUnitParameter"
},
{
"$ref": "Disks.json#/parameters/SourceVolumeLabelParameter"
},
{
"$ref": "Disks.json#/parameters/DiskCountParameter"
},
Expand Down Expand Up @@ -267,13 +273,29 @@
"x-ms-parameter-location": "method"
},
"SourceSharePathParameter": {
"description": "The source share which the resource belongs to.",
"description": "The share which the resource belongs to.",
"name": "sharePath",
"in": "query",
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
"SourceScaleUnitParameter": {
"description": "The scale unit which the resource belongs to.",
"name": "scaleUnit",
"in": "query",
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
"SourceVolumeLabelParameter": {
"description": "The volume label of the volume which the resource belongs to.",
"name": "volumeLabel",
"in": "query",
"required": false,
"type": "string",
"x-ms-parameter-location": "method"
},
"DiskCountParameter": {
"description": "The maximum number of disks to return.",
"name": "count",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# AutoRest v3 generators

> see https://aka.ms/autorest
``` yaml
input-file:
- Microsoft.Compute.Admin/preview/2015-12-01-preview/Compute.json
- Microsoft.Compute.Admin/preview/2015-12-01-preview/PlatformImages.json
- Microsoft.Compute.Admin/preview/2018-02-09/Quotas.json
- Microsoft.Compute.Admin/preview/2015-12-01-preview/VMExtensions.json
- Microsoft.Compute.Admin/preview/2018-07-30-preview/Disks.json
- Microsoft.Compute.Admin/preview/2018-07-30-preview/DiskMigrationJobs.json
```
36 changes: 10 additions & 26 deletions specification/azsadmin/resource-manager/compute/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,16 @@ csharp:
clear-output-folder: true
```

## Multi-API/Profile support for AutoRest v3 generators
# AutoRest v3 generators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to change this part i think


AutoRest V3 generators require the use of `--tag=all-api-versions` to select api files.

This block is updated by an automatic script. Edits may be lost!

``` yaml $(tag) == 'all-api-versions' /* autogenerated */
# include the azure profile definitions from the standard location
require: $(this-folder)/../../../../profiles/readme.md

# all the input files across all versions
input-file:
- $(this-folder)/Microsoft.Compute.Admin/preview/2015-12-01-preview/Compute.json
- $(this-folder)/Microsoft.Compute.Admin/preview/2015-12-01-preview/PlatformImages.json
- $(this-folder)/Microsoft.Compute.Admin/preview/2018-02-09/Quotas.json
- $(this-folder)/Microsoft.Compute.Admin/preview/2015-12-01-preview/VMExtensions.json
- $(this-folder)/Microsoft.Compute.Admin/preview/2018-07-30-preview/Disks.json
- $(this-folder)/Microsoft.Compute.Admin/preview/2018-07-30-preview/DiskMigrationJobs.json

```

If there are files that should not be in the `all-api-versions` set,
uncomment the `exclude-file` section below and add the file paths.
> see https://aka.ms/autorest

``` yaml $(tag) == 'all-api-versions'
#exclude-file:
# - $(this-folder)/Microsoft.Example/stable/2010-01-01/somefile.json
``` yaml
input-file:
- Microsoft.Compute.Admin/preview/2015-12-01-preview/Compute.json
- Microsoft.Compute.Admin/preview/2015-12-01-preview/PlatformImages.json
- Microsoft.Compute.Admin/preview/2018-02-09/Quotas.json
- Microsoft.Compute.Admin/preview/2015-12-01-preview/VMExtensions.json
- Microsoft.Compute.Admin/preview/2018-07-30-preview/Disks.json
- Microsoft.Compute.Admin/preview/2018-07-30-preview/DiskMigrationJobs.json
```