Add nvaSku property for NetworkVirtualAppliance #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2020-05-01
…rest-api-specs into network-may-release
naveenchekuri
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureData/sqlServerInstances' removed or restructured? Old: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L898:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/invoices/{invoiceName}' removed or restructured? Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L1646:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.StorageCache/locations/{location}/ascOperations/{operationId}' removed or restructured? Old: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L161:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AppPlatform/skus' removed or restructured? Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2163:5 |
|
The new version is missing a path that was found in the old version. Was path '/devices/{device_id}/modules/{module_name}/components/{component_name}/telemetry/{telemetry_name}' removed or restructured? Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2157:5 |
|
The new version is missing a path that was found in the old version. Was path '/devices/{device_id}/modules/{module_name}/components/{component_name}/properties' removed or restructured? Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2069:5 |
|
The new version is missing a path that was found in the old version. Was path '/devices/{device_id}/modules/{module_name}/properties' removed or restructured? Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L2012:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Storage.Admin/storageServices' removed or restructured? Old: Microsoft.Storage.Admin/preview/2019-08-08/storage.json#L94:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}resourceGroups/{resourceGroup}/providers/Microsoft.Storage.Admin/storageServices/{serviceName}' removed or restructured? Old: Microsoft.Storage.Admin/preview/2019-08-08/storage.json#L169:5 |
|
The new version is missing a path that was found in the old version. Was path '/devices/{device_id}/modules/{module_name}/components/{component_name}/commands/{command_name}' removed or restructured? Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L1817:5 |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
naveenchekuri
changed the title
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mmyyrroonn
approved these changes
Jun 3, 2020
pilor
reviewed
Jun 3, 2020
...on/network/resource-manager/Microsoft.Network/stable/2020-05-01/networkVirtualAppliance.json
Show resolved
Hide resolved
pilor
added
ARMChangesRequested
pilor
approved these changes
Jun 3, 2020
anton-evseev
approved these changes
Jun 4, 2020
|
@myronfanqiu could you please merge? |
mmyyrroonn
approved these changes
Jun 7, 2020
mmyyrroonn
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (#9394) * Move terminateTLS flag to ApplicationRuleCondition (#9539) * DNS Proxy support for Firewall Policy (#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (#9369) (#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * Add nvaSku property for NetworkVirtualAppliance (#9682) * code fixes for hubIPAddresses (#9775) * Fix lint errors (#9787) Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (Azure#9357) * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Final changes * Fix formatting issues * Fix merge and formatting issues * Fix formatiing * Ipconfig properties * Fix build errors * Lint check * Fix semantics errors * Address review comments * Fix prettier and nextLink checks * Fix dots * Address errors * Fix Ipconfig version Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> * Change NRP repo for validation scripts (Azure#9394) * Move terminateTLS flag to ApplicationRuleCondition (Azure#9539) * DNS Proxy support for Firewall Policy (Azure#9461) * Adding DnsProxySettings Support in Firewall Policy dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties. * spell check * Removing DNS as prefix on sub properties. * Syntax error. * DnsProxySettings to DNSSettings * Fixing proxy settings name. Co-authored-by: Ishani Gupta <isgu@microsoft.com> * fix network (Azure#9369) (Azure#9547) * fix network * duplicated publicipprefix * fixed example in 2018-01-01 * final updates * missing examples (cherry picked from commit 42d9639) * Added new properties to ConnectivityHop (Azure#9386) * Added new properties to ConnectivityHop * Fixed spelling * added x-ms-client-flatten to HopLink.properties.properties * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (Azure#9356) * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup * rebase with ti whitelist * rebase with ti whitelist * rebase with ti whitelist * prettier run * making nat rule into a collection * prettier run * Multiple Public IPs support for Azure Firewall in Virtual Hub (Azure#9560) * multi pip for firewall in hub swagger change * resolving issues * VirtualWan: Hubvnet Connection related changes (Azure#9536) 1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the API expected to be used in the future by all consumers (direct rest api calls, powershell, portal, azure cli). This avoids needing a put on the virtual hub every time a hubvnet connection is to be added/changed. 2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to avoid having multiple APIs to do the same thing. Also having this API introduces other complexities and breaks some scenarios. 3. Deprecate allowHubToRemoteVnetTransit and allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection. These flags are maintained internally in the implementation and shouldn't be exposed to the user. For now, just mark it as such. Will be removed in later release. Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> * Destination FQDNs in FirewallPolicy for network rules. (Azure#9609) * v1 * making boolean as nullable Co-authored-by: Ishani Gupta <isgu@microsoft.com> * VirtualHub : Add Routing State and expose Effective Routes Api (Azure#9385) * Add Routing State and expose Effective Routes Api * updated opId name and added examples * prettier fix done * rename variable to prevent conflict * Updating VpnGateway examples for bgpSettings (Azure#9656) * Updating VpnGateway examples * prettier Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Application Gateway Private Link Support (Azure#9490) * Application Gateway Private Link Support * Fix comments * Fix comments for including example * Add nvaSku property for NetworkVirtualAppliance (Azure#9682) * code fixes for hubIPAddresses (Azure#9775) * Fix lint errors (Azure#9787) Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: dexiang-ms <64503627+dexiang-ms@users.noreply.github.com> Co-authored-by: odedlaz <odedlaz@users.noreply.github.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Zim Kalinowski <zikalino@microsoft.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com> Co-authored-by: Anchal Kapoor <anchalka@usc.edu> Co-authored-by: shyamshd <64368451+shyamshd@users.noreply.github.com> Co-authored-by: Shyam Dharmarajan <shdharma@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.