Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing read only property to allow update operations as per the actual implementation #9874

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Removing read only property to allow update operations as per the actual implementation #9874

merged 5 commits into from
Jun 25, 2020

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Jun 17, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Anirban Sarkar added 4 commits May 29, 2020 23:44
…oad operations

Correcting the swagger to accept downloadToken similar to other download operations
…pis. IT is already part of the examples.

Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples.
Removing reonly property to allow update operations
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 17, 2020

[Staging] Swagger Validation Report

~[Staging] BreakingChange: 10 Errors, 0 Warnings [Detail][Expand Details]
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5711:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5715:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5690:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5690:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5694:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5695:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5698:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5700:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5707:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5710:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5711:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5715:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5690:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5690:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5694:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5695:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5698:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5700:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/stable/2020-05-01/billing.json#L5707:9
Old: Microsoft.Billing/stable/2020-05-01/billing.json#L5710:9
Posted by Swagger Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@asarkar84 asarkar84 changed the title Removing read only property to allow update operations Removing read only property to allow update operations as per the actual implementation Jun 17, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6255575 with merge commit 5e3fc2e. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/billing/mgmt-v2017_02_27_preview [View full logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2017_04_24_preview [View full logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2018_03_01_preview [View full logs]  [Release SDK Changes]
  • ⚠️sdk/billing/mgmt-v2018_11_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
      [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
      [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
      [mvn]   reason: cannot infer type-variable(s) T,THeader
      [mvn]     (actual and formal argument lists differ in length)
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
      [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
      [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
      [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
      [mvn] [ERROR]     (actual and formal argument lists differ in length)
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/billing/mgmt-v2019_10_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn]   reason: cannot infer type-variable(s) T,THeader
        [mvn]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn]   reason: cannot infer type-variable(s) T,THeader
        [mvn]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
        [mvn] [ERROR]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
        [mvn] [ERROR]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/billing/mgmt-v2020_05_01 [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[613,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn]   reason: cannot infer type-variable(s) T,THeader
          [mvn]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[975,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn]   reason: cannot infer type-variable(s) T,THeader
          [mvn]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[613,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
          [mvn] [ERROR]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[975,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
          [mvn] [ERROR]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 17, 2020

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 6255575 with merge commit 5e3fc2e. SDK Automation 13.0.17.20200619.4
        • ️✔️azure-mgmt-billing [View full logs]  [Release SDK Changes]
          [build_conf] INFO:packaging_tools:Building template azure-mgmt-billing
          [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          [build_conf] INFO:packaging_tools:Template done azure-mgmt-billing
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
          [ChangeLog] Traceback (most recent call last):
          [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
          [ChangeLog]     "__main__", mod_spec)
          [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
          [ChangeLog]     exec(code, run_globals)
          [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
          [ChangeLog]     change_log = build_change_log(old_report, new_report)
          [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
          [ChangeLog]     change_log.operation(diff_line)
          [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
          [ChangeLog]     _, operation_name, *remaining_path = path
          [ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
          [ChangeLog] Size of delta 98.456% size of original (original: 68071 chars, delta: 67020 chars)

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 17, 2020

        azure-sdk-for-net - Release

        ️✔️ succeeded [Logs] [Expand Details]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 17, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 6255575 with merge commit 5e3fc2e. SDK Automation 13.0.17.20200619.4
        • ️✔️@azure/arm-billing [View full logs]  [Release SDK Changes]
          Only show 100 items here, please refer to log for details.
          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
          [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
          [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
          [npmPack] created ./dist/arm-billing.js in 605ms
          [npmPack] npm notice 
          [npmPack] npm notice package: @azure/arm-billing@2.2.0
          [npmPack] npm notice === Tarball Contents === 
          [npmPack] npm notice 1.8kB   esm/operations/address.js                           
          [npmPack] npm notice 460B    esm/models/addressMappers.js                        
          [npmPack] npm notice 3.5kB   esm/operations/agreements.js                        
          [npmPack] npm notice 937B    esm/models/agreementsMappers.js                     
          [npmPack] npm notice 274.9kB dist/arm-billing.js                                 
          [npmPack] npm notice 98.9kB  dist/arm-billing.min.js                             
          [npmPack] npm notice 1.9kB   esm/operations/availableBalances.js                 
          [npmPack] npm notice 923B    esm/models/availableBalancesMappers.js              
          [npmPack] npm notice 7.4kB   esm/operations/billingAccounts.js                   
          [npmPack] npm notice 1.1kB   esm/models/billingAccountsMappers.js                
          [npmPack] npm notice 2.7kB   esm/billingManagementClient.js                      
          [npmPack] npm notice 2.6kB   esm/billingManagementClientContext.js               
          [npmPack] npm notice 8.1kB   esm/operations/billingPermissions.js                
          [npmPack] npm notice 490B    esm/models/billingPermissionsMappers.js             
          [npmPack] npm notice 6.4kB   esm/operations/billingProfiles.js                   
          [npmPack] npm notice 985B    esm/models/billingProfilesMappers.js                
          [npmPack] npm notice 2.8kB   esm/operations/billingPropertyOperations.js         
          [npmPack] npm notice 931B    esm/models/billingPropertyOperationsMappers.js      
          [npmPack] npm notice 13.6kB  esm/operations/billingRoleAssignments.js            
          [npmPack] npm notice 961B    esm/models/billingRoleAssignmentsMappers.js         
          [npmPack] npm notice 10.0kB  esm/operations/billingRoleDefinitions.js            
          [npmPack] npm notice 961B    esm/models/billingRoleDefinitionsMappers.js         
          [npmPack] npm notice 14.3kB  esm/operations/billingSubscriptions.js              
          [npmPack] npm notice 1.1kB   esm/models/billingSubscriptionsMappers.js           
          [npmPack] npm notice 5.3kB   esm/operations/customers.js                         
          [npmPack] npm notice 935B    esm/models/customersMappers.js                      
          [npmPack] npm notice 345B    esm/models/index.js                                 
          [npmPack] npm notice 964B    esm/operations/index.js                             
          [npmPack] npm notice 5.0kB   esm/operations/instructions.js                      
          [npmPack] npm notice 941B    esm/models/instructionsMappers.js                   
          [npmPack] npm notice 13.8kB  esm/operations/invoices.js                          
          [npmPack] npm notice 6.9kB   esm/operations/invoiceSections.js                   
          [npmPack] npm notice 985B    esm/models/invoiceSectionsMappers.js                
          [npmPack] npm notice 1.0kB   esm/models/invoicesMappers.js                       
          [npmPack] npm notice 87.9kB  esm/models/mappers.js                               
          [npmPack] npm notice 2.3kB   esm/operations/operations.js                        
          [npmPack] npm notice 472B    esm/models/operationsMappers.js                     
          [npmPack] npm notice 4.6kB   esm/models/parameters.js                            
          [npmPack] npm notice 5.2kB   esm/operations/policies.js                          
          [npmPack] npm notice 914B    esm/models/policiesMappers.js                       
          [npmPack] npm notice 12.5kB  esm/operations/products.js                          
          [npmPack] npm notice 1.1kB   esm/models/productsMappers.js                       
          [npmPack] npm notice 983B    rollup.config.js                                    
          [npmPack] npm notice 2.6kB   esm/operations/transactions.js                      
          [npmPack] npm notice 941B    esm/models/transactionsMappers.js                   
          [npmPack] npm notice 1.6kB   package.json                                        
          [npmPack] npm notice 457B    tsconfig.json                                       
          [npmPack] npm notice 751B    esm/operations/address.d.ts.map                     
          [npmPack] npm notice 1.0kB   esm/operations/address.js.map                       
          [npmPack] npm notice 206B    esm/models/addressMappers.d.ts.map                  
          [npmPack] npm notice 219B    esm/models/addressMappers.js.map                    
          [npmPack] npm notice 1.6kB   esm/operations/agreements.d.ts.map                  
          [npmPack] npm notice 2.1kB   esm/operations/agreements.js.map                    
          [npmPack] npm notice 552B    esm/models/agreementsMappers.d.ts.map               
          [npmPack] npm notice 565B    esm/models/agreementsMappers.js.map                 
          [npmPack] npm notice 636.3kB dist/arm-billing.js.map                             
          [npmPack] npm notice 78.5kB  dist/arm-billing.min.js.map                         
          [npmPack] npm notice 819B    esm/operations/availableBalances.d.ts.map           
          [npmPack] npm notice 1.1kB   esm/operations/availableBalances.js.map             
          [npmPack] npm notice 553B    esm/models/availableBalancesMappers.d.ts.map        
          [npmPack] npm notice 566B    esm/models/availableBalancesMappers.js.map          
          [npmPack] npm notice 2.5kB   esm/operations/billingAccounts.d.ts.map             
          [npmPack] npm notice 3.9kB   esm/operations/billingAccounts.js.map               
          [npmPack] npm notice 601B    esm/models/billingAccountsMappers.d.ts.map          
          [npmPack] npm notice 614B    esm/models/billingAccountsMappers.js.map            
          [npmPack] npm notice 1.3kB   esm/billingManagementClient.d.ts.map                
          [npmPack] npm notice 1.8kB   esm/billingManagementClient.js.map                  
          [npmPack] npm notice 512B    esm/billingManagementClientContext.d.ts.map         
          [npmPack] npm notice 1.4kB   esm/billingManagementClientContext.js.map           
          [npmPack] npm notice 3.7kB   esm/operations/billingPermissions.d.ts.map          
          [npmPack] npm notice 4.8kB   esm/operations/billingPermissions.js.map            
          [npmPack] npm notice 231B    esm/models/billingPermissionsMappers.d.ts.map       
          [npmPack] npm notice 244B    esm/models/billingPermissionsMappers.js.map         
          [npmPack] npm notice 2.0kB   esm/operations/billingProfiles.d.ts.map             
          [npmPack] npm notice 3.2kB   esm/operations/billingProfiles.js.map               
          [npmPack] npm notice 575B    esm/models/billingProfilesMappers.d.ts.map          
          [npmPack] npm notice 588B    esm/models/billingProfilesMappers.js.map            
          [npmPack] npm notice 999B    esm/operations/billingPropertyOperations.d.ts.map   
          [npmPack] npm notice 1.6kB   esm/operations/billingPropertyOperations.js.map     
          [npmPack] npm notice 569B    esm/models/billingPropertyOperationsMappers.d.ts.map
          [npmPack] npm notice 582B    esm/models/billingPropertyOperationsMappers.js.map  
          [npmPack] npm notice 6.0kB   esm/operations/billingRoleAssignments.d.ts.map      
          [npmPack] npm notice 7.5kB   esm/operations/billingRoleAssignments.js.map        
          [npmPack] npm notice 576B    esm/models/billingRoleAssignmentsMappers.d.ts.map   
          [npmPack] npm notice 589B    esm/models/billingRoleAssignmentsMappers.js.map     
          [npmPack] npm notice 4.4kB   esm/operations/billingRoleDefinitions.d.ts.map      
          [npmPack] npm notice 5.6kB   esm/operations/billingRoleDefinitions.js.map        

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 17, 2020

        azure-sdk-for-python-track2 - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 17, 2020

        Trenton Generation - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @asarkar84
        Copy link
        Contributor Author

        asarkar84 commented Jun 17, 2020

        @njuCZ We have just checked in the 2020-05-01 version of swagger couple of weeks back and realized that it has a mistake where we are setting the read only property for some editable fields.
        Please note that none of these APIs (version 2020-05-01) are live yet. No one can use this version so it will not break any existing scenario.
        Please approve the this breaking change this time.

        @azuresdkci
        Copy link
        Contributor

        Can one of the admins verify this patch?

        @njuCZ njuCZ added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 18, 2020
        @njuCZ
        Copy link
        Contributor

        njuCZ commented Jun 18, 2020

        /azp run

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 3 pipeline(s).

        @asarkar84
        Copy link
        Contributor Author

        @njuCZ Do we need ARM review for this change? We do not have even these APIs live yet.

        @njuCZ
        Copy link
        Contributor

        njuCZ commented Jun 19, 2020

        @asarkar84 yes, we still need ARM team review it

        @ravbhatnagar ravbhatnagar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 23, 2020
        @ravbhatnagar
        Copy link
        Contributor

        Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward.

        @asarkar84
        Copy link
        Contributor Author

        @njuCZ This does not required ARM feedback as mentioned by ARM team. Can you please merge this PR.

        @asarkar84
        Copy link
        Contributor Author

        @njuCZ Please take a look.

        @akning-ms akning-ms merged commit 5e3fc2e into Azure:master Jun 25, 2020
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        …ual implementation (Azure#9874)
        
        * Correcting the swagger to accept downloadToken similar to other download operations
        
        Correcting the swagger to accept downloadToken similar to other download operations
        
        * Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples.
        
        Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples.
        
        * Removing reonly property to allow update operations
        
        Removing reonly property to allow update operations
        
        Co-authored-by: Anirban Sarkar <ansar@microsoft.com>
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        5 participants