[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9979

liranc · 2020-06-28T09:26:23Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for AME onboarding.
Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-06-28T09:26:27Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-06-28T09:26:39Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-28T09:28:05Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9ab47c0 with merge commit 27aebdc. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.2.1.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.2.1.0.snupkg

openapi-sdkautomation · 2020-06-28T09:28:05Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-28T09:28:05Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9ab47c0 with merge commit 27aebdc. SDK Automation 13.0.17.20200619.4

️✔️azure-mgmt-security [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-security
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-security
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 13.981% size of original (original: 158864 chars, delta: 22210 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group SecuritySolutionsOperations
[ChangeLog]   - Added operation group IotAlertsOperations
[ChangeLog]   - Added operation group IotRecommendationTypesOperations
[ChangeLog]   - Added operation group IotAlertTypesOperations
[ChangeLog]   - Added operation group SecuritySolutionsReferenceDataOperations
[ChangeLog]   - Added operation group ConnectorsOperations
[ChangeLog]   - Added operation group IotRecommendationsOperations

openapi-sdkautomation · 2020-06-28T09:28:06Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9ab47c0 with merge commit 27aebdc. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-security [View full logs] [Release SDK Changes]

azure-arm-security-2.0.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
[npmPack] created ./dist/arm-security.js in 1.1s
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-security@2.0.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 4.8kB   esm/operations/adaptiveApplicationControls.js                          
[npmPack] npm notice 634B    esm/models/adaptiveApplicationControlsMappers.js                       
[npmPack] npm notice 7.9kB   esm/operations/adaptiveNetworkHardenings.js                            
[npmPack] npm notice 3.1kB   esm/models/adaptiveNetworkHardeningsMappers.js                         
[npmPack] npm notice 3.0kB   esm/operations/advancedThreatProtection.js                             
[npmPack] npm notice 3.0kB   esm/models/advancedThreatProtectionMappers.js                          
[npmPack] npm notice 13.7kB  esm/operations/alerts.js                                               
[npmPack] npm notice 3.0kB   esm/models/alertsMappers.js                                            
[npmPack] npm notice 5.5kB   esm/operations/alertsSuppressionRules.js                               
[npmPack] npm notice 3.0kB   esm/models/alertsSuppressionRulesMappers.js                            
[npmPack] npm notice 5.0kB   esm/operations/allowedConnections.js                                   
[npmPack] npm notice 521B    esm/models/allowedConnectionsMappers.js                                
[npmPack] npm notice 717.3kB dist/arm-security.js                                                   
[npmPack] npm notice 279.4kB dist/arm-security.min.js                                               
[npmPack] npm notice 5.3kB   esm/operations/assessments.js                                          
[npmPack] npm notice 3.0kB   esm/models/assessmentsMappers.js                                       
[npmPack] npm notice 7.7kB   esm/operations/assessmentsMetadata.js                                  
[npmPack] npm notice 3.0kB   esm/models/assessmentsMetadataMappers.js                               
[npmPack] npm notice 8.3kB   esm/operations/automations.js                                          
[npmPack] npm notice 672B    esm/models/automationsMappers.js                                       
[npmPack] npm notice 4.4kB   esm/operations/autoProvisioningSettings.js                             
[npmPack] npm notice 3.0kB   esm/models/autoProvisioningSettingsMappers.js                          
[npmPack] npm notice 3.3kB   esm/operations/complianceResults.js                                    
[npmPack] npm notice 3.0kB   esm/models/complianceResultsMappers.js                                 
[npmPack] npm notice 3.2kB   esm/operations/compliances.js                                          
[npmPack] npm notice 3.0kB   esm/models/compliancesMappers.js                                       
[npmPack] npm notice 5.1kB   esm/operations/connectors.js                                           
[npmPack] npm notice 3.0kB   esm/models/connectorsMappers.js                                        
[npmPack] npm notice 5.6kB   esm/operations/deviceSecurityGroups.js                                 
[npmPack] npm notice 3.0kB   esm/models/deviceSecurityGroupsMappers.js                              
[npmPack] npm notice 5.3kB   esm/operations/discoveredSecuritySolutions.js                          
[npmPack] npm notice 498B    esm/models/discoveredSecuritySolutionsMappers.js                       
[npmPack] npm notice 5.3kB   esm/operations/externalSecuritySolutions.js                            
[npmPack] npm notice 704B    esm/models/externalSecuritySolutionsMappers.js                         
[npmPack] npm notice 345B    esm/models/index.js                                                    
[npmPack] npm notice 2.1kB   esm/operations/index.js                                                
[npmPack] npm notice 4.9kB   esm/operations/informationProtectionPolicies.js                        
[npmPack] npm notice 3.0kB   esm/models/informationProtectionPoliciesMappers.js                     
[npmPack] npm notice 3.8kB   esm/operations/iotAlerts.js                                            
[npmPack] npm notice 444B    esm/models/iotAlertsMappers.js                                         
[npmPack] npm notice 3.0kB   esm/operations/iotAlertTypes.js                                        
[npmPack] npm notice 3.0kB   esm/models/iotAlertTypesMappers.js                                     
[npmPack] npm notice 3.9kB   esm/operations/iotRecommendations.js                                   
[npmPack] npm notice 3.0kB   esm/models/iotRecommendationsMappers.js                                
[npmPack] npm notice 3.2kB   esm/operations/iotRecommendationTypes.js                               
[npmPack] npm notice 3.0kB   esm/models/iotRecommendationTypesMappers.js                            
[npmPack] npm notice 8.9kB   esm/operations/iotSecuritySolution.js                                  
[npmPack] npm notice 3.1kB   esm/operations/iotSecuritySolutionAnalytics.js                         
[npmPack] npm notice 3.0kB   esm/models/iotSecuritySolutionAnalyticsMappers.js                      
[npmPack] npm notice 598B    esm/models/iotSecuritySolutionMappers.js                               
[npmPack] npm notice 5.3kB   esm/operations/iotSecuritySolutionsAnalyticsAggregatedAlert.js         
[npmPack] npm notice 571B    esm/models/iotSecuritySolutionsAnalyticsAggregatedAlertMappers.js      
[npmPack] npm notice 4.3kB   esm/operations/iotSecuritySolutionsAnalyticsRecommendation.js          
[npmPack] npm notice 532B    esm/models/iotSecuritySolutionsAnalyticsRecommendationMappers.js       
[npmPack] npm notice 12.6kB  esm/operations/jitNetworkAccessPolicies.js                             
[npmPack] npm notice 767B    esm/models/jitNetworkAccessPoliciesMappers.js                          
[npmPack] npm notice 3.1kB   esm/operations/locations.js                                            
[npmPack] npm notice 3.0kB   esm/models/locationsMappers.js                                         
[npmPack] npm notice 208.1kB esm/models/mappers.js                                                  
[npmPack] npm notice 2.2kB   esm/operations/operations.js                                           
[npmPack] npm notice 465B    esm/models/operationsMappers.js                                        
[npmPack] npm notice 17.4kB  esm/models/parameters.js                                               
[npmPack] npm notice 3.4kB   esm/operations/pricings.js                                             
[npmPack] npm notice 3.0kB   esm/models/pricingsMappers.js                                          
[npmPack] npm notice 4.5kB   esm/operations/regulatoryComplianceAssessments.js                      
[npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceAssessmentsMappers.js                   
[npmPack] npm notice 4.0kB   esm/operations/regulatoryComplianceControls.js                         
[npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceControlsMappers.js                      
[npmPack] npm notice 3.6kB   esm/operations/regulatoryComplianceStandards.js                        
[npmPack] npm notice 3.0kB   esm/models/regulatoryComplianceStandardsMappers.js                     
[npmPack] npm notice 976B    rollup.config.js                                                       
[npmPack] npm notice 4.1kB   esm/operations/secureScoreControlDefinitions.js                        
[npmPack] npm notice 3.0kB   esm/models/secureScoreControlDefinitionsMappers.js                     
[npmPack] npm notice 4.2kB   esm/operations/secureScoreControls.js                                  
[npmPack] npm notice 3.0kB   esm/models/secureScoreControlsMappers.js                               
[npmPack] npm notice 3.2kB   esm/operations/secureScores.js                                         
[npmPack] npm notice 3.0kB   esm/models/secureScoresMappers.js                                      
[npmPack] npm notice 5.1kB   esm/securityCenter.js                                                  
[npmPack] npm notice 2.7kB   esm/securityCenterContext.js                                           
[npmPack] npm notice 6.3kB   esm/operations/securityContacts.js                                     
[npmPack] npm notice 3.0kB   esm/models/securityContactsMappers.js                                  
[npmPack] npm notice 3.5kB   esm/operations/securitySolutions.js                                    
[npmPack] npm notice 468B    esm/models/securitySolutionsMappers.js                                 
[npmPack] npm notice 2.8kB   esm/operations/securitySolutionsReferenceDataOperations.js             
[npmPack] npm notice 519B    esm/models/securitySolutionsReferenceDataOperationsMappers.js          
[npmPack] npm notice 6.5kB   esm/operations/serverVulnerabilityAssessmentOperations.js              
[npmPack] npm notice 3.0kB   esm/models/serverVulnerabilityAssessmentOperationsMappers.js

openapi-sdkautomation · 2020-06-28T09:28:09Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-28T09:28:09Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 9ab47c0 with merge commit 27aebdc. SDK Automation 13.0.17.20200619.4
️✔️preview/security/mgmt/v1.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v1.0.zip
️✔️preview/security/mgmt/v2.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v2.0.zip
️✔️preview/security/mgmt/v3.0 [View full logs] [Release SDK Changes]
- preview.security.mgmt.v3.0.zip

openapi-sdkautomation · 2020-06-28T09:28:10Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-06-28T09:33:18Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-28T09:34:43Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-06-28T09:48:02Z

Can one of the admins verify this patch?

azure-pipelines · 2020-06-28T13:09:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-29T14:42:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-02T10:09:56Z

Azure Pipelines successfully started running 1 pipeline(s).

specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotAlertTypes.json

...ation/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotRecommendations.json

azure-pipelines · 2020-07-12T04:38:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-21T05:53:37Z

Azure Pipelines successfully started running 1 pipeline(s).

...ation/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotRecommendations.json

adrianhall · 2020-07-21T22:07:23Z

Per email discussion with Azure API Review Board - Exception from policy is granted, and changes are APPROVED without a version bump.

In the future, additive / evolutionary changes will require a version bump.

azure-pipelines · 2020-07-22T05:59:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-22T06:17:54Z

Azure Pipelines successfully started running 1 pipeline(s).

liranc · 2020-07-23T05:29:35Z

@pilor @adrianhall Thanks for reviewing! Could you please merge the PR?

pilor · 2020-07-23T17:16:31Z

@pilor @adrianhall Thanks for reviewing! Could you please merge the PR?

See step 8+ here: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html

liranc · 2020-07-24T04:55:11Z

See step 8+ here: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html

@pilor are there remaining comments/issues? As far as I understand steps 8+ are mostly about addressing feedback.

…stable/2019-08-01 (Azure#9979) * recos * Remove system id * spellcheck * dataSource * Rename category to control * remove provider, add couple of other fields * productName/compnent * Inherit from resource, update example * Prettier Co-authored-by: Liran Chen <lirche@microsoft.com>

Liran Chen added 3 commits June 24, 2020 16:06

recos

d8920a1

Remove system id

cfe6d80

Merge branch 'master' into recommendations-2019-08-01

1717013

openapi-assignment-bot bot assigned zikalino Jun 28, 2020

spellcheck

e37499d

openapi-sdkautomation bot mentioned this pull request Jun 28, 2020

[AutoPR @azure/arm-security] [Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 AzureSDKAutomation/azure-sdk-for-js#1481

Closed

dataSource

f4907b7

Rename category to control

9a1f551

liranc added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 30, 2020

Liran Chen added 2 commits July 2, 2020 13:05

Merge branch 'master' into recommendations-2019-08-01

70b26ad

remove provider, add couple of other fields

2826cb7

Liran Chen added 2 commits July 5, 2020 09:11

Merge branch 'master' into recommendations-2019-08-01

2abbe5e

productName/compnent

6a131ac

majastrz reviewed Jul 6, 2020

View reviewed changes

specification/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotAlertTypes.json Show resolved Hide resolved

majastrz reviewed Jul 6, 2020

View reviewed changes

...ation/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotRecommendations.json Show resolved Hide resolved

majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 6, 2020

liranc added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 7, 2020

Merge branch 'master' into recommendations-2019-08-01

c74bd5e

Merge branch 'master' into recommendations-2019-08-01

db11359

pilor suggested changes Jul 21, 2020

View reviewed changes

...ation/security/resource-manager/Microsoft.Security/stable/2019-08-01/iotRecommendations.json Show resolved Hide resolved

liranc removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 22, 2020

Liran Chen added 2 commits July 22, 2020 08:16

Merge branch 'master' into recommendations-2019-08-01

c7efe01

Inherit from resource, update example

ac22974

Prettier

9ab47c0

liranc requested a review from pilor July 22, 2020 07:20

pilor approved these changes Jul 22, 2020

View reviewed changes

akning-ms assigned akning-ms and unassigned zikalino Jul 24, 2020

akning-ms added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 SuppressionTrack Track suppression in PR labels Jul 24, 2020

akning-ms merged commit 27aebdc into Azure:master Jul 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9979

[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9979

liranc commented Jun 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 28, 2020 •

edited

Loading

azure-pipelines bot commented Jun 28, 2020

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

azure-pipelines bot commented Jun 28, 2020

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

azuresdkci commented Jun 28, 2020

azure-pipelines bot commented Jun 28, 2020

azure-pipelines bot commented Jun 29, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 12, 2020

azure-pipelines bot commented Jul 21, 2020

adrianhall commented Jul 21, 2020

azure-pipelines bot commented Jul 22, 2020

azure-pipelines bot commented Jul 22, 2020

liranc commented Jul 23, 2020

pilor commented Jul 23, 2020

liranc commented Jul 24, 2020

[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9979

[Hub Generated] Review request for Microsoft.Security to add version stable/2019-08-01 #9979

Conversation

liranc commented Jun 28, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jun 28, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 28, 2020

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

Trenton Generation - Release

azure-pipelines bot commented Jun 28, 2020

openapi-sdkautomation bot commented Jun 28, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azuresdkci commented Jun 28, 2020

azure-pipelines bot commented Jun 28, 2020

azure-pipelines bot commented Jun 29, 2020

azure-pipelines bot commented Jul 2, 2020

azure-pipelines bot commented Jul 12, 2020

azure-pipelines bot commented Jul 21, 2020

adrianhall commented Jul 21, 2020

azure-pipelines bot commented Jul 22, 2020

azure-pipelines bot commented Jul 22, 2020

liranc commented Jul 23, 2020

pilor commented Jul 23, 2020

liranc commented Jul 24, 2020

liranc commented Jun 28, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 28, 2020 •

edited

Loading