Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] sdk/resourcemanager/authorization/armauthorization/2.0.0 #18890

Conversation

Alancere
Copy link
Member

@Alancere Alancere commented Aug 17, 2022

…neration from spec commit: 53b1affe357b3bfbb53721d0a2002382a046d3b0
@tadelesh
Copy link
Member

Wait for .Net authorization GA.

Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 releases are painful for customers. We want to keep this on the v1.x path.

@tadelesh
Copy link
Member

v2 releases are painful for customers. We want to keep this on the v1.x path.

The breakings contain required param removal, property ref change and operation removal from swagger. I don't think it is possible to make it 1.x.

@mblaschke-daimlertruck
Copy link

Any progress here? Is there a way to get this merged in the next days?

@tadelesh
Copy link
Member

tadelesh commented Sep 1, 2022

@RickWinter, @JeffreyRichter, @jhendrixMSFT I've used directive to mitigate most of the breakings. Only one orphan model deletion left. I think it could be ignored regarding it will not break customer. You could see the new generated SDK here and directive here. Could you help to confirm whether we could release it with 1.1.0?

@JeffreyRichter
Copy link
Member

Joel & I spoke about this today. Here's where we're at...
It is a reality today that swaggers have bugs, we generate a client and then the swagger gets fixed causing a breaking change in the client (even though the service itself has not changed).

So, if we ship a client V1.0.0 and then the swagger gets fixed, we ship a new client V1.0.1.
Now, let's say an app uses V1.0.1 and also uses another package that depends on V1.0.0 - the app can't build now because V1.0.0 & V1.0.1 can't be compiled together into a single app - this is a very bad place for a customer to be and so we can't do this and put them there.

So, any client library break must be done in a new major version so that the new major and old major can be compiled together into a single app.

Obviously, the best thing for us (service team and SDK teams) to do is to better validate our swaggers and fix bugs before we create and ship client libraries.

@mblaschke
Copy link

Any progress here?

@tadelesh
Copy link
Member

Any progress here?

We are double confirming with service team and will release the new version soon.

@tadelesh
Copy link
Member

@RickWinter Please sign off. .NET has released package-2022-04-01 as stable and we also got confirmation from service team to release Go SDK.

@tadelesh
Copy link
Member

@tadelesh
Copy link
Member

tadelesh commented Sep 23, 2022

All the breaking changes is from this PR and approved in this PR.

  1. Function *RoleAssignmentsClient.NewListForResourcePager parameter(s) have been changed from (string, string, string, string, string, *RoleAssignmentsClientListForResourceOptions) to (string, string, string, string, *RoleAssignmentsClientListForResourceOptions)
    New swagger here. Previous swagger here. This operation's path params have been changed.
  2. Type of RoleAssignment.Properties has been changed from *RoleAssignmentPropertiesWithScope to *RoleAssignmentProperties
    Struct RoleAssignmentPropertiesWithScope has been removed
    New swagger here. Previous swagger here. Properties of RoleAssignment model has been changed.
  3. Function *RoleAssignmentsClient.NewListPager has been removed
    Struct RoleAssignmentsClientListOptions has been removed
    Struct RoleAssignmentsClientListResponse has been removed
    New swagger here. Previous swagger here. An operation has been renamed.
  4. Struct PermissionAutoGenerated has been removed
    New swagger here. Previous swagger here. Permission model for RoleDefinitions has been changed to align with other Permission definition.

@tadelesh
Copy link
Member

@jhendrixMSFT @RickWinter @JeffreyRichter I list all the breakings and please help to review.

@tadelesh tadelesh dismissed RickWinter’s stale review September 27, 2022 03:07

Jeff and Joel all approved the breaking changes. Release to unblock the customers.

@tadelesh tadelesh enabled auto-merge (squash) September 27, 2022 03:07
@tadelesh tadelesh merged commit 9c7a2a8 into Azure:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants