-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] sdk/resourcemanager/authorization/armauthorization/2.0.0 #18890
[Release] sdk/resourcemanager/authorization/armauthorization/2.0.0 #18890
Conversation
…neration from spec commit: 53b1affe357b3bfbb53721d0a2002382a046d3b0
Wait for .Net authorization GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 releases are painful for customers. We want to keep this on the v1.x path.
The breakings contain required param removal, property ref change and operation removal from swagger. I don't think it is possible to make it 1.x. |
Any progress here? Is there a way to get this merged in the next days? |
@RickWinter, @JeffreyRichter, @jhendrixMSFT I've used directive to mitigate most of the breakings. Only one orphan model deletion left. I think it could be ignored regarding it will not break customer. You could see the new generated SDK here and directive here. Could you help to confirm whether we could release it with 1.1.0? |
Joel & I spoke about this today. Here's where we're at... So, if we ship a client V1.0.0 and then the swagger gets fixed, we ship a new client V1.0.1. So, any client library break must be done in a new major version so that the new major and old major can be compiled together into a single app. Obviously, the best thing for us (service team and SDK teams) to do is to better validate our swaggers and fix bugs before we create and ship client libraries. |
Any progress here? |
We are double confirming with service team and will release the new version soon. |
@RickWinter Please sign off. .NET has released |
Release request: https://github.com/Azure/sdk-release-request/issues/3207 |
All the breaking changes is from this PR and approved in this PR.
|
@jhendrixMSFT @RickWinter @JeffreyRichter I list all the breakings and please help to review. |
Jeff and Joel all approved the breaking changes. Release to unblock the customers.
This release help to fix two issues: