Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Expose com.azure.core.util.ClientOptions via Builder and implement applicationId in UserAgent for telemetry #15124

Closed
4 tasks
hemanttanwar opened this issue Sep 11, 2020 · 0 comments · Fixed by #15965
Closed
4 tasks

[Search] Expose com.azure.core.util.ClientOptions via Builder and implement applicationId in UserAgent for telemetry #15124

hemanttanwar opened this issue Sep 11, 2020 · 0 comments · Fixed by #15965
Assignees
@alzimmermsft
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] October

Comments

@hemanttanwar
Copy link
Contributor

hemanttanwar commented Sep 11, 2020 •
edited
Loading

Expose com.azure.core.util.ClientOptions via Builder and implement applicationId in UserAgent for telemetry

  • Expose com.azure.core.util.ClientOptions via Builder and
  • Implement applicationId in UserAgent for telemetry
  • Take the Headers set by user in ClientOptions and set them on Http Request. We would have to make sure whatever the user passed in as Header, is not overwritten by the policies. So we should just add an AddHeadersPolicy after all other policies.
  • Unit Test

Depricated API: httpLogOptions.getApplicationId()
Look Epic for detail : #15107
@hemanttanwar hemanttanwar added Client This issue points to a problem in the data-plane of the library. Search labels Sep 11, 2020
@hemanttanwar hemanttanwar added this to the [2020] October milestone Sep 11, 2020
@alzimmermsft alzimmermsft mentioned this issue Oct 5, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Aug 2, 2021
@FumingZhang @matthchr
@bcho @orparnes @haitch @marwanad @akning-ms
CodeGen from PR 15370 in Azure/azure-rest-api-specs
434d16c 
[AKS] Merge dev-containerservice-Microsoft.ContainerService-2021-07-01 to master (Azure#15370)

* Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01

* Updates readme

* Updates API version in new specs and examples

* Modify Swagger to fix the problem of automatically generating ugly names in track 2 (Azure#14758)

* update swagger to fix track 2 autogenerated naming issue

* fix

* update readme for sdk generation

* fix lint error

* Trigger Build

* update readme

* Improve AKS Swagger documentation (Azure#14957)

* Improve AKS Swagger documentation

  - This change has already been merged in master
    for the 2021-05-01 API version.

* Fix up custom words

* aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (Azure#15033)

* fix: decouple pod identity provisioning error from cloud error

* drop extra external mark

* fix linting issue

* fix reference

* Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (Azure#15035)

* Add SecurityProfile to ManagedClusters

* spaces

* Space

* spaces

* json formatting

* move from params to defs

* :)

* just another

* now with npm

* Descriptions update for AKS July API (Azure#15074)

* allow disabling of runcommand (Azure#15092)

* allow disabling of runcommand

* format error

* format with example

* change enable to disable

* Revert "allow disabling of runcommand (Azure#15092)" (Azure#15147)

This reverts commit ec3e241a564d21f5ec914f4aa0b59a96ac7ec0d9.

* [AKS] Add NATGatewayProfile to 2021-07-01 API (Azure#15154)

* [AKS] Add NATGatewayProfile to 2021-07-01 API

* Fix linter errors

Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>

* Add scaleDownMode to agent pool properties (Azure#15124)

* add scale down mode

* address comments

* fix markdown link

* update proper api version

* Resolve python markdown conflict & fix typo (Azure#15402)

* resolve python conflict & fix typo

* resolve conflict

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Co-authored-by: hbc <bcxxxxxx@gmail.com>
Co-authored-by: Or Parnes <orparnes@gmail.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>
Co-authored-by: Marwan Ahmed <marwanad@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

Search Support New Builder Functionality alzimmermsft/azure-sdk-for-java
2 participants
@hemanttanwar @alzimmermsft