Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize Environment Non-Proxy Hosts Before Use #18156

Closed
alzimmermsft opened this issue Dec 16, 2020 · 0 comments · Fixed by #18158
Closed

Sanitize Environment Non-Proxy Hosts Before Use #18156

alzimmermsft opened this issue Dec 16, 2020 · 0 comments · Fixed by #18158
Assignees
@alzimmermsft
Labels
Azure.Core azure-core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Comments

@alzimmermsft
Copy link
Member

alzimmermsft commented Dec 16, 2020 •
edited
Loading

When using http.nonProxyHosts or NO_PROXY environment configurations we need to sanitize it before passing them into the proxy handlers as the expect a regex-able string.
@alzimmermsft alzimmermsft added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Dec 16, 2020
@alzimmermsft alzimmermsft self-assigned this Dec 16, 2020
@alzimmermsft alzimmermsft mentioned this issue Dec 16, 2020
Merged
@alzimmermsft alzimmermsft changed the title Cleanse Environment Non-Proxy Hosts Before Use Sanitize Environment Non-Proxy Hosts Before Use Dec 16, 2020
@jasonparallel jasonparallel mentioned this issue Oct 26, 2021
Closed
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Apr 20, 2022
CodeGen from PR 18156 in Azure/azure-rest-api-specs
504f54a 
Add new apis for test button feature (Azure#18156)

* Add new apis for test button feature

* Fix bug

* Revert to old package version

* Fix errors

* Fix errors

* Fix error

* Remove "

* Only include the actiongroups changes in this new tag as per Dapeng.

* Revert "Only include the actiongroups changes in this new tag as per Dapeng."

This reverts commit 529a149b258dfa8dc8dcc52b6e1fea16ab2b40d6.

* Add "x-ms-identifiers": [],

* Update the default tag

* Add location headers

* No need to return response

* build

* build

* format json

* Prettier check

Co-authored-by: Thomas Pham <thompham@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize Non-Proxy Host Configurations alzimmermsft/azure-sdk-for-java
1 participant
@alzimmermsft