Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] The SDK Service Bus service builder can not use a custom TraceProvider #24085

Closed
2 tasks done
moarychan opened this issue Sep 13, 2021 · 2 comments · Fixed by #33663
Closed
2 tasks done

[FEATURE REQ] The SDK Service Bus service builder can not use a custom TraceProvider #24085

moarychan opened this issue Sep 13, 2021 · 2 comments · Fixed by #33663
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus

Comments

@moarychan
Copy link
Member

moarychan commented Sep 13, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Azure SDK Service Bus builder can not use a custom TraceProvider, trace provider usage is here. The new trace implementation of azure core tracer interface will use the same Spring Sleuth tracer from Spring Application Context, or else the tracer information will not be linked for the same request which comes from Spring MVC and finally call Azure SDK methods.

Describe the solution you'd like
When building a service client, it's available to set a custom TraceProvider for ServiceBusClientBuilder instance.

Describe alternatives you've considered
No better solutions to achieve this feature.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2021
@saragluna
Copy link
Member

@joshfree, do you know whom I could assign this issue to?

@saragluna saragluna added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Sep 14, 2021
@moarychan moarychan mentioned this issue Sep 15, 2021
Closed
@moarychan moarychan linked a pull request Sep 17, 2021 that will close this issue
Support HTTP based Azure SDK service tracing by Spring Sleuth implementation #24192
Merged
@moarychan moarychan removed a link to a pull request Sep 28, 2021
Support HTTP based Azure SDK service tracing by Spring Sleuth implementation #24192
Merged
@anuchandy
Copy link
Member

The work to enable tracing is tracked in this work item #26269. Closing this in favor of 26269.

@lmolkova lmolkova reopened this Feb 22, 2023
@lmolkova lmolkova mentioned this issue Feb 22, 2023
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue May 22, 2023
@AzureRestAPISpecReview
CodeGen from PR 24085 in Azure/azure-rest-api-specs
efa04c9 
[Hub Generated] Publish private branch 'datafactory/v-jinpan/FixO365' (Azure#24085)

* [AutoSync] 4844c5088f Add OutputColumnsElement For Track2 Upgrade

* [AutoSync] 0fe3e1a701 update

* [AutoSync] 39056bdca3 update

---------

Co-authored-by: swagger-automation <swagger@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Onboard ServiceBus onto new tracing lmolkova/azure-sdk-for-java
4 participants
@anuchandy @lmolkova @moarychan @saragluna