Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tables public API #14343

Merged
merged 10 commits into from
Aug 24, 2020
Merged

Update tables public API #14343

merged 10 commits into from
Aug 24, 2020

Conversation

bsiegel
Copy link
Member

@bsiegel bsiegel commented Aug 21, 2020 •
edited
Loading

Brandon Siegel added 6 commits August 13, 2020 15:35
Remove old / duplicate classes
32b42a7
Standardize names of Models types
69f1d6a 
Also remove TSC.getTable and TC.create, they are no longer part of the
public API
Update snippets
8162897
Fix tests
48066f0
Do not return the created object from create* APIs
10c42e0 
Other upsert / merge / update APIs do not have this feature, so it's
inconsistent to return the created object when the other APIs return
void. And since we no longer need it, request that the create* APIs
return no content to reduce the payload size.
Update test recordings to account for the create* API changes
7e265af
@eboyd23 eboyd23 mentioned this pull request Aug 24, 2020
Closed
@conniey conniey added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 24, 2020
@conniey conniey added this to the [2020] September milestone Aug 24, 2020
conniey
conniey approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableClient.java
public Response<Void> updateEntityWithResponse(Entity entity, boolean ifUnchanged, UpdateMode updateMode,
Duration timeout, Context context) {
public Response<Void> updateEntityWithResponse(TableEntity entity, boolean ifUnchanged, UpdateMode updateMode,
Duration timeout, Context context) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually not a fan of aligning parameters, because we have some seriously long method/class names and the parameters get mushed against the right margin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I don't have a strong opinion, so I just went with whatever IntelliJ did by default. If we decide to care more about this we can probably encode it in an editorconfig (or more likely an intellij settings file, since this might be IDE-specific).

sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClient.java Outdated
*/
@ServiceMethod(returns = ReturnType.COLLECTION)
public PagedIterable<TableItem> listTables() {
return new PagedIterable<>(client.listTables(new ListTablesOptions()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider making new ListTablesOptions() a member variable so we don't have to allocate a new object to it for every call.

@bsiegel bsiegel merged commit 8cbf72e into Azure:master Aug 24, 2020
@bsiegel bsiegel deleted the public-api branch August 24, 2020 22:16
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request May 11, 2021
@matyang22 @gitlwh
@nschonni @Khushboo-Baheti @guptas14 @Satya-anshu @arvenka @harics24 @tejasshah7 @shnaya434 @wdehrich @litchiyangMSFT @3quanfeng @bhbhise @mscorp-buchen @aragar740 @basharg
CodeGen from PR 14333 in Azure/azure-rest-api-specs
9235f47 
Network february release (Azure#14333)

* Adds base for updating Microsoft.Network from version stable/2020-11-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* init (#13496)

Co-authored-by: matyang222 <matthew.yang@microsoft.com>

* Swagger change for CustomIpPrefix. Adding four new attributes.  (#13456)

* update swagger

* fix apiversion

* fix

* add

Co-authored-by: Weiheng Li <weihl@microsoft.com>

* typo: paramter in applicationGateway.json (#13538)

* VPN NAT for Virtual Network Gateway feature changes(networkFeb) (#13481)

* commit1

* commit2

* resolving comments

* pythonMd

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* fix virtual network resource (#13570)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (#13519)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Properties

* Updated the type from string to integer, added a non-null example

* Added missing format for 'integer' type

* Add new failedMessage property for CustomIpPrefix (#13607)

* update swagger

* fix apiversion

* fix

* add

* add failedreason property

* update swagger

* fix apiversion

* fix

* add failedreason property

* update

Co-authored-by: Weiheng Li <weihl@microsoft.com>

* Added Preferred Routing Gateway Support (#13611)

* Feature: Address space update in peered vNets (#13521)

* Adding new fields and operation to support the address space update in peered vNets

Adding new fields and operation to support the address space update in peered vNets

* Adding the new query param in the example

As per the review comment, adding the new query param in the example request response of swagger.

* Adding the new query param in examples

Adding the new query param in examples

* Restricting the sync param

Restricting the sync param to hold only true as value. We never need to send false.

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* Remove max file size limit enforcement as it is done in NRP (#13679)

* Tesha/fix waf policy examples crs version (#13697)

* Remove max file size limit enforcement as it is done in NRP

* Update the CRS version in the examples to reflect latest

* Fix (#13734)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Swagger for NRP's VipSwap operation (#13639)

* Swagger for NRP's VipSwap operation

* Fixing validation errors

* minor fix

* Adding api version

* Remove required (Azure#13969)

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Hotfix extended location parameter hierarchy (Azure#13864)

* add to feb branch

* delete project name reference

* expose two new client cert properties: validatedCertData, clientCertIssuerDN (Azure#13989)

* adding workloadType property for Baremetal scenarios (Azure#14101)

* Added bastion sku (Azure#14248)

* fix nrp resources based on s360 checks (Azure#14219)

* Adding Azure Network Manager association to the EffectiveNetworkSecurityGroups API (Azure#14265)

* Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation

* Adding example for networkManager response in the EffectiveNSG call

* Add deleteOption to PublicIPAddress (Azure#14343)

* Add deleteOption to PublicIPAddress

* run validators

Co-authored-by: Bashar Gharaibeh <basharghar@live.com>

Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com>
Co-authored-by: matyang222 <matthew.yang@microsoft.com>
Co-authored-by: Tom Li <weihengli.tj@gmail.com>
Co-authored-by: Weiheng Li <weihl@microsoft.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com>
Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com>
Co-authored-by: arvenka <arvenka@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: shnaya434 <67019054+shnaya434@users.noreply.github.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: biaogao <biga@microsoft.com>
Co-authored-by: bhbhise <83041483+bhbhise@users.noreply.github.com>
Co-authored-by: mscorp-buchen <78105006+mscorp-buchen@users.noreply.github.com>
Co-authored-by: Arpit Agarwal <83313290+aragar740@users.noreply.github.com>
Co-authored-by: basharg <basharg@microsoft.com>
Co-authored-by: Bashar Gharaibeh <basharghar@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey conniey approved these changes

@srnagar srnagar Awaiting requested review from srnagar

Assignees

@bsiegel bsiegel

Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Milestone
[2020] September
Development

Successfully merging this pull request may close these issues.

Finalize Table Object Naming Scheme: Tables SDK
2 participants
@bsiegel @conniey