Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceTokenFix-ReadAllItems #19662

Merged
merged 2 commits into from
Mar 6, 2021

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Mar 5, 2021

Issue: When we use readAllItem with partition key, currently, we are not using partitionKey.

Change include:

  1. Fix readAllItems with resourceToken
  2. Refactor ModelBridgeInternal.partitionKeyRangeIdInternal method name to include get/set to make it more distinguishable

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @xinlian12
thanks for the fix.

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks.

@xinlian12 xinlian12 merged commit 0eb4f70 into Azure:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants