make Timer task run as a daemon thread #20014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Change log will be updated after the release of 3.3.0 is done. |
yiliuTo
changed the title
…into fix-keyvault-issue
yiliuTo
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna and
stliu
as code owners
chenrujun
approved these changes
Mar 24, 2021
|
/check-enforcer override |
|
Actually I don't like this idea, is there a way to get rid of this Timer and replace it with I can see this |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to fix a bug of KeyVault Secret starter that refresh Timer task blocks application termination. Solution is to make Timer task run in a daemon thread.