Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Level Test Fix + Removed Direct HTTPs mode tests + Authorization Token Type Invalid Fix #23120

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Log Level Test Fix + Removed Direct HTTPs mode tests + Authorization Token Type Invalid Fix #23120

merged 5 commits into from
Jul 23, 2021

Conversation

kushagraThapar
Copy link
Member

  • Log Level Test Fix
  • Removed Direct HTTPs mode tests

@ghost ghost added the Cosmos label Jul 21, 2021
@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - test

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

moderakh
moderakh reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just change the implementation of simpleClientBuildersWithDirect to remove DirectHttps that will be easier to do as you don't have to touch every test file to change simpleClientBuildersWithDirect to simpleClientBuildersWithDirectTcp.

the change will become mostly isolated only in one or two place

sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosContainerChangeFeedTest.java Outdated Show resolved Hide resolved
@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kushagraThapar
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kushagraThapar kushagraThapar changed the title [DO NOT MERGE] Log Level Test Fix + Removed Direct HTTPs mode tests Log Level Test Fix + Removed Direct HTTPs mode tests + Authorization Token Type Invalid Fix Jul 23, 2021
moderakh
moderakh approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks Kushagra

xinlian12
xinlian12 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the fix

@kushagraThapar kushagraThapar enabled auto-merge (squash) July 23, 2021 19:36
@kushagraThapar
Copy link
Member Author

/check-enforcer override

@kushagraThapar kushagraThapar merged commit 4236d35 into main Jul 23, 2021
@kushagraThapar kushagraThapar deleted the users/kuthapar/test_log_level_fix branch July 23, 2021 19:36
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 19, 2023
@ericshape @mohitagarwal-sql
@GalGoldi72 @ilijadivljan-ms @subhrob @CelinaJiangJXY @beoberha @toki95
CodeGen from PR 23802 in Azure/azure-rest-api-specs
7505335 
Release sql microsoft.sql 2022 11 01 preview (Azure#23802)

* Adds base for updating Microsoft.Sql from version preview/2022-08-01-preview to version 2022-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Swagger API changes required for progress-reporting related changes in DatabaseOperations (Azure#22669)

* Update swagger (Azure#22715)

* Follow-up Swagger API changes required for progress-reporting related changes in DatabaseOperations  (Azure#22775)

* Add Swagger API changes required for progress-reporting related changes in DatabaseOperations

* Follow up changes required for progress-reporting related changes in DatabaseOperations

* updated example file

* Added Failed case in list-operations examples

* Update Microsoft.Sql ManagedInstance 2022-11-01-preview Swagger Docs (Azure#22899)

* Update Microsoft.sql ManagedInstance 2022-11-01-preview Swagger Docs

* Address Swagger Validation Errors

* Modify custom-words.txt

* Manually updating arm-id format to match stable 2021-11-01 version

* Adding provisioning state changes

* fixing validation

* adding missing space

* Remove HTTP 200 from Start/Stop Actions as we only return HTTP 202

---------

Co-authored-by: Jovana Toroman <jtoroman@microsoft.com>

* Update DateTime to ISO-8601 format in example file (Azure#22986)

* Add Swagger API changes required for progress-reporting related changes in DatabaseOperations

* Follow up changes required for progress-reporting related changes in DatabaseOperations

* updated example file

* Added Failed case in list-operations examples

* Update DateTime to ISo-8601 format in example file

* Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group (Azure#22673)

* Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group

* Modify example file

* Add example

* Fix ModelValidation issues

* Fix ModelValidation issues

* Add new controller

* Modify example

* Modify example

* Update server name

* Fix LintDiff

* Fix model validation errors

* Fix PostOperationAsyncResponseValidation, Unfix LroLocationHeader,ResourceNameRestriction

* Fix PostOperationAsyncResponseValidation

* Fix pending items

* Update doc

* Remove empty/unschematized object

---------

Co-authored-by: subhrob <subhrob@microsoft.com>

* [DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (Azure#22697)

* add archival changes to LTRPolicy

* fix LongTermRetentionPolicies swagger file

* fix check failures

* redo swagger

* Update swagger documentation for Managed Instance start-stop actions (Azure#22992)

* Add NetworkSecurityPerimeterConfigurations Swagger (Azure#22960)

* Add NetworkSecurityPerimeterConfigurations Swagger

* Fixes round 1

* Fixes round 2

* Fixes Round 3

* Fixes Round 4

* Fix Round 5

* fixing enum (Azure#22995)

Co-authored-by: Jovana Toroman <jtoroman@microsoft.com>

* add changes (Azure#23120)

* Carry all minor changes to dev sql microsoft.sql 2022 11 01 preview (Azure#23337)

* Revert "add changes (Azure#23120)"

This reverts commit 5c348d22f8fb6c29b7322e28ea78d665586f4135.

Revert "[DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (Azure#22697)"

This reverts commit 559f7f474d944a92f6cb108eb433a05f3c53cd8e.

* Carrying minor changes to release branch for Microsoft.Sql 2022-11-01-preview

* Reverting DatabaseAdvisors

* Further reverting problematic files

* Reverting a few example files

* Adding back arm-id to a few files

* Reverting error message change in ManagedDatabaseRestoreDetails.json, Jobs.json,ServerDevOpsAudit.json, and TransparentDataEncryptions.json

* Minor fixes for Turkey name change and missing x-ms-identifier (Azure#23637)

* Fixing issues with a few breaking changes (Azure#23943)

* Minor fixes for Turkey name change and missing x-ms-identifier

* Adding back missing arm-id and other missing property issues causing breaking changes incorrectly.

* Fixing prettier issue with ManagedDatabases.json

* Fixing arm-id format in 4 examples

* Adding missing location for 202 responses on sync examples

---------

Co-authored-by: Ji Wang <wangjiprc@gmail.com>
Co-authored-by: Mohit Agarwal <mohitagarwal@microsoft.com>
Co-authored-by: GalGoldi72 <124780962+GalGoldi72@users.noreply.github.com>
Co-authored-by: ilijadivljan-ms <122982104+ilijadivljan-ms@users.noreply.github.com>
Co-authored-by: Jovana Toroman <jtoroman@microsoft.com>
Co-authored-by: subhrob <subhro.bhattacharya@gmail.com>
Co-authored-by: subhrob <subhrob@microsoft.com>
Co-authored-by: CelinaJiangJXY <124339390+CelinaJiangJXY@users.noreply.github.com>
Co-authored-by: beoberha <51964155+beoberha@users.noreply.github.com>
Co-authored-by: toki95 <35834415+toki95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milismsft milismsft milismsft approved these changes

@moderakh moderakh moderakh approved these changes

@simplynaveen20 simplynaveen20 simplynaveen20 approved these changes

@xinlian12 xinlian12 xinlian12 approved these changes

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kushagraThapar @milismsft @moderakh @simplynaveen20 @xinlian12