mgmt, bug fix for appservice Function App on ACA, prepare release patch #39044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
|
API change check API changes are not detected in this pull request. |
XiaofeiCao
commented
Mar 4, 2024
| @@ -646,7 +657,7 @@ private void adaptForFunctionAppOnACA() { | |||
| siteConfigInner.withLinuxFxVersion(this.siteConfig.linuxFxVersion()); | |||
| siteConfigInner.withMinimumElasticInstanceCount(this.siteConfig.minimumElasticInstanceCount()); | |||
| siteConfigInner.withFunctionAppScaleLimit(this.siteConfig.functionAppScaleLimit()); | |||
| siteConfigInner.withAppSettings(this.siteConfig.appSettings()); | |||
| siteConfigInner.withAppSettings(this.siteConfig.appSettings() == null ? new ArrayList<>() : this.siteConfig.appSettings()); | |||
There was a problem hiding this comment.
Fixed NPE bug. This bug happened when update doesn't touch any ACA configurations.
XiaofeiCao
commented
Mar 4, 2024
Comment on lines
575
to
576
| .withMinReplicas(3) | ||
| .withPrivateRegistryImage("xiaofeiacr.azurecr.io/samples/nginx:latest", "xiaofeiacr.azurecr.io") | ||
| .withPrivateRegistryImage("samples/nginx:latest", "https://xiaofeiacr.azurecr.io") |
There was a problem hiding this comment.
ACA doesn't allow URL with https anymore... Previously we exposed that to the customer. Here we align the behavior with normal FunctionApp.
XiaofeiCao
requested review from
alzimmermsft,
samvaity,
g2vinay,
JimSuplizio,
weidongxu-microsoft,
haolingdong-msft and
ArthurMa1978
as code owners
...rvice/src/main/java/com/azure/resourcemanager/appservice/implementation/FunctionAppImpl.java
Show resolved
Hide resolved
...manager-appservice/src/test/java/com/azure/resourcemanager/appservice/FunctionAppsTests.java
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Mar 4, 2024
...manager-appservice/src/test/java/com/azure/resourcemanager/appservice/FunctionAppsTests.java
Outdated
Show resolved
Hide resolved
XiaofeiCao
merged commit 878ad07
into
Azure:release/azure-resourcemanager-appservice/2.36.1
11 of 18 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
withPrivateRegistryImagedoesn't work as expected for Function App in Azure Container Apps.Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines