[CODEOWNERS] Fix duplicate entries for messaging #39155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to fix service label duplication that would cause inappropriate matches for the messaging services. ### Important context: - The `Service Attention` label is ignored during match logic. - Service label matches follow the same rules as paths for pull requests. This means that ordering of rules is important; scanning starts at the bottom of the file and progresses towards the top. Once the first match is found, it is used and scanning stops. This means that the `/<NotInRepo>/` section at the bottom of this file will be the first matches found for most service tags, causing automated triage to consider these tags to be service-owned and assigned.
alzimmermsft
approved these changes
Mar 11, 2024
drielenr
pushed a commit
that referenced
this pull request
Apr 2, 2024
The focus of these changes is to fix service label duplication that would cause inappropriate matches for the messaging services. ### Important context: - The `Service Attention` label is ignored during match logic. - Service label matches follow the same rules as paths for pull requests. This means that ordering of rules is important; scanning starts at the bottom of the file and progresses towards the top. Once the first match is found, it is used and scanning stops. This means that the `/<NotInRepo>/` section at the bottom of this file will be the first matches found for most service tags, causing automated triage to consider these tags to be service-owned and assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus of these changes is to fix service label duplication that would cause inappropriate matches for the messaging services.
Important context:
The
Service Attentionlabel is ignored during match logic.Service label matches follow the same rules as paths for pull requests. This means that ordering of rules is important; scanning starts at the bottom of the file and progresses towards the top. Once the first match is found, it is used and scanning stops.
This means that the
/<NotInRepo>/section at the bottom of this file will be the first matches found for most service tags, causing automated triage to consider these tags to be service-owned and assigned.