Set version of org.apache.maven.plugins:maven-gpg-plugin in publish script #39185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
requested review from
alzimmermsft,
samvaity,
g2vinay,
JonathanGiles,
chenrujun,
Netyyyy,
saragluna,
moarychan,
hallipr,
weshaggard and
benbp
as code owners
alzimmermsft
approved these changes
Mar 12, 2024
|
I ran the template pipeline against the refs/merge of this PR and changes worked. I'm going to override check enforcer to get these merged in. Note: The Update Package Version steps are going to fail when running against a refs/merge which is why the override is required. |
|
/check-enforcer override |
|
/check-enforcer evaluate |
|
@microsoft-github-policy-service rerun |
1 similar comment
|
@microsoft-github-policy-service rerun |
drielenr
pushed a commit
that referenced
this pull request
Apr 2, 2024
…cript (#39185) * Set version of org.apache.maven.plugins:maven-gpg-plugin in publish script * there's supposed to be a ; before the version, not a :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing
mvn gpg:sign-and-deploy-fileit always just pulls the latest version of org.apache.maven.plugins:maven-gpg-plugin. On Friday, 03/08/2024, version 3.2.0 was published and it looks like our pipelines started picking this version up yesterday and we're seeing publishing failures trying to publish to the dev feed in release pipelines as well as nightly scheduled runs.This change will allow us to set the version of org.apache.maven.plugins:maven-gpg-plugin used by the publish commands. Right now, I'm setting it back to 3.1.0 to unblock publishing until I'm able to figure out why 3.2.0 is failing. Unfortunately, the release notes for 3.2.0 are beyond unhelpful.
To test this particular change I'm going to be running the Template pipeline against this refs/merge.