Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev version always being set #39272

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix dev version always being set #39272

merged 1 commit into from
Mar 18, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Follow-up to #39243 where the task for setting dev versioning lost its condition and was always being applied.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added the EngSys This issue is impacting the engineering system. label Mar 18, 2024
@alzimmermsft alzimmermsft self-assigned this Mar 18, 2024
FabianMeiswinkel
FabianMeiswinkel approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft enabled auto-merge (squash) March 18, 2024 13:37
@alzimmermsft alzimmermsft merged commit afa375b into Azure:main Mar 18, 2024
15 of 29 checks passed
@alzimmermsft alzimmermsft deleted the AzEng_FixConditionOnSetDevVersion branch March 18, 2024 13:38
drielenr pushed a commit that referenced this pull request Apr 2, 2024
@alzimmermsft @drielenr
Fix dev version always being set (#39272)
6c0a69c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alzimmermsft @FabianMeiswinkel