Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate Job Router with stream-style serialization and remove many Internal models #40397

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Regenerate Job Router with stream-style serialization and remove many Internal models #40397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82637b1
Regenerate Job Router with stream-style serialization and remove many…
alzimmermsft May 29, 2024
e4a24d0
Fix a few customizations that were needed
alzimmermsft May 30, 2024
3d129d9
Merge branch 'main' into AzComm_GenerateJobRouterWithSourceGenerator
alzimmermsft Jun 4, 2024
53f84cd
Use reference to azure-rest-api-spec PR
alzimmermsft Jun 4, 2024
253aab7
Small change to code customization
alzimmermsft Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions eng/code-quality-reports/src/main/resources/revapi/revapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@
},
{
"code": "java.annotation.added",
"old" : "method com.azure.cosmos.CosmosDiagnosticsContext com.azure.cosmos.CosmosDiagnostics::getDiagnosticsContext()",
"new" : "method com.azure.cosmos.CosmosDiagnosticsContext com.azure.cosmos.CosmosDiagnostics::getDiagnosticsContext()",
"old": "method com.azure.cosmos.CosmosDiagnosticsContext com.azure.cosmos.CosmosDiagnostics::getDiagnosticsContext()",
"new": "method com.azure.cosmos.CosmosDiagnosticsContext com.azure.cosmos.CosmosDiagnostics::getDiagnosticsContext()",
"justification": "Ignore CosmosDiagnosticsContext in CosmosDiagnostics to avoid stackoverflow error."
},
{
Expand All @@ -389,27 +389,27 @@
"new": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Adding missing Jackson annotations to Job Router models."
},
{
{
"regex": true,
"code": "java\\.method\\.removed",
"old": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Remove setter for Value from RouterWorkerSelector/RouterQueueSelector since it's in the constructor."
},
{
{
"regex": true,
"code": "java\\.method\\.numberOfParametersChanged",
"old": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"new": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Make Value mandatory in RouterWorkerSelector/RouterQueueSelector constructor."
},
{
{
"regex": true,
"code": "java\\.annotation\\.attributeValueChanged",
"old": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"new": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Fix incorrect json attributes."
},
{
{
"regex": true,
"code": "java\\.method\\.returnTypeTypeParametersChanged",
"old": ".*?com\\.azure\\.communication\\.jobrouter.*",
Expand All @@ -423,7 +423,7 @@
"new": ".*?com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Accept Router models rather than BinaryData."
},
{
{
"regex": true,
"code": "java\\.method\\.returnTypeChanged",
"old": ".*?com\\.azure\\.communication\\.jobrouter.*",
Expand Down Expand Up @@ -482,6 +482,13 @@
"code": "java\\.annotation\\.removed",
"old": ".*? com\\.azure\\.data\\.tables\\.models.*",
"justification": "Removing Jackson annotations from Tables in transition to stream-style."
},
{
"regex": true,
"code": "java\\.annotation\\.removed",
"old": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"new": ".*? com\\.azure\\.communication\\.jobrouter\\.models.*",
"justification": "Removing Jackson annotations from Job Router in transition to stream-style."
}
]
}
Expand Down
624 changes: 507 additions & 117 deletions .../azure-communication-jobrouter/customization/src/main/java/JobRouterSdkCustomization.java
View file
Open in desktop

Large diffs are not rendered by default.

332 changes: 292 additions & 40 deletions ...r/src/main/java/com/azure/communication/jobrouter/JobRouterAdministrationAsyncClient.java
View file
Open in desktop

Large diffs are not rendered by default.

324 changes: 285 additions & 39 deletions ...router/src/main/java/com/azure/communication/jobrouter/JobRouterAdministrationClient.java
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions ...src/main/java/com/azure/communication/jobrouter/JobRouterAdministrationClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
// Code generated by Microsoft (R) TypeSpec Code Generator.
package com.azure.communication.jobrouter;

import com.azure.communication.common.implementation.HmacAuthenticationPolicy;
import com.azure.communication.common.implementation.CommunicationConnectionString;
import com.azure.core.credential.AzureKeyCredential;
import com.azure.core.client.traits.ConnectionStringTrait;
import com.azure.core.client.traits.KeyCredentialTrait;
import com.azure.core.client.traits.TokenCredentialTrait;
import com.azure.communication.jobrouter.implementation.JobRouterAdministrationClientImpl;
import com.azure.core.annotation.Generated;
import com.azure.core.annotation.ServiceClientBuilder;
Expand Down Expand Up @@ -43,6 +37,12 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import com.azure.core.client.traits.TokenCredentialTrait;
import com.azure.core.client.traits.KeyCredentialTrait;
import com.azure.core.client.traits.ConnectionStringTrait;
import com.azure.core.credential.AzureKeyCredential;
import com.azure.communication.common.implementation.CommunicationConnectionString;
import com.azure.communication.common.implementation.HmacAuthenticationPolicy;
import com.azure.core.credential.KeyCredential;
import com.azure.core.credential.TokenCredential;

Expand Down
212 changes: 113 additions & 99 deletions ...ation-jobrouter/src/main/java/com/azure/communication/jobrouter/JobRouterAsyncClient.java
View file
Open in desktop

Large diffs are not rendered by default.

202 changes: 120 additions & 82 deletions ...munication-jobrouter/src/main/java/com/azure/communication/jobrouter/JobRouterClient.java
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions ...ion-jobrouter/src/main/java/com/azure/communication/jobrouter/JobRouterClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
// Code generated by Microsoft (R) TypeSpec Code Generator.
package com.azure.communication.jobrouter;

import com.azure.communication.common.implementation.HmacAuthenticationPolicy;
import com.azure.communication.common.implementation.CommunicationConnectionString;
import com.azure.core.credential.AzureKeyCredential;
import com.azure.core.client.traits.ConnectionStringTrait;
import com.azure.core.client.traits.KeyCredentialTrait;
import com.azure.core.client.traits.TokenCredentialTrait;
import com.azure.communication.jobrouter.implementation.JobRouterClientImpl;
import com.azure.core.annotation.Generated;
import com.azure.core.annotation.ServiceClientBuilder;
Expand Down Expand Up @@ -43,6 +37,12 @@
import java.util.List;
import java.util.Map;
import java.util.Objects;
import com.azure.core.client.traits.TokenCredentialTrait;
import com.azure.core.client.traits.KeyCredentialTrait;
import com.azure.core.client.traits.ConnectionStringTrait;
import com.azure.core.credential.AzureKeyCredential;
import com.azure.communication.common.implementation.CommunicationConnectionString;
import com.azure.communication.common.implementation.HmacAuthenticationPolicy;
import com.azure.core.credential.KeyCredential;
import com.azure.core.credential.TokenCredential;

Expand Down
96 changes: 48 additions & 48 deletions ...a/com/azure/communication/jobrouter/implementation/JobRouterAdministrationClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,12 +1576,12 @@ public Response<Void> deleteClassificationPolicyWithResponse(String classificati
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand All @@ -1600,12 +1600,12 @@ public Response<Void> deleteClassificationPolicyWithResponse(String classificati
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1656,12 +1656,12 @@ public Mono<Response<BinaryData>> upsertExceptionPolicyWithResponseAsync(String
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand All @@ -1680,12 +1680,12 @@ public Mono<Response<BinaryData>> upsertExceptionPolicyWithResponseAsync(String
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1724,12 +1724,12 @@ public Response<BinaryData> upsertExceptionPolicyWithResponse(String exceptionPo
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1767,12 +1767,12 @@ public Mono<Response<BinaryData>> getExceptionPolicyWithResponseAsync(String exc
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1816,12 +1816,12 @@ public Response<BinaryData> getExceptionPolicyWithResponse(String exceptionPolic
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1867,12 +1867,12 @@ private Mono<PagedResponse<BinaryData>> listExceptionPoliciesSinglePageAsync(Req
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1936,12 +1936,12 @@ public PagedFlux<BinaryData> listExceptionPoliciesAsync(RequestOptions requestOp
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -1985,12 +1985,12 @@ private PagedResponse<BinaryData> listExceptionPoliciesSinglePage(RequestOptions
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -2684,12 +2684,12 @@ private PagedResponse<BinaryData> listClassificationPoliciesNextSinglePage(Strin
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down Expand Up @@ -2731,12 +2731,12 @@ private Mono<PagedResponse<BinaryData>> listExceptionPoliciesNextSinglePageAsync
* name: String (Optional)
* exceptionRules (Optional): [
* (Optional){
* id: String (Required)
* trigger (Required): {
* id: String (Optional, Required on create)
* trigger (Optional, Required on create): {
* kind: String(queueLength/waitTime) (Required)
* }
* actions (Required): [
* (Required){
* actions (Optional, Required on create): [
* (Optional, Required on create){
* kind: String(cancel/manualReclassify/reclassify) (Required)
* id: String (Optional)
* }
Expand Down
Loading