Skip to content

Commit

Permalink
[Core AMQP] satusDescription -> statusDescription (#12225)
Browse files Browse the repository at this point in the history
Address the typo for statusDescription and fixes #9031
  • Loading branch information
ramya-rao-a authored Nov 3, 2020
1 parent df030f4 commit b906935
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion sdk/core/core-amqp/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

### Breaking changes

- `satusDescription` in `CbsResponse` which is the output for `CbsClient.negotiateClaim()` is renamed to `statusDescription` to fix the spelling error.
- The `CbsClient.negotiateClaim()` method now takes the token string directly instead of the `AccessToken` object.

We are cleaning the public API surface by

- removing exports that are either not used by either `@azure/event-hubs` and `@azure/service-bus` packages (which are the two main consumers of this package)
Expand All @@ -19,7 +22,6 @@ We are cleaning the public API surface by
- Timeout
- moving the clases/methods/interfaces that are very specific to Event Hubs/Service Bus to their corresponding packages.
- SharedKeyCredential
- As part of this move the `negotiateClaim()` method now takes the token string directly instead of the `AccessToken` object.
- EventHubConnectionConfig
- avoid re-exporting things from `rhea-promise` and `@azure/core-auth`
- Dictionary
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-amqp/review/core-amqp.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ export interface CbsResponse {
// (undocumented)
correlationId: string;
// (undocumented)
satusDescription: string;
// (undocumented)
statusCode: string;
// (undocumented)
statusDescription: string;
}

// @public
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-amqp/src/cbs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { RequestResponseLink } from "./requestResponseLink";
export interface CbsResponse {
correlationId: string;
statusCode: string;
satusDescription: string;
statusDescription: string;
}

/**
Expand Down Expand Up @@ -268,7 +268,7 @@ export class CbsClient {
const cbsResponse = {
correlationId: msg.correlation_id! as string,
statusCode: msg.application_properties ? msg.application_properties["status-code"] : "",
satusDescription: msg.application_properties
statusDescription: msg.application_properties
? msg.application_properties["status-description"]
: ""
};
Expand Down

0 comments on commit b906935

Please sign in to comment.