Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] DeviceCodeCredential: Add a timeout optional parameter. #11670

Closed
sadasant opened this issue Oct 6, 2020 · 4 comments · Fixed by #14064
Closed

[Identity] DeviceCodeCredential: Add a timeout optional parameter. #11670

sadasant opened this issue Oct 6, 2020 · 4 comments · Fixed by #14064
Assignees
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@sadasant
Copy link
Contributor

sadasant commented Oct 6, 2020

Python currently offers a way to timeout the authentication request. We should investigate if we can add the same feature.

@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Oct 6, 2020
@sadasant sadasant added this to the [2020] November milestone Oct 6, 2020
@g2vinay g2vinay added the blocking-release Blocks release label Oct 8, 2020
@sadasant
Copy link
Contributor Author

sadasant commented Oct 8, 2020

Here's what I know so far,

DeviceCodeCredential (DCC) uses PublicClientApplication, from @azure/msal-node. PublicClientApplication extends ClientApplication, which has at least two distinct notions of a timeout:

I think that configuration makes sense to work with, but I might not have enough context.

@sadasant sadasant self-assigned this Oct 9, 2020
@sadasant
Copy link
Contributor Author

I had a conversation with @jonathandturner about this feature and how Python approaches it (here) and, since this issue relates to MSAL and to the work he's already doing, we decided on assigning this back to him! Thank you, Jonathan!

@sadasant sadasant removed their assignment Oct 14, 2020
@sophiajt
Copy link
Contributor

Request on MSAL for reference: AzureAD/microsoft-authentication-library-for-js#2494

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Nov 17, 2020
hide StorageAccountCredentials put (Azure#11670)

* hide StorageAccountCredentials put

* hide StorageAccounts put
@sadasant sadasant assigned sadasant and unassigned sophiajt Feb 9, 2021
@sadasant sadasant modified the milestones: [2021] March, [2021] April Mar 15, 2021
@sadasant
Copy link
Contributor Author

Turns out this is an inconsistency in Python. In JS it can be resolved with the abort signal. I'll close this for now.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants