-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom role definitions #12206
Comments
This is code regeneration based on the latest swagger. One way to see the missing endopoints is to do an API comparison between Key Vault Admin on JS and on .Net. |
@heaths @sadasant is upsert the correct verb here? it's in the TS guidelines as an allowed verb but I wanted to double check (because we don't use upsert much outside of cosmos even though I personally think it makes sense and maps correctly to generate createOrUpdate method) |
We don't have a verb for that in .NET. I asked the same thing in @christothes's .NET PR and asked @KrzysztofCwalina. Given the generated method is That said, I understand there's a mix of both across services. Still, I maintain that "createOrUpdate" is more obvious than "upsert". |
## What - Regenerate swagger to the latest version (and pin it to a sha) - Add CRUD operations for custom role definitions - A few renames from API feedback in roleAssignment ## Why - Now that the swagger is updated with the new RBAC operations we can add support for it resolves #12206
Once Azure/azure-rest-api-specs#11465 is checked in, regenerate source to support custom role definitions.
The text was updated successfully, but these errors were encountered: