Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom role definitions #12206

Closed
heaths opened this issue Oct 31, 2020 · 3 comments · Fixed by #13470
Closed

Add support for custom role definitions #12206

heaths opened this issue Oct 31, 2020 · 3 comments · Fixed by #13470
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@heaths
Copy link
Member

heaths commented Oct 31, 2020

Once Azure/azure-rest-api-specs#11465 is checked in, regenerate source to support custom role definitions.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 31, 2020
@heaths heaths added this to the [2021] February milestone Oct 31, 2020
@sadasant
Copy link
Contributor

This is code regeneration based on the latest swagger. One way to see the missing endopoints is to do an API comparison between Key Vault Admin on JS and on .Net.

@maorleger maorleger added the blocking-release Blocks release label Jan 25, 2021
@maorleger
Copy link
Member

maorleger commented Jan 27, 2021

  • Regenerate from swagger (and pin to sha instead of master)
  • Get role definition
  • Upsert role definition
  • Delete custom role definition (ensure service error is nice)
  • Consider properties bag vs splatting parameters - I need to see what it looks like
  • Add custom role definition to sample
  • Take a pass at existing samples since we've been making API changes

@heaths @sadasant is upsert the correct verb here? it's in the TS guidelines as an allowed verb but I wanted to double check (because we don't use upsert much outside of cosmos even though I personally think it makes sense and maps correctly to generate createOrUpdate method)

@heaths
Copy link
Member Author

heaths commented Jan 29, 2021

We don't have a verb for that in .NET. I asked the same thing in @christothes's .NET PR and asked @KrzysztofCwalina. Given the generated method is createOrUpdate and because that's what we used in the Search APIs, I'm leaning toward createOrUpdate. I mean, it's also the method description and is clearer to customers that want to create or update a method. Not everyone may know what "upsert" means.

That said, I understand there's a mix of both across services. Still, I maintain that "createOrUpdate" is more obvious than "upsert".

maorleger added a commit that referenced this issue Feb 1, 2021
## What

- Regenerate swagger to the latest version (and pin it to a sha)
- Add CRUD operations for custom role definitions
- A few renames from API feedback in roleAssignment

## Why

- Now that the swagger is updated with the new RBAC operations we can add support for it

resolves #12206
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants