Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema Registry Avro] Drop "MessageData" in method names #20814

Closed
deyaaeldeen opened this issue Mar 11, 2022 · 0 comments · Fixed by #20815 or #21164
Closed

[Schema Registry Avro] Drop "MessageData" in method names #20814

deyaaeldeen opened this issue Mar 11, 2022 · 0 comments · Fixed by #20815 or #21164
Assignees
@deyaaeldeen
Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Milestone
[2022] April

Comments

@deyaaeldeen
Copy link
Member

@JoshLove-msft talked to the architects about simplifying method names back to just serialize and deserialize.
@deyaaeldeen deyaaeldeen added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Mar 11, 2022
@deyaaeldeen deyaaeldeen added this to the [2022] April milestone Mar 11, 2022
@deyaaeldeen deyaaeldeen self-assigned this Mar 11, 2022
@deyaaeldeen deyaaeldeen mentioned this issue Mar 11, 2022
Merged
3 tasks
@deyaaeldeen deyaaeldeen mentioned this issue Apr 1, 2022
Merged
3 tasks
deyaaeldeen added a commit that referenced this issue Apr 2, 2022
@deyaaeldeen
Feature/schema registry avro stable (#21164)
01e0ade 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes #20814

### Describe the problem that is addressed by this PR
`serializeMessageData` is too long and can be simplified to `serialize`. This change has been already discussed and approved in the feature branch and this PR just merges it to main in order to get ready for release next week.

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
#20815

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [x] Added a changelog (if necessary)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Projects
None yet
Milestone
[2022] April
1 participant
@deyaaeldeen