Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngSys] Add size monitoring of generated packages to CI #21463

Open
xirzec opened this issue Apr 18, 2022 · 3 comments
Open

[EngSys] Add size monitoring of generated packages to CI #21463

xirzec opened this issue Apr 18, 2022 · 3 comments
Labels
Central-EngSys This issue is owned by the Engineering System team. pillar-performance The issue is related to performance, one of our core engineering pillars.

Comments

@xirzec
Copy link
Member

xirzec commented Apr 18, 2022

Per our last retrospective, there was a desire to configure a mechanism for tracking the packed size of SDKs over time, especially core libraries.

Ideally, we could see the change created by each PR (similar to public API changes) before merging.
@xirzec xirzec added EngSys This issue is impacting the engineering system. pillar-performance The issue is related to performance, one of our core engineering pillars. labels Apr 18, 2022
@jeremymeng jeremymeng added Central-EngSys This issue is owned by the Engineering System team. and removed EngSys This issue is impacting the engineering system. labels Apr 21, 2022
@praveenkuttappan
Copy link
Member

@xirzec Do we want to start failing build job if it is above a threshold level?

@xirzec
Copy link
Member Author

xirzec commented May 3, 2022

@xirzec Do we want to start failing build job if it is above a threshold level?

It's tempting, but I feel like either we'd set the threshold very low and have to keep raising it, or we'd set it high enough that by the time we hit the threshold it would be very difficult to shrink the package.

For now I'd settle for something we can review during release week.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Dec 8, 2022
@p-bouchon @ruslany
@zhenqxuMSFT @najian
CodeGen from PR 21683 in Azure/azure-rest-api-specs
daa139b 
Release app microsoft.app 2022 10 01 (Azure#21683)

* Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AppState and LatestReadyRevisionName (Azure#21034)

* Add new props

* add defaults

* Add swagger for client cert & CORS policy (Azure#21126)

* Fix password format of env domain for 2022-10-01 (Azure#21463)

* fix

* fix

* Remove AppState property as we decided to postpone it (Azure#21483)

* Remove AppState property as we decided to postpone it

* Fix swagger issues

* More swagger fixes

* s360 swagger correctness fixes (Azure#21472)

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Add kind for managed environment (Azure#21589)

* add

* fix

* fix (Azure#21730)

* fix (Azure#21747)

Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
@github-actions GitHub Actions
Copy link

Hi @xirzec, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@jeremymeng jeremymeng reopened this Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Central-EngSys This issue is owned by the Engineering System team. pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
Azure SDK EngSys 📈
Status: 🤔 Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xirzec @jeremymeng @praveenkuttappan