Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default build node version to 16 #21636

Closed
praveenkuttappan opened this issue Apr 27, 2022 · 1 comment
Closed

Update default build node version to 16 #21636

praveenkuttappan opened this issue Apr 27, 2022 · 1 comment
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

JS packages are built using Node 14 currently. We should update default build version to 16 now since we have node 18 also available.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Apr 27, 2022
@praveenkuttappan praveenkuttappan self-assigned this Apr 27, 2022
@praveenkuttappan
Copy link
Member Author

This has already been completed.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Nov 24, 2022
Review request for Microsoft.ContainerService to add version 2022-10-02-preview (Azure#21439)

* Adds base for updating Microsoft.ContainerService from version preview/2022-09-02-preview to version 2022-10-02-preview

* Updates readme

* Updates API version in new specs and examples

* Pmiller/nodeosupgradechannel (Azure#21326)

* missed working comment

* matthew comments

* unpatched is a word

* Add MaintenanceWindow into MaintenanceConfigurationProperties (Azure#21337)

* Add MaintenanceWindow into MaintenanceConfigurationProperties

* Fx PrettierCheck

* Fix ARM ID format for samples (Azure#21402)

* Fix Swagger Model Validation for the 2022-10-02-preview dev branch of container service (Azure#21373)

* fix API version

* fix INVALID_FORMAT byte

* fix INVALID_FORMAT arm-id

* fix missing resource id

* fix LRO_RESPONSE_HEADER

* Update readmes for the 2022-10-02-preview dev branch of container service (Azure#21366)

* update readmes

* remove fleets

* Updating abort apis response to make it long running  (Azure#21362)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* fix 202 location header

* fix ProvisioningState validation

* add x-ms-long-running-operation-options

* fix ResourceNameRestriction

* Fix abort location url in example (Azure#21446)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* Abort api response fix (Azure#21559)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

* Node os upgrade desc fix (Azure#21636)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

* Minor edit to node os upgrade description based on ARM review

Co-authored-by: InduSridhar <indusridhar@microsoft.com>

Co-authored-by: Paul Miller <pmiller@microsoft.com>
Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Co-authored-by: InduSridhar <InduSridhar@users.noreply.github.com>
Co-authored-by: InduSridhar <indusridhar@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

1 participant