Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Monitor Ingestion authZ scope #27280

Closed
scottaddie opened this issue Sep 28, 2023 · 1 comment
Closed

Update Azure Monitor Ingestion authZ scope #27280

scottaddie opened this issue Sep 28, 2023 · 1 comment
Assignees
@sarangan12
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query

Comments

@scottaddie
Copy link
Member

For context, see Azure/azure-sdk-for-net#38998.
@scottaddie scottaddie added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query labels Sep 28, 2023
@scottaddie scottaddie added this to the 2023-10 milestone Sep 28, 2023
@xirzec xirzec assigned sarangan12 and unassigned KarishmaGhiya Nov 22, 2023
@xirzec xirzec removed this from the 2023-10 milestone Nov 22, 2023
@sarangan12 sarangan12 mentioned this issue May 31, 2024
Merged
3 tasks
sarangan12 added a commit that referenced this issue Jun 3, 2024
@sarangan12 @scottaddie
[@azure/monitor-query] Provide sovereign cloud support for monitor SD…
8e2b940 
…Ks (#29871)

### Packages impacted by this PR

1. @azure/monitor-ingestion
2. @azure/monitor-query

### Issues associated with this PR

1. [#27280](#27280) 
2. [#28821](#28821) 

### Describe the problem that is addressed by this PR

In order to support sovereign clouds, we must be able to allow the SDK
users to specify the endpoints and audience parameters. The users could
already specify/modify the endpoint parameter. This PR will enable the
users to do the same for audience.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

No special design concerns to discuss.

### Provide a list of related PRs _(if any)_

#22887

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)

@KarishmaGhiya @srnagar Please review and approve the PR.

@xirzec FYI

---------

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@sarangan12
Copy link
Member

Task Completed: https://www.npmjs.com/package/@azure/monitor-ingestion/v/1.1.0

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarangan12 sarangan12

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sarangan12 @xirzec @KarishmaGhiya @scottaddie