Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/openai] ChatCompletionsToolCall type definition doesn't include the index property #28889

Closed
1 of 3 tasks
RodrigoMural opened this issue Mar 12, 2024 · 5 comments
Closed
1 of 3 tasks
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@RodrigoMural
Copy link

RodrigoMural commented Mar 12, 2024

  • Package Name: @azure/openai
  • Package Version: 1.0.0-alpha.20240229.1
  • Operating system:
  • nodejs
    • version:
  • browser
    • name/version:
  • typescript
    • version:

Describe the bug
The ChatCompletionsToolCall type definition doesn't include the index property, even when the object returned in a chat streaming call includes index. This makes handling toolCalls streaming a bit of a pain.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a streamChatCompletions() call that includes tools.
  2. Note how the received chunks' .choices[#].delta.toolCalls[#] object include an index element that the ChatCompletionsToolCall type doesn't expose.

Expected behavior
The ChatCompletionsToolCall (or a new type definition) includes the index property to be used.

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels Mar 12, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @glharper.

@deyaaeldeen deyaaeldeen self-assigned this Mar 12, 2024
@deyaaeldeen deyaaeldeen removed the Service Attention Workflow: This issue is responsible by Azure service team. label Mar 12, 2024
@minhanh-phan
Copy link
Member

Hi @RodrigoMural, thank you for raising this issue. We are currently working on a fix, and we'll let you know when there is an update. In the meantime, please let us know if you have any additional questions/ concerns. Thank you!

minhanh-phan added a commit that referenced this issue Mar 14, 2024
### Packages impacted by this PR
@azure/openai

### Issues associated with this PR
#28889
@minhanh-phan
Copy link
Member

Hi @RodrigoMural, we have released the new version of @azure/openai@1.0.0-beta.12 here that has the fix. Please give it a try and let us know if you have any extra questions.

@minhanh-phan minhanh-phan added issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Hi @RodrigoMural. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

Copy link

Hi @RodrigoMural, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants