[App Config] updateSyncToken method #14507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HarshaNalluru
requested review from
chradek and
richardpark-msft
as code owners
richardpark-msft
requested changes
Mar 25, 2021
| { syncTokens } as InternalAppConfigurationClientOptions | ||
| ); | ||
| assert.equal( | ||
| client["_syncTokens"]["_currentSyncTokens"].size, |
There was a problem hiding this comment.
You passed in syncTokens here so you don't need to delve into the object private fields to get it.
There was a problem hiding this comment.
client["_syncTokens"] -> syncTokens
| // user treats token as an opaque value (note - this _does_ mutate the appconfigclient) | ||
| // however, this mutations happens regardless since the system can and does return | ||
| // sync token headers during normal operation. | ||
| client.updateSyncToken(eventGridEvent.syncToken); |
There was a problem hiding this comment.
Just to check - there's nothing to test here. I'd remove this test.
pakrym
approved these changes
Mar 25, 2021
…to harshan/app-config/sync-token
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
### TODOs - [x] Add the new `updateSyncToken` method to `AppConfigurationClient` (Picked up pieces from @richardpark-msft's work here Azure#14342.) - [x] Add a unit test - [x] ~~Hoping to add a live test by leveraging the eventgrid SDK~~ - [x] Changelog - [x] Hold off merging - wait for 1.1.1 to be released - [x] What's the new version number for preview? - `1.2.0-beta.1` fine? Reference: PR from .NET Azure/azure-sdk-for-net#18487
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
updateSyncTokenmethod toAppConfigurationClient(Picked up pieces from @richardpark-msft's work here [App Config] FeatureFlag and SecretReference support #14342.)
Hoping to add a live test by leveraging the eventgrid SDK1.2.0-beta.1fine?Reference: PR from .NET Azure/azure-sdk-for-net#18487