[Batch] Include types in shipped package #16874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
dpwatrous,
paterasMSFT and
zfengms
as code owners
ghost
added
the
ramya-rao-a
approved these changes
Aug 12, 2021
What was the reason for the changes in the tsconfig file? |
|
@ramya-rao-a #16679 made the change to the tsconfig.json and I am not super sure on their motivation. It uses a Track 2 convention even though it is still Track 1. I do not mind it though. |
ckairen
pushed a commit
to ckairen/azure-sdk-for-js
that referenced
this pull request
Aug 24, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 30, 2021
Updating k8s version in dualstack to valid version (Azure#16874) Dualstack is only for >= 1.21 in AKS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location of the type declarations changed after batch updated their tsconfig.json file. This PR uses the new location in package.json's files list and types entry. Fixes #16809