Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier dev-dependency to v2.5.1 in Event Hub #19538

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

JonathanCrd
Copy link
Member

Solves: #9329 for packages under sdk/eventhub.

Updated prettier dev-dependency version to latest 2.5.1.
Files were re-formatted as well. There are only format changes in this PR, no manual changes except for package.json files.

Main format changes with Prettier 2.x in this PR include:

  • Trailing commas by default.
  • Whitespace added after every function keyword.

@JonathanCrd
Copy link
Member Author

To fix the CI, I had to remove the path "test/**/*.ts" from the format and check-format mock-hub since there is no test folder in it.

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@deyaaeldeen deyaaeldeen merged commit 99ae9d0 into Azure:main Jan 3, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Jun 28, 2022
Fix name and displayName issues (Azure#19538)

* fix name displayName

* fix enum issue

* Swagger ModelValidation fixes

* fixes

* json fix

* fix enum

* parsing

* json fix

* dummy commit

* adding type

* json fix

* nextlink fix

* remove @ from mgmt

* nextlink revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants