Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage-queue,changefeed,avro] Move to shared rollup config #19616

Merged

Conversation

jeremymeng
Copy link
Member

  • use the shared rollup config from dev-tool
  • remove usage of dotenv from tests as recorder already handles that
  • adjust NPM build scripts
  • remove rollup.test and rollup.base

Part of #17817

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jan 4, 2022
@jeremymeng jeremymeng changed the title [Storage-Queue] Move to shared rollup config [Storage-queue,changefeed,avro] Move to shared rollup config Jan 4, 2022
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) and removed Storage Storage Service (Queues, Blobs, Files) labels Jan 4, 2022
@jeremymeng
Copy link
Member Author

/azp run js - storage-queue - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


export default inputs;
export default makeConfig(require("./package.json"), {
// Disable this until we are ready to run rollup for the browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, I know it's pre-existing, but Is there an issue tracking this work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah #11036

@jeremymeng jeremymeng merged commit 32370ab into Azure:main Jan 5, 2022
@jeremymeng jeremymeng deleted the storage/queue-shared-rollup-config branch January 5, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants