Upgrade prettier to v2.5.1 #19719
Merged
Upgrade prettier to v2.5.1 #19719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanCrd
commented
Jan 6, 2022
| @@ -82,11 +82,11 @@ | |||
| "build:samples": "echo Obsolete.", | |||
| "build:test": "echo skip", | |||
| "build": "npm run clean && tsc -p . && rollup -c 2>&1 && api-extractor run --local", | |||
| "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | |||
There was a problem hiding this comment.
In order to fix the CI, it was necessary to remove the path "test/**/*.ts" from the format and check-format scripts.
This is due to iot-device-update not having a test folder, which throws an error when running any of those scripts.
JonathanCrd
requested review from
benbp,
bterlson,
deyaaeldeen,
hivyas,
mikeharder,
praveenkuttappan,
ramya-rao-a,
weshaggard and
witemple-msft
as code owners
ramya-rao-a
reviewed
Jan 7, 2022
maorleger
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #9329. Upgrade prettier dependencies to latest version (
^2.5.1) in the following folders:Files were re-formatted as well, with two exceptions:
samples/folder, there was no format script, so only the version in package.json files was modified.sdk/quatum/quantum-jobs, the format script is skipped.There are only format changes in this PR, no manual changes except for package.json files.
Main format changes with Prettier 2.x in this PR include:
functionkeyword.