Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agrifood Farming] Regenerate with latest codegen #20059

Merged
2 commits merged into from
Jan 27, 2022
Merged

[Agrifood Farming] Regenerate with latest codegen #20059

2 commits merged into from
Jan 27, 2022

Conversation

joheredi
Copy link
Member

Checklists

  • Added impacted package name to the issue description

Packages impacted by this PR:
@azure-rest/agrifood-farming

Describe the problem that is addressed by this PR:
Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation:

  • Switched away from @azure-rest/core-client-lro and @azure-rest/core-client-paging in favor of @azure/core-lro and @azure/core-client
  • Split Output and Input models

Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
NO

Are there test cases added in this PR?(If not, why?)
NO, it already has tests

Provide a list of related PRs(if any)
#19897

Command used to generate this PR:(Applicable only to SDK release request PRs)
rushx generate:client

@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure-rest/agrifood-farming. You can review API changes here

@joheredi joheredi mentioned this pull request Jan 25, 2022
1 task
Copy link
Member

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine. But, I see some breaking changes. But there is no change in the version or package.json. Is this expected? Please confirm before merging

@joheredi
Copy link
Member Author

@sarangan12 we haven't released beta.2 so will keep it for the next release. Added a changelog entry

@ghost
Copy link

ghost commented Jan 27, 2022

Hello @joheredi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7eb4967 into Azure:main Jan 27, 2022
sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this pull request Jan 28, 2022
**Checklists** 
- [x] Added impacted package name to the issue description

**Packages impacted by this PR:**
@azure-rest/agrifood-farming

**Describe the problem that is addressed by this PR:**
Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation:

- Switched away from @azure-rest/core-client-lro and @azure-rest/core-client-paging in favor of @azure/core-lro and @azure/core-client
- Split Output and Input models



**Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
NO

**Are there test cases added in this PR?**_(If not, why?)_
NO, it already has tests

**Provide a list of related PRs**_(if any)_
Azure#19897

**Command used to generate this PR:**_(Applicable only to SDK release request PRs)_
`rushx generate:client`
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Aug 2, 2022
modify appcontainers readme.typescript.md (Azure#20059)

Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants