-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agrifood Farming] Regenerate with latest codegen #20059
Conversation
API changes have been detected in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine. But, I see some breaking changes. But there is no change in the version or package.json. Is this expected? Please confirm before merging
@sarangan12 we haven't released beta.2 so will keep it for the next release. Added a changelog entry |
Hello @joheredi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
**Checklists** - [x] Added impacted package name to the issue description **Packages impacted by this PR:** @azure-rest/agrifood-farming **Describe the problem that is addressed by this PR:** Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation: - Switched away from @azure-rest/core-client-lro and @azure-rest/core-client-paging in favor of @azure/core-lro and @azure/core-client - Split Output and Input models **Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ NO **Are there test cases added in this PR?**_(If not, why?)_ NO, it already has tests **Provide a list of related PRs**_(if any)_ Azure#19897 **Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ `rushx generate:client`
modify appcontainers readme.typescript.md (Azure#20059) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <v-ziweichen@microsoft.com>
Checklists
Packages impacted by this PR:
@azure-rest/agrifood-farming
Describe the problem that is addressed by this PR:
Re-generate Agrifood Farming using the latest version of RLC generator. This package was one of the first-ever RLCs generated and codegen has changes quite a bit since then. Regenerating against the same swagger. Major changes since last generation:
Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
NO
Are there test cases added in this PR?(If not, why?)
NO, it already has tests
Provide a list of related PRs(if any)
#19897
Command used to generate this PR:(Applicable only to SDK release request PRs)
rushx generate:client