[Form Recognizer] Migrate tests to the new recorder #20264
Conversation
ghost
added
the
HarshaNalluru
requested review from
benbp and
praveenkuttappan
as code owners
| client = new DocumentAnalysisClient(endpoint(), makeCredential(useAad)); | ||
| beforeEach(async function (this: Context) { | ||
| recorder = await createRecorder(this.currentTest); | ||
| await recorder.setMatcher("BodilessMatcher"); |
There was a problem hiding this comment.
Bodiless matcher since the proxy tool complained that the bodies are not matching with the ones in the recording.
There was a problem hiding this comment.
Azure/azure-sdk-tools#2723 logged - to investigate further.
BodilessMatcher should be fine anyway.
There was a problem hiding this comment.
I actually support this for FR regardless of whether or not the bodies match. It puts us one step closer to not even recording them in the first place.
There was a problem hiding this comment.
#20266 tracks the work to skip recording the request body
| return recorder; | ||
| } | ||
|
|
||
| export async function createRecordedClient<T>( |
There was a problem hiding this comment.
I'm glad it was simple enough to fit this into the existing createRecordedClient higher-order function.
|
/azp run js - form-recognizer - tests |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
|
/azp run js - ai-form-recognizer - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
As the title says, this PR migrates the FR tests to the new recorder