Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Add return types to test/utils methods #20510

Merged
merged 1 commit into from
Feb 23, 2022
Merged

[Recorder] Add return types to test/utils methods #20510

merged 1 commit into from
Feb 23, 2022

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Feb 23, 2022 •
edited
Loading

Fixes #20511 '

Aims to fix this error.

test/utils/utils.ts(32,23): error TS2742: The inferred type of 'makeRequestAndVerifyResponse' cannot be named without a reference to '../../../../../common/temp/node_modules/.pnpm/@azure+core-rest-pipeline@1.5.0/node_modules/@azure/core-rest-pipeline/core-rest-pipeline.shims'. This is likely not portable. A type annotation is necessary.

@HarshaNalluru
Copy link
Member Author

/azp run js - eventgrid

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru HarshaNalluru mentioned this pull request Feb 23, 2022
Closed
@HarshaNalluru HarshaNalluru marked this pull request as ready for review February 23, 2022 20:49
@HarshaNalluru HarshaNalluru changed the title add return types [Recorder] Add return types Feb 23, 2022
@HarshaNalluru HarshaNalluru changed the title [Recorder] Add return types [Recorder] Add return types to test/utils methods Feb 23, 2022
@HarshaNalluru HarshaNalluru merged commit d70157c into Azure:main Feb 23, 2022
@HarshaNalluru HarshaNalluru deleted the harshan/eventgrid-build-failures branch February 23, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timovv timovv timovv approved these changes

@sadasant sadasant Awaiting requested review from sadasant

@ellismg ellismg Awaiting requested review from ellismg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Event Grid] CI - "js - eventgrid" pipeline fails at the build step for "scheduled builds"
2 participants
@HarshaNalluru @timovv