Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] migrate to @azure/core-tracing v1.0.0 #22517

Merged
merged 14 commits into from
Jul 12, 2022

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Jul 8, 2022

This PR does migration to latest core-tracing API similar to the Event Hubs migration (PR #20240)

  • Remove internal methods of creating spans in favor of tracingClient.withSpan
  • Update tests to utilize assert.supportsTracing from test-utils
  • Remove tests that are no longer needed.

Packages impacted by this PR

@azure/service-bus

Issues associated with this PR

#21246

@@ -637,8 +636,6 @@ export type TransferProgressEvent = {

// @public
export interface TryAddOptions {
// @deprecated (undocumented)
parentSpan?: Span | SpanContext | null;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor version bump probably enough for this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-service-bus

@jeremymeng jeremymeng merged commit 8bbc58b into Azure:main Jul 12, 2022
@jeremymeng jeremymeng deleted the sb/core-tracing-v1 branch July 12, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants