Add encoding utils in core utils #26592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
bterlson,
xirzec,
jeremymeng and
deyaaeldeen
as code owners
qiaozha
changed the title
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
joheredi
reviewed
Jul 26, 2023
xirzec
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Minor remarks, but otherwise seems good.
@mpodwysocki I think you looked at doing this before, any feedback before we merge?
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
@xirzec The only feedback I have is that |
mpodwysocki
reviewed
Aug 1, 2023
mpodwysocki
approved these changes
Aug 1, 2023
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
Partially fix Azure/autorest.typescript#1933 Add some helper function in core-util to support converter from bytes array to string with different kinds of character encoding. Currently only support base64 and utf-8 and base64url. which should be able to work in both Node environment and browser environment. We will need to wait for typespec team's response to see if we need to support more. issue tracked here microsoft/typespec#2204 --------- Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix Azure/autorest.typescript#1933
Add some helper function in core-util to support converter from bytes array to string with different kinds of character encoding. Currently only support base64 and utf-8 and base64url. which should be able to work in both Node environment and browser environment.
We will need to wait for typespec team's response to see if we need to support more. issue tracked here microsoft/typespec#2204