Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeJS version 21.x to test matrix #27458

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Oct 18, 2023

No description provided.

@ckairen ckairen added the Central-EngSys This issue is owned by the Engineering System team. label Oct 18, 2023
@ckairen ckairen self-assigned this Oct 18, 2023
@benbp
Copy link
Member

benbp commented Oct 18, 2023

Is the intent we add this for all tests or just a subset? If the former, there are a few more places these versions show up, see #27302

@ckairen
Copy link
Member Author

ckairen commented Oct 19, 2023

Is the intent we add this for all tests or just a subset? If the former, there are a few more places these versions show up, see #27302

21 will soon be current in a couple of days, we'll probably want it in all tests? (we also did the same to node 17)

@mikeharder
Copy link
Member

Is the intent we add this for all tests or just a subset? If the former, there are a few more places these versions show up, see #27302

21 will soon be current in a couple of days, we'll probably want it in all tests? (we also did the same to node 17)

Please try to see if any of the duplicate copies of node versions can be refactored to use a single copy we can update in one place.

@benbp
Copy link
Member

benbp commented Oct 19, 2023

@mikeharder I don't think there's much improvement here. The values are all set in different service directory custom matrix files. We'd have to introduce some sort of global variable for matrix pattern which I think is not worth it.

@ckairen ckairen merged commit d36364b into Azure:main Nov 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants