Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @type/mocha in package.json #28422

Merged
merged 3 commits into from
Jan 31, 2024
Merged

add @type/mocha in package.json #28422

merged 3 commits into from
Jan 31, 2024

Conversation

kazrael2119
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 31, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jeremymeng
jeremymeng approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Do you know why the build started failing?

@kazrael2119
Copy link
Contributor Author

Thanks for the fix! Do you know why the build started failing?

I don't know, but I will add this dependency in all the package.json in this pr

@jeremymeng
Copy link
Member

I don't know, but I will add this dependency in all the package.json in this pr

@kazrael2119 we can merge this now to unblock js - core - ci pipeline, and update other packages later.

@jeremymeng
Copy link
Member

jeremymeng commented Jan 31, 2024 •
edited
Loading

I also opened a PR to revert my previous change which looks like it broke the build #28423

@qiaozha
Copy link
Member

qiaozha commented Jan 31, 2024

@jeremymeng should we merge this one or yours?

@jeremymeng
Copy link
Member

should we merge this one or yours?

we can merge this too as @types/mocha should be a dev dependency and not rely on other weird behaviors. But we can fix the rest of packages later. I will check whether codegen adds it properly.

@jeremymeng jeremymeng merged commit a70ea73 into Azure:main Jan 31, 2024
33 checks passed
@kazrael2119 kazrael2119 deleted the update-dep branch January 31, 2024 08:17
@jeremymeng
Copy link
Member

@kazrael2119 I will fix the rest of packages and merge into main directly to avoid triggering massive number of build pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@qiaozha qiaozha qiaozha approved these changes

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazrael2119 @azure-sdk @jeremymeng @qiaozha