Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Increase major version to 11 #2858

Merged
merged 3 commits into from
May 17, 2019
Merged

[Storage] Increase major version to 11 #2858

merged 3 commits into from
May 17, 2019

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng
Copy link
Member Author

Should I have the -preview.1 suffix in the package.json? or we can do npm preview tags without having to change the verion in package.json?

@KarishmaGhiya
Copy link
Member

Should I have the -preview.1 suffix in the package.json? or we can do npm preview tags without having to change the verion in package.json?

Yes if it's a preview we need to add that suffix @jeremymeng

XiaoningLiu
XiaoningLiu requested changes May 14, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides package.json please update version constant in constant.ts, and check no other doc/doc refers to the old version.

@jeremymeng
Copy link
Member Author

For other files, I've only found references of the old versions in BreakingChanges.md, which I don't think need update.

@jeremymeng jeremymeng merged commit bd83b26 into Azure:feature/storage May 17, 2019
@jeremymeng jeremymeng deleted the major-version-bump branch May 17, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremymeng @KarishmaGhiya @XiaoningLiu