Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage-file] Rename *URL to *Client #2877

Merged
merged 4 commits into from
May 15, 2019
Merged

[Storage-file] Rename *URL to *Client #2877

merged 4 commits into from
May 15, 2019

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng changed the base branch from master to feature/storage May 14, 2019 00:18
@jeremymeng
Copy link
Member Author

/azp run azure-sdk-for-js - all-tests - storage-file

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

XiaoningLiu
XiaoningLiu approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please make sure sample code in readme.md is good after code change.

@jeremymeng
Copy link
Member Author

please make sure sample code in readme.md is good after code change

Good point! I found an issue and fixed the sample code.

@jeremymeng
Copy link
Member Author

/azp run azure-sdk-for-js - all-tests - storage-file

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeremymeng jeremymeng merged commit 7cad284 into Azure:feature/storage May 15, 2019
@jeremymeng jeremymeng deleted the storage-file-rename-clients branch May 15, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremymeng @XiaoningLiu