-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instrumentation] Uprade to the latest OTEL #28811
Conversation
API change check API changes are not detected in this pull request. |
@@ -270,7 +270,7 @@ describe("OpenTelemetryInstrumenter", () => { | |||
|
|||
// Function syntax | |||
instrumenter.withContext(context.active(), function (this: any) { | |||
assert.notExists(this); | |||
assert.isDefined(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems weird to me, but I don't want to block the PR. Feel free to pend the test and assign an issue to me to review it more closely. It's been like 2 years 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah feels like it should be undefined as it's not being explicitly bound to anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this
@@ -270,7 +270,7 @@ describe("OpenTelemetryInstrumenter", () => { | |||
|
|||
// Function syntax | |||
instrumenter.withContext(context.active(), function (this: any) { | |||
assert.notExists(this); | |||
assert.isDefined(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah feels like it should be undefined as it's not being explicitly bound to anything?
/check-enforcer reset |
/check-enforcer evaluate |
@microsoft-github-policy-service rerun |
/check-enforcer reset |
/check-enforcer evaluate |
Packages impacted by this PR
@azure/opentelemetry-instrumentation-azure-sdk
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates to latest OTEL
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists